Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVZbu-0000pZ-Bw for pgsql-hackers@arkaria.postgresql.org; Fri, 24 Feb 2023 15:03:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZbt-0003XO-2e for pgsql-hackers@arkaria.postgresql.org; Fri, 24 Feb 2023 15:03:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVZbr-0003XF-RZ for pgsql-hackers@lists.postgresql.org; Fri, 24 Feb 2023 15:03:44 +0000 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVZbn-0002Rp-0C for pgsql-hackers@postgresql.org; Fri, 24 Feb 2023 15:03:43 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 3709C2B0682A; Fri, 24 Feb 2023 10:03:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 24 Feb 2023 10:03:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1677251012; x= 1677258212; bh=mefWASw4grer4cmwsoSXGtdRNKFmS9Fa6GY7pZxG/2Q=; b=T 4wRVEeaiDG80Q2+9hilYX74iJtWJ4MqtYCFV8bhNwT14nKZOMRW1WkAKKiP6luwh oYL8A/b4sMHJ2AJdfoeGU2aitoDZ93Qr4LHFbJHJIBd+5PhgxlsEABMwrsqgB3go i2Q7+VUa2XZS3+0+eGk9ju1Zx0H+iObl56OyQ8wcXirV+W2e0hm+ksUzREoouN/d mBoXL2uDhxIxyj9oqDbFbm32shGN8Z6iFGEPXMxMnxb91foa6LlJNkt/ICzHZzsS 3R68A4kv5uEDRiKYnAE24n5DGiGhBy/QMykKRxfPZqaZfbWSSMJyS6Ar4FhOB2qT Lnia4kw2fb3gVvDGuSEJw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekfedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehleffgeegudejteei hfelteduvdeifffhffdvjedvffegjeekudeludehudeifeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Feb 2023 10:03:32 -0500 (EST) Message-ID: <88a42542-4661-97ec-5c76-4421f6a91c38@enterprisedb.com> Date: Fri, 24 Feb 2023 16:03:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: pgindent vs. git whitespace check Content-Language: en-US To: Alvaro Herrera Cc: pgsql-hackers References: <20230222144948.svf2szymuqbjfebs@alvherre.pgsql> From: Peter Eisentraut In-Reply-To: <20230222144948.svf2szymuqbjfebs@alvherre.pgsql> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 22.02.23 15:49, Alvaro Herrera wrote: > On 2023-Feb-22, Peter Eisentraut wrote: > >> In the meantime, I suggest we work around this, perhaps by >> >> conn = libpqsrv_connect_params(keywords, values, /* expand_dbname = */ false, >> PG_WAIT_EXTENSION); > > I suggest > > conn = libpqsrv_connect_params(keywords, values, > false, /* expand_dbname */ > PG_WAIT_EXTENSION); > > which is what we typically do elsewhere and doesn't go overlength. Fixed this way.