Content-Type: multipart/alternative;
 boundary="------------z4X7AfLYVtCWPHI7mvDK5u0e"
Message-ID: <88e65a15-2b52-4b44-a636-3736ca030b09@tantorlabs.com>
Date: Sat, 11 Jan 2025 21:21:16 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: explain analyze rows=%.0f
To: Guillaume Lelarge <guillaume@lelarge.info>
Cc: Daniel Gustafsson <daniel@yesql.se>, Ibrar Ahmed <ibrar.ahmad@gmail.com>,
 "Gregory Stark (as CFM)" <stark.cfm@gmail.com>, Tom Lane
 <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
 Amit Kapila <amit.kapila16@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>,
 Peter Geoghegan <pg@bowt.ie>, vignesh C <vignesh21@gmail.com>,
 "David G. Johnston" <david.g.johnston@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <CA+TgmoZv8DvmeQHQAX+rkn68id2N+DoUhFZB36d-_w1tyAeqeA@mail.gmail.com>
 <20220707222015.GD13040@telsasoft.com>
 <CAA4eK1Lmo0FX6Nfr_k3-UX1Hpei1H-xPHL6Wwx7SLUP3s+O1mA@mail.gmail.com>
 <CA+Tgmob0BBeK6GEMUQBPiv0kJpTJSEgX+OUD2FeY42zWVgJuLw@mail.gmail.com>
 <2954811.1667711530@sss.pgh.pa.us>
 <CALtqXTfM3GJbFsB63ajfHcYvFhUA0ySX4f4MVS3Dau2vopU+Rw@mail.gmail.com>
 <CAM-w4HNLRO8QJvF3x13wjjdkJHobORxaKrcuyF1cKaTiXuvDbA@mail.gmail.com>
 <CALtqXTcZE6YW=m9ZmNU6sRJ+RTC15NFc__foP1S2KaWvGOf6JA@mail.gmail.com>
 <DBBD7E90-677A-4BF3-A5DD-B1A5D12F800C@yesql.se>
 <A141D263-CA95-4873-BCC7-2573C908DAED@yesql.se>
 <c54a600c-31f8-4db6-b049-e643ae812d38@tantorlabs.com>
 <CAECtzeVpocPwcQ0ccrXsmcvH_8YkJBdUfsJCzb8NKrEodmCg_w@mail.gmail.com>
 <55695d15-c738-4401-8883-58bc855c9b03@tantorlabs.com>
 <CAECtzeUz=8HSUnNMF+mbLywH+JVZ9uJv-b-=O1dTT4KZAFPyhQ@mail.gmail.com>
Content-Language: en-US
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
In-Reply-To: <CAECtzeUz=8HSUnNMF+mbLywH+JVZ9uJv-b-=O1dTT4KZAFPyhQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/88e65a15-2b52-4b44-a636-3736ca030b09%40tantorlabs.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------z4X7AfLYVtCWPHI7mvDK5u0e
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 11.01.2025 17:02, Guillaume Lelarge wrote:
> Le sam. 11 janv. 2025 à 12:10, Ilia Evdokimov 
> <ilya.evdokimov@tantorlabs.com> a écrit :
>
>
>     On 11.01.2025 12:15, Guillaume Lelarge wrote:
>>
>>
>>     Thanks for your patch, this looks like a very interesting feature
>>     that I'd like to see in a future release.
>>
>>     It did a quick run: patch OK, make OK, make install OK, but make
>>     check fails quite a lot on partition_prune.sql.
>>
>>     I guess it would need some work on partition_prune.sql tests and
>>     perhaps also on the docs.
>>
>>     Thanks again.
>>
>>
>>     -- 
>>     Guillaume.
>
>
>     Yes, certainly. I have fixed partition_prune.sql. In the
>     documentation example for EXPLAIN ANALYZE where loops is greater
>     than one, I updated how 'rows' and 'loops' values are displayed so
>     they appear as decimal fractions with two digits after the decimal
>     point.
>
>     I attached fixed patch.
>
>     Any suggestions?
>
>
> Thanks for the updated patch.
>
> "make check" is happy, so no more suggestions, except you should 
> register it in the next commitfest.
>
>
> -- 
> Guillaume.


Done!

https://commitfest.postgresql.org/52/5501/

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

--------------z4X7AfLYVtCWPHI7mvDK5u0e
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 11.01.2025 17:02, Guillaume Lelarge
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAECtzeUz=8HSUnNMF+mbLywH+JVZ9uJv-b-=O1dTT4KZAFPyhQ@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div class="gmail_quote gmail_quote_container">
          <div dir="ltr" class="gmail_attr">Le sam. 11 janv. 2025
            à 12:10, Ilia Evdokimov &lt;<a
              href="mailto:ilya.evdokimov@tantorlabs.com"
              moz-do-not-send="true" class="moz-txt-link-freetext">ilya.evdokimov@tantorlabs.com</a>&gt;
            a écrit :<br>
          </div>
          <blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
            <div>
              <p><br>
              </p>
              <div>On 11.01.2025 12:15, Guillaume Lelarge wrote:<br>
              </div>
              <blockquote type="cite"> <br>
                <div dir="ltr">
                  <div class="gmail_quote">
                    <div><br>
                    </div>
                    <div>Thanks for your patch, this looks like a very
                      interesting feature that I'd like to see in a
                      future release.</div>
                    <div><br>
                    </div>
                    <div>It did a quick run: patch OK, make OK, make
                      install OK, but make check fails quite a lot on
                      partition_prune.sql.</div>
                    <div><br>
                    </div>
                    <div>I guess it would need some work on
                      partition_prune.sql tests and perhaps also on the
                      docs.</div>
                    <div><br>
                    </div>
                    <div>Thanks again.<br>
                    </div>
                    <div><br>
                    </div>
                    <div><br>
                    </div>
                  </div>
                  <span class="gmail_signature_prefix">-- </span><br>
                  <div dir="ltr" class="gmail_signature">
                    <div dir="ltr">
                      <div>
                        <div dir="ltr">
                          <div>Guillaume.<br>
                          </div>
                        </div>
                      </div>
                    </div>
                  </div>
                </div>
              </blockquote>
              <p><br>
              </p>
              <p>Yes, certainly. I have fixed partition_prune.sql. In
                the documentation example for EXPLAIN ANALYZE where
                loops is greater than one, I updated how 'rows' and
                'loops' values are displayed so they appear as decimal
                fractions with two digits after the decimal point.</p>
              <p>I attached fixed patch.<br>
              </p>
              <p>Any suggestions?</p>
            </div>
          </blockquote>
          <div><br>
          </div>
          <div>Thanks for the updated patch.<br>
          </div>
          <div><br>
          </div>
          <div>"make check" is happy, so no more suggestions, except you
            should register it in the next commitfest.</div>
        </div>
        <div><br clear="all">
        </div>
        <br>
        <span class="gmail_signature_prefix">-- </span><br>
        <div dir="ltr" class="gmail_signature">
          <div dir="ltr">
            <div>
              <div dir="ltr">
                <div>Guillaume.<br>
                </div>
              </div>
            </div>
          </div>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p>Done!</p>
    <p><a class="moz-txt-link-freetext" href="https://commitfest.postgresql.org/52/5501/">https://commitfest.postgresql.org/52/5501/</a><br>
    </p>
    <p>--<br>
      Best regards,<br>
      Ilia Evdokimov,<br>
      Tantor Labs LLC.<br>
    </p>
  </body>
</html>

--------------z4X7AfLYVtCWPHI7mvDK5u0e--