Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clO8y-00089T-In for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Mar 2017 23:03:48 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1clO8y-0002Vc-5g for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Mar 2017 23:03:48 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1clO8w-0002U9-Rh for pgsql-hackers@postgresql.org; Tue, 07 Mar 2017 23:03:47 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1clO8q-0005oi-DJ for pgsql-hackers@postgresql.org; Tue, 07 Mar 2017 23:03:45 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v27N3cJ3008914; Tue, 7 Mar 2017 18:03:38 -0500 From: Tom Lane To: Robert Haas cc: "pgsql-hackers@postgresql.org" Subject: Re: Bizarre choice of case for RELKIND_PARTITIONED_TABLE In-reply-to: References: <27899.1488909319@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Tue, 07 Mar 2017 14:25:55 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8912.1488927818.1@sss.pgh.pa.us> Date: Tue, 07 Mar 2017 18:03:38 -0500 Message-ID: <8913.1488927818@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Robert Haas writes: > On Tue, Mar 7, 2017 at 12:55 PM, Tom Lane wrote: >> Is there a good reason why RELKIND_PARTITIONED_TABLE is 'P' not 'p'? > I can't muster a lot of outrage about this one way or another. One > possible advantage of 'P' is that there are fewer places where 'P' is > mentioned in the source code than 'p'. Hm, one would hope that the vast majority of code references are neither of those, but rather "RELKIND_PARTITIONED_TABLE". information_schema.sql and system_views.sql will need to be gone over carefully, certainly, but we shouldn't be hard-coding this anywhere that there's a reasonable alternative. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers