Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1khEVy-00006c-Dh
	for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Nov 2020 16:16:30 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1khEVx-0007Wo-Cs
	for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Nov 2020 16:16:29 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1khEVx-0007Wh-64
	for pgsql-hackers@lists.postgresql.org; Mon, 23 Nov 2020 16:16:29 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1khEVv-0000h8-66
	for pgsql-hackers@lists.postgresql.org; Mon, 23 Nov 2020 16:16:28 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 0ANGGLV1089194;
	Mon, 23 Nov 2020 11:16:21 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
cc: Mikhail Titov <mlt@gmx.us>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [bug+patch] Inserting DEFAULT into generated columns from VALUES
 RTE
In-reply-to: 
 <CAEZATCWSaNs9hihPBqxFqAQ-N0uqatPcPA118sUe9yxyEb4MTA@mail.gmail.com>
References: <9q0sgcr416t.fsf@gmx.us>
 <CAFj8pRC4Y2V3B0HjiPNcpwMfgd2Pj4bTJQJHtZuG=g2Nx5Puiw@mail.gmail.com>
 <9q0o8nd6lvx.fsf@gmx.us> <1501863.1599428560@sss.pgh.pa.us>
 <CAEZATCVaZNONSW1yEZsAe6U_-O0kqyPTv_N4_60ydd=ot7y79Q@mail.gmail.com>
 <1869094.1606078685@sss.pgh.pa.us>
 <CAEZATCWSaNs9hihPBqxFqAQ-N0uqatPcPA118sUe9yxyEb4MTA@mail.gmail.com>
Comments: In-reply-to Dean Rasheed <dean.a.rasheed@gmail.com>
	message dated "Mon, 23 Nov 2020 14:45:18 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <89192.1606148181.1@sss.pgh.pa.us>
Date: Mon, 23 Nov 2020 11:16:21 -0500
Message-ID: <89193.1606148181@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> On Sun, 22 Nov 2020 at 20:58, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> However, I think that just adjusting the error string would be
>> helpful, as attached.

> +1

>> (I'm also wondering why the second case is generic ERRCODE_SYNTAX_ERROR
>> and not ERRCODE_GENERATED_ALWAYS.  Didn't change it here, though.)

> I can't see any reason for it to be different, and
> ERRCODE_GENERATED_ALWAYS seems like the right code to use for both
> cases.

Sounds good to me; pushed that way.

			regards, tom lane