Message-ID: <891df2c6-9f41-4b5e-80c7-fe489decf1ad@iki.fi>
Date: Tue, 14 Apr 2026 12:20:15 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Fix missing pfree(flags.data) in overexplain_debug
To: Lakshmi N <lakshmin.jhs@gmail.com>, pgsql-hackers@lists.postgresql.org
References: 
 <CA+3i_M9_R4t62NPqoa0pjkffMFzLeU30xGdBV4C-PUGHGh5W=w@mail.gmail.com>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: 
 <CA+3i_M9_R4t62NPqoa0pjkffMFzLeU30xGdBV4C-PUGHGh5W=w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/891df2c6-9f41-4b5e-80c7-fe489decf1ad%40iki.fi>
Precedence: bulk

On 13/04/2026 23:33, Lakshmi N wrote:
> Hi hackers,
> 
> attached a small patch to fix missing  pfree(flags.data) in 
> overexplain_debug.

These leaks are to a relatively short-lived memory context. We don't 
need to meticulously pfree() those, they will go away with the memory 
context. There are also numerous psprintf() calls in the function and in 
the subroutines which are not pfreed, for example.

We're not totally consistent, as there are pfree() calls in some of the 
subroutines. I don't know if there's some grand plan on when to pfree() 
and when not to bother, but this one pfree() won't move the needle much 
in any case.

- Heikki