Feedback-ID: i131946ab:Fastmail
Message-ID: <8935187f-0312-afd6-142a-f48142178dcb@enterprisedb.com>
Date: Sat, 7 Jan 2023 08:21:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.0
Subject: Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions
Content-Language: en-US
To: Aleksander Alekseev <aleksander@timescale.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Andres Freund <andres@anarazel.de>,
 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 David Rowley <dgrowleyml@gmail.com>
References: <CAJ7c6TM2=08mNKD9aJg8vEY9hd+G4L7+Nvh30UiNT3kShgRgNg@mail.gmail.com>
 <20221122173156.6ye6xpcsrxok6ela@awork3.anarazel.de>
 <CAJ7c6TO8VcipfRwEA1B3o1bzr2qsvm-vaTM4ghyD7HJJFR2nKw@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <CAJ7c6TO8VcipfRwEA1B3o1bzr2qsvm-vaTM4ghyD7HJJFR2nKw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/8935187f-0312-afd6-142a-f48142178dcb%40enterprisedb.com>
Precedence: bulk

On 23.11.22 14:57, Aleksander Alekseev wrote:
> Hi Andres,
> 
> Thanks for the review!
> 
>> I don't think it is correct for any of these to add const. The only reason it
>> works is because of casting etc.
> 
> Fair enough. PFA the corrected patch v2.

This patch version looks correct to me.  It is almost the same as the 
one that Andres had posted in his thread, except that yours also 
modifies slist_delete() and dlist_member_check().  Both of these changes 
also look correct to me.