Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M331352=pgsql-hackers-arkari@postgresql.org>)
	id 1dVfCN-0000X2-Ic
	for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Jul 2017 14:34:36 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M331352=pgsql-hackers-arkari@postgresql.org>)
	id 1dVfCM-00044k-Mh
	for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Jul 2017 14:34:34 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <m.polyakova@postgrespro.ru>)
	id 1dVfCL-00040k-CH
	for pgsql-hackers@postgresql.org; Thu, 13 Jul 2017 14:34:33 +0000
Received: from mail.postgrespro.ru ([93.174.131.138])
	by magus.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <m.polyakova@postgrespro.ru>)
	id 1dVfCI-0005Ky-IR
	for pgsql-hackers@postgresql.org; Thu, 13 Jul 2017 14:34:32 +0000
Received: from localhost (localhost [127.0.0.1])
	by mail.postgrespro.ru (Postfix) with ESMTP id 3AC2221C03E2;
	Thu, 13 Jul 2017 17:34:30 +0300 (MSK)
X-Virus-Scanned: Debian amavisd-new at postgrespro.ru
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru;
	s=mail; t=1499956470;
	bh=SF7Wue/aAwlVPVBANrKQ0RHYONncNhOVfhIb8zJSTqE=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References;
	b=Jgpr40dKIG6NrqklrXF9HwsKHyYenv4RrD47Aq9YrLVTDx9eopa9xD4eQVjVKil3+
	 MDcWbsxaHV5oKiR6uwiip0fX4Zwt8Z3Ab7taSJ2efZGNI1rPXv1MkhuGYJ0vrqlJzt
	 +6MuP8SZxOQid89ZOhEik2TbFfh4Mh+F0R88SoKo=
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 13 Jul 2017 17:34:30 +0300
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>, Kevin Grittner
 <kgrittn@gmail.com>, Andres Freund <andres@anarazel.de>, Alvaro Herrera
 <alvherre@2ndquadrant.com>, Thomas Munro <thomas.munro@enterprisedb.com>,
 Robert Haas <robertmhaas@gmail.com>
Subject: Re: WIP Patch: Pgbench Serialization and deadlock errors
Organization: Postgres Professional
In-Reply-To: <alpine.DEB.2.20.1707121338090.12795@lancre>
References: <72a0d590d6ba06f242d75c2e641820ec@postgrespro.ru>
 <alpine.DEB.2.20.1707011607370.6840@lancre>
 <6b4a7fb36c9956595a89a08e5368a9c5@postgrespro.ru>
 <alpine.DEB.2.20.1707031321370.3419@lancre>
 <01df6ca86c78e2c80b4e4d021c99d53a@postgrespro.ru>
 <alpine.DEB.2.20.1707031430380.15247@lancre>
 <f69d534dfada1fdb4767496b7ffc007f@postgrespro.ru>
 <alpine.DEB.2.20.1707121142300.12795@lancre>
 <alpine.DEB.2.20.1707121338090.12795@lancre>
Message-ID: <898b57f7c12b6bd0484f8ca58fdf8436@postgrespro.ru>
X-Sender: m.polyakova@postgrespro.ru
User-Agent: Roundcube Webmail/1.2.4
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

> Another detail I forgot about this point: there may be a memory leak
> on variables copies, ISTM that the "variables" array is never freed.
> 
> I was not convinced by the overall memory management around variables
> to begin with, and it is even less so with their new copy management.
> Maybe having a clean "Variables" data structure could help improve the
> situation.

Ok!

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers