Subject: Re: TAP tests and symlinks on Windows
To: Michael Paquier <michael@paquier.xyz>
References: <c50a646c-d9bb-7c62-a4bf-8256ff6ff338@2ndquadrant.com>
 <20200609071931.GE38342@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <89a38304-8900-2e6b-de26-19a0312f3a87@2ndquadrant.com>
Date: Tue, 9 Jun 2020 09:28:04 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200609071931.GE38342@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-06-09 09:19, Michael Paquier wrote:
> On Mon, Jun 08, 2020 at 02:44:31PM +0200, Peter Eisentraut wrote:
>> both contain a TAP skip notice "symlinks not supported on Windows".
>>
>> This is untrue.  Symlinks certainly work on Windows, and we have other TAP
>> tests using them, for example for tablespaces.
> 
>> pg_rewind/t/004_pg_xlog_symlink.pl passes for me on Windows if I just remove
>> the skip stuff.  My attached patch does that.
> 
> What's the version of your perl installation on Windows?  With 5.22, I
> am still seeing that symlink() is not implemented, causing the tests
> of pg_rewind to blow in flight with your patch (MSVC 2015 here).

I was using MSYS2 and the Perl version appears to have been 5.30.2. 
Note sure which one of these two factors makes the difference.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services