Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.1\))
Subject: Re: COMMENT/SEC LABEL tab complete support suggests wrong SQL.
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CALdSSPgcdsj9T3w0i1mc1ujWJGVJuQzGnnOxNNaG4QunP3hMpQ@mail.gmail.com>
Date: Fri, 18 Sep 2026 16:27:50 +0800
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <8AF39AC6-0FFF-4365-A390-CDA993E84797@gmail.com>
References: 
 <CALdSSPgcdsj9T3w0i1mc1ujWJGVJuQzGnnOxNNaG4QunP3hMpQ@mail.gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/8AF39AC6-0FFF-4365-A390-CDA993E84797%40gmail.com>
Precedence: bulk


> On Sep 18, 2026, at 16:01, Kirill Reshke <reshkekirill@gmail.com> =
wrote:
>=20
> HI!
>=20
> I noticed an issue on tab completion with LARGE OBJECT support. I am
> aware that tab complete support need not to be always-correct, but
> this cases are simple, so decided to fix.
>=20
> The psql tab completion for COMMENT ON and SECURITY LABEL ON suggests
> "IS" immediately after "LARGE OBJECT", this produces invalid SQL:
>=20
>  =3D# COMMENT ON LARGE OBJECT <TAB>
>  -- now COMMENT ON LARGE OBJECT IS
>=20
> The same bug exists for SECURITY LABEL. SEC LABEL also missed EVENT
> TRIGGER/  FOREIGN TABLE/MATERIALIZED VIEW cases.
>=20
> Same bug was fixed for GRANT/REVOKE in ff0bcb248e6.
>=20
>=20
>=20
> Quick sum up:
>  Before:
>    COMMENT ON LARGE OBJECT <TAB> =E2=86=92 IS (invalid SQL)
>    SECURITY LABEL ON LARGE OBJECT <TAB> =E2=86=92 IS (invalid SQL)
>    SECURITY LABEL ON EVENT TRIGGER <TAB> =E2=86=92 IS (invalid SQL)
>    SECURITY LABEL ON FOREIGN TABLE <TAB> =E2=86=92 IS (invalid SQL)
>    SECURITY LABEL ON MATERIALIZED VIEW <TAB> =E2=86=92 IS (invalid =
SQL)
>=20
>  After:
>    COMMENT ON LARGE OBJECT <TAB> =E2=86=92 OID list (correct)
>    SECURITY LABEL ON LARGE OBJECT <TAB> =E2=86=92 OID list (correct)
>    SECURITY LABEL ON EVENT TRIGGER <TAB> =E2=86=92 trigger name list =
(correct)
>    SECURITY LABEL ON FOREIGN TABLE <TAB> =E2=86=92 foreign table list =
(correct)
>    SECURITY LABEL ON MATERIALIZED VIEW <TAB> =E2=86=92 matview list =
(correct)
>=20
>=20
>=20
> --=20
> Best regards,
> Kirill Reshke
> <v1-0001-psql-Fix-tab-completion-for-COMMENT-SECURITY-LABE.patch>

Do we also need to support SECURITY LABEL FOR provider ON LARGE OBJECT =
=E2=80=A6?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/