Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: get rid of Pointer type, mostly
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <2b929da1-dbb5-476f-a878-899b1e9e80f2@gmail.com>
Date: Mon, 8 Dec 2025 18:53:15 +0800
Cc: Robert Haas <robertmhaas@gmail.com>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Peter Eisentraut <peter@eisentraut.org>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <8B037F29-163E-4446-BA94-7553C9ECA0F1@gmail.com>
References: <4154950a-47ae-4223-bd01-1235cc50e933@eisentraut.org>
 <955002.1764000569@sss.pgh.pa.us>
 <CA+Tgmobo9ZMC0h1Z1Te9whf7q3LN7wUkzFLyuxfMZ4dyTNqKnw@mail.gmail.com>
 <957744.1764002037@sss.pgh.pa.us>
 <CA+TgmobhKe5WJybZ0EGQ85Qkxr-KLx4uW2_hFqt0iPbYq-af7Q@mail.gmail.com>
 <970261.1764008763@sss.pgh.pa.us>
 <CA+Tgmob==vi7MXZC9EhTGZ2YiuWkQuAGZm=H6M=9zPN2tp4s3A@mail.gmail.com>
 <987824.1764013105@sss.pgh.pa.us>
 <CA+TgmobFfk2y9jXPzzme-3qQCJC9LFnd2G9RBMCE9haVJkCQ+w@mail.gmail.com>
 <7c7e1e59-284b-49f6-a496-17dd4170f979@gmail.com>
 <2b929da1-dbb5-476f-a878-899b1e9e80f2@gmail.com>
To: David Geier <geidav.pg@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/8B037F29-163E-4446-BA94-7553C9ECA0F1%40gmail.com>
Precedence: bulk


> On Dec 8, 2025, at 18:25, David Geier <geidav.pg@gmail.com> wrote:
>=20
> Hi Peter,
>> I went with your proposal of GinExtraPointer. See attached patch. =
It's
>> based on the series of patches from Peter's initial mail. I've =
included
>> the removal of the Pointer typedef in the same patch.
>=20
> It seems to me that we reached agreement. Are you planning to still
> apply these patches?
>=20

Basically I am not against this patch, as =
756a43689324b473ee07549a6eb7a53a203df5ad has done similar changes.

What I want to understand is that why do we delete Pointer and add =
GinExtraPointer?

```
-/*
- * Pointer
- *		Variable holding address of any memory resident object.
- *		(obsolescent; use void * or char *)
- */
-typedef void *Pointer;
```

And
```
+typedef void *GinExtraPointer;
```

They both are underlying =E2=80=9Cvoid *=E2=80=9D. Are we expecting to =
improve code readability? More specific maybe?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/