Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFPvF-00555G-2y for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Apr 2026 05:14:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wFPvE-00Bnrj-1t for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Apr 2026 05:14:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFPvE-00BnrV-08 for pgsql-hackers@lists.postgresql.org; Wed, 22 Apr 2026 05:14:48 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wFPv9-00000002Q1y-15LF for pgsql-hackers@lists.postgresql.org; Wed, 22 Apr 2026 05:14:47 +0000 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-82cf636dac8so2131234b3a.3 for ; Tue, 21 Apr 2026 22:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776834881; x=1777439681; darn=lists.postgresql.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=HPrp/2NL0yHF8pZ+qG0qLYdqNru8IGL4vzjstrdlhMQ=; b=ng/dopD5QczCLjzF0A58piv4D6H2HPAs3xJdKrRLfXYuJrWTKGI+WcBsNgrsZYIzs2 FW977/Vc9+bsSrsUSsrkv8nKKVMOBRqVmTgO4bN/rRMNLcdc+8q7ubMlvmWQIrEf7Vlj NEB8Mk5ipfHNZeZdR1kAxvYRXfgGFG/xlNHnOxCzySDheqrEW4JBk469f3aaWjTQG5UI Fg4rq0lQCm1o9R/rG+KuaVucGlNW3IneBUTFYZejGCUzDy5xl8X3xUufToMwzeC9RhHd W71zkyAJfmMJ4eNuKV4gDBainssbm2zalAOXsPzPrDA8MQNrY3XjmxPH3YSHz+A/EfEr BaLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776834881; x=1777439681; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HPrp/2NL0yHF8pZ+qG0qLYdqNru8IGL4vzjstrdlhMQ=; b=Ix0oOiEDCafBz44gN58NmvfZ7EuGsu8ej0ykojG1ILsXNIuHfjrrL2isXkGrHw3Y9u ru+KPF2ODrtQeV9dvrBYiVHUthnmuAMyzkNsFwZVA/06R/kMgNTWrIdOy3s2h59+yOdg 8226U4G+rSeDKtyV/0dwWWJ6PmHc6yMSGhouFN/knII2EhhH13m5oINCTFiN+8JIDiCB Xfx8IemWRLeZwgo5bU9XCwo1Uwu8QsS0BCzs87App/2aCpKQZ2Ew2szVqY79ZCMPRyOS hv5nK7YwAMCLjCCI0HYW2REWD2fhNh2xjVfuq2qSYVe2jAgQqkJNnnT/oc8OZTJU6ZGK GJSg== X-Gm-Message-State: AOJu0YyPjkqYHf19em3XJMARuPWDiORsdypCQTRHdGnb5rXmGiSzvip1 s1dR5tsQzI/dq6oWCloO/A7Q8h1rQxCSKgMgvRuJMvbWjgIwyvPfloeK X-Gm-Gg: AeBDieurTZXStB49wWWOFlIZwMfMnzApOB9Im/o9rjWK86Jr4e8H8/5pBzLjQibYfgS KONVEjo/JIHSkXVgk6jWjjasY1T2E+dg54V8ksX3BnwRz6zST5AVQ6JojuzOL5uQRxn3x6+5ZWZ 5cYxzRWU3oCf9QqvxuigJ+nrLBX8XEOHs/CLtNO1oNldLBm6YnauG+NIMnk+oBtnqOcApdGBUSX pP+ZFHPleHWvmlq2maYEu6Kdozwhm0da6MaMiooN5tL/DvHRNzh7R50ctlqp6jdidPFy1gECrep 08NTrndcDa7r57KbNNsxAWy+dpGUH+e9IWGqYnBlMH32QmJGwrEY63ThUKbFEuphE/KJ1lmRMHS SciD6+0yy3XnBqOOb3bdxQFZzMQsN5/HJjQ9m8lurNWL0uk5ZByRGoHho6/d0gL+HqgbD4cDTC2 St1U5fsXav8O3k3HBkMnmQ2zZhtaES+Ro0wJGd8oEthQ== X-Received: by 2002:a05:6a00:a248:b0:82f:316:3208 with SMTP id d2e1a72fcca58-82f8c8fb879mr19901616b3a.29.1776834881120; Tue, 21 Apr 2026 22:14:41 -0700 (PDT) Received: from smtpclient.apple ([45.32.121.103]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ec003dcsm16221063b3a.52.2026.04.21.22.14.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Apr 2026 22:14:40 -0700 (PDT) From: Chao Li Message-Id: <8B830174-7794-411F-B936-37DDB509EC5D@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_CC8D6DC3-B6A1-478F-A73F-7E3087844CD8" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: Cleanup shadows variable warnings, round 1 Date: Wed, 22 Apr 2026 13:14:01 +0800 In-Reply-To: Cc: Postgres hackers , Peter Eisentraut , Peter Smith To: =?utf-8?Q?=C3=81lvaro_Herrera?= , David Rowley References: X-Mailer: Apple Mail (2.3864.400.21) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Apple-Mail=_CC8D6DC3-B6A1-478F-A73F-7E3087844CD8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 21, 2026, at 21:51, =C3=81lvaro Herrera = wrote: >=20 > On 2026-Apr-21, David Rowley wrote: >=20 >> On Tue, 21 Apr 2026 at 19:02, Chao Li wrote: >>> PFA v8 - rebased and fixed a few new occurrences. >>=20 >> Which of these are new to v19? Can you separate those ones out? IMO, >> we should commit at least those, as those won't cause any = backpatching >> pain. >=20 > I agree. The others are v20 material. >=20 Sounds reasonable. The attached new v1 patch fixes the v19-only shadow warnings. There are = not many. I strictly limited it to warnings newly introduced in v19, = without touching any pre-existing ones, even where an old occurrence is = very close to a new one. I intentionally left out one occurrence in ruleutils.c: ``` ruleutils.c:13100:23: warning: declaration shadows a local variable = [-Wshadow] 13100 | deparse_context = context =3D {0}; | = ^ ruleutils.c:12955:67: note: previous declaration is here 12955 | get_from_clause_item(Node *jtnode, Query *query, = deparse_context *context) | = ^ 1 warning generated. ``` I saw there is a thread [1] that will remove this deparse_context = context =3D {0};, so I skipped this one to avoid a potential conflict. Besides the patch file, I am also attaching three files for reference: * v18-shadow-warnings.txt - all shadow warnings from branch = REL_18_STABLE * v19-shadow-warnings-master.txt - all shadow warnings from current = master (9d3e094f12c) * v19-shadow-warnings-patched.txt - all shadow warnings after applying = this v1 patch Except for the one in ruleutils.c, v19-shadow-warnings-patched.txt is a = pure subset of v18-shadow-warnings.txt. You don't need to read these = large files; they are attached only for reference. I will recreate the previous patch set for v20. >=20 > Specifically about 0003 (v20 material for sure, as this is ancient > code), I don't like this patch very much. I wonder if it would be > possible to do away with the idea of using these codeFragment things > without introducing a performance issue here. Is that doable by = turning > these macros into static functions? >=20 Okay, I will remove 0003 from this patch set, and use a separate patch = to try converting the macros to static functions. [1] = http://postgr.es/m/CAHg+QDcLVa2iBnggkHxY4itZbXtDMfsYHEjnCUYe9hNbnxDi-w@mai= l.gmail.com Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/ --Apple-Mail=_CC8D6DC3-B6A1-478F-A73F-7E3087844CD8 Content-Disposition: attachment; filename=v18-shadow-warnings.txt Content-Type: text/plain; x-unix-mode=0644; name="v18-shadow-warnings.txt" Content-Transfer-Encoding: quoted-printable controldata_utils.c:52:29: warning: declaration shadows a variable in = the global scope [-Wshadow] 52 | get_controlfile(const char *DataDir, bool *crc_ok_p) | ^ ../../src/include/miscadmin.h:173:26: note: previous declaration is here 173 | extern PGDLLIMPORT char *DataDir; | ^ controldata_utils.c:189:32: warning: declaration shadows a variable in = the global scope [-Wshadow] 189 | update_controlfile(const char *DataDir, | ^ ../../src/include/miscadmin.h:173:26: note: previous declaration is here 173 | extern PGDLLIMPORT char *DataDir; | ^ 2 warnings generated. pgtz.c:234:22: warning: declaration shadows a variable in the global = scope [-Wshadow] 234 | pg_tzset(const char *tzname) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ pgtz.c:324:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 324 | char tzname[128]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 2 warnings generated. brin.c:697:16: warning: declaration shadows a local variable [-Wshadow] 697 | FmgrInfo *tmp; | ^ brin.c:589:11: note: previous declaration is here 589 | char *tmp PG_USED_FOR_ASSERTS_ONLY; | ^ 1 warning generated. gistbuild.c:1161:23: warning: declaration shadows a local variable = [-Wshadow] 1161 | GISTPageSplitInfo *splitinfo =3D = lfirst(lc); | ^ gistbuild.c:1061:11: note: previous declaration is here 1061 | List *splitinfo; | ^ 1 warning generated. xlogdesc.c:40:26: warning: declaration shadows a variable in the global = scope [-Wshadow] 40 | get_wal_level_string(int wal_level) | ^ ../../../../src/include/access/xlog.h:96:24: note: previous declaration = is here 96 | extern PGDLLIMPORT int wal_level; | ^ xlogdesc.c:165:9: warning: declaration shadows a variable in the global = scope [-Wshadow] 165 | int wal_level; | ^ ../../../../src/include/access/xlog.h:96:24: note: previous declaration = is here 96 | extern PGDLLIMPORT int wal_level; | ^ 2 warnings generated. xlogreader.c:107:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 107 | XLogReaderAllocate(int wal_segment_size, const char *waldir, | ^ ../../../../src/include/access/xlog.h:37:24: note: previous declaration = is here 37 | extern PGDLLIMPORT int wal_segment_size; | ^ 1 warning generated. xlogrecovery.c:1228:13: warning: declaration shadows a variable in the = global scope [-Wshadow] 1228 | bool *backupEndRequired, bool = *backupFromStandby) | ^ xlogrecovery.c:285:13: note: previous declaration is here 285 | static bool backupEndRequired =3D false; | ^ xlogrecovery.c:1928:33: warning: declaration shadows a variable in the = global scope [-Wshadow] 1928 | ApplyWalRecord(XLogReaderState *xlogreader, XLogRecord *record, = TimeLineID *replayTLI) | ^ xlogrecovery.c:190:25: note: previous declaration is here 190 | static XLogReaderState *xlogreader =3D NULL; | ^ xlogrecovery.c:3153:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 3153 | ReadRecord(XLogPrefetcher *xlogprefetcher, int emode, | ^ xlogrecovery.c:193:24: note: previous declaration is here 193 | static XLogPrefetcher *xlogprefetcher =3D NULL; | ^ xlogrecovery.c:3157:19: warning: declaration shadows a variable in the = global scope [-Wshadow] 3157 | XLogReaderState *xlogreader =3D = XLogPrefetcherGetReader(xlogprefetcher); | ^ xlogrecovery.c:190:25: note: previous declaration is here 190 | static XLogReaderState *xlogreader =3D NULL; | ^ xlogrecovery.c:3320:31: warning: declaration shadows a variable in the = global scope [-Wshadow] 3320 | XLogPageRead(XLogReaderState *xlogreader, XLogRecPtr = targetPagePtr, int reqLen, | ^ xlogrecovery.c:190:25: note: previous declaration is here 190 | static XLogReaderState *xlogreader =3D NULL; | ^ xlogrecovery.c:4093:38: warning: declaration shadows a variable in the = global scope [-Wshadow] 4093 | ReadCheckpointRecord(XLogPrefetcher *xlogprefetcher, XLogRecPtr = RecPtr, | ^ xlogrecovery.c:193:24: note: previous declaration is here 193 | static XLogPrefetcher *xlogprefetcher =3D NULL; | ^ 6 warnings generated. basebackup_incremental.c:599:14: warning: declaration shadows a local = variable [-Wshadow] 599 | unsigned i; | ^ basebackup_incremental.c:273:8: note: previous declaration is here 273 | int i; | ^ 1 warning generated. bootstrap.c:201:11: warning: declaration shadows a variable in the = global scope [-Wshadow] 201 | char *progname =3D argv[0]; | ^ ../../../src/include/postmaster/postmaster.h:88:32: note: previous = declaration is here 88 | extern PGDLLIMPORT const char *progname; | ^ 1 warning generated. objectaddress.c:2144:12: warning: declaration shadows a local variable = [-Wshadow] 2144 | bool *nulls; | ^ objectaddress.c:2123:8: note: previous declaration is here 2123 | bool nulls[3]; | ^ objectaddress.c:2161:12: warning: declaration shadows a local variable = [-Wshadow] 2161 | bool *nulls; | ^ objectaddress.c:2123:8: note: previous declaration is here 2123 | bool nulls[3]; | ^ objectaddress.c:2198:12: warning: declaration shadows a local variable = [-Wshadow] 2198 | bool *nulls; | ^ objectaddress.c:2123:8: note: previous declaration is here 2123 | bool nulls[3]; | ^ 3 warnings generated. pg_constraint.c:864:22: warning: declaration shadows a local variable = [-Wshadow] 864 | CookedConstraint *cooked; | ^ pg_constraint.c:834:47: note: previous declaration is here 834 | RelationGetNotNullConstraints(Oid relid, bool cooked, bool = include_noinh) | ^ 1 warning generated. parse_target.c:1613:13: warning: declaration shadows a local variable = [-Wshadow] 1613 | Index = levelsup; | ^ parse_target.c:1522:56: note: previous declaration is here 1522 | expandRecordVariable(ParseState *pstate, Var *var, int levelsup) | ^ parse_target.c:1671:13: warning: declaration shadows a local variable = [-Wshadow] 1671 | Index = levelsup; | ^ parse_target.c:1522:56: note: previous declaration is here 1522 | expandRecordVariable(ParseState *pstate, Var *var, int levelsup) | ^ 2 warnings generated. extension.c:1406:13: warning: declaration shadows a local variable = [-Wshadow] 1406 | char *schemaName =3D = get_namespace_name(reqschema); | ^ extension.c:1200:20: note: previous declaration is here 1200 | const char = *schemaName) | ^ 1 warning generated. schemacmds.c:208:12: warning: declaration shadows a local variable = [-Wshadow] 208 | Node *stmt =3D (Node *) = lfirst(parsetree_item); | ^ schemacmds.c:52:39: note: previous declaration is here 52 | CreateSchemaCommand(CreateSchemaStmt *stmt, const char = *queryString, | ^ 1 warning generated. statscmds.c:321:16: warning: declaration shadows a local variable = [-Wshadow] 321 | Bitmapset *attnums =3D NULL; | ^ statscmds.c:64:9: note: previous declaration is here 64 | int16 attnums[STATS_MAX_DIMENSIONS]; | ^ 1 warning generated. tablecmds.c:15721:20: warning: declaration shadows a local variable = [-Wshadow] 15721 | AlterTableCmd *cmd =3D = lfirst_node(AlterTableCmd, lcmd); | ^ tablecmds.c:15630:67: note: previous declaration is here 15630 | ATPostAlterTypeParse(Oid oldId, Oid oldRelId, Oid refRelId, = char *cmd, | = ^ tablecmds.c:15792:20: warning: declaration shadows a local variable = [-Wshadow] 15792 | AlterTableCmd *cmd =3D = makeNode(AlterTableCmd); | ^ tablecmds.c:15630:67: note: previous declaration is here 15630 | ATPostAlterTypeParse(Oid oldId, Oid oldRelId, Oid refRelId, = char *cmd, | = ^ 2 warnings generated. trigger.c:1169:13: warning: declaration shadows a local variable = [-Wshadow] 1169 | Node *qual; | ^ trigger.c:189:11: note: previous declaration is here 189 | char *qual; | ^ 1 warning generated. execExprInterp.c:474:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 474 | static const void *const dispatch_table[] =3D { | ^ execExprInterp.c:112:21: note: previous declaration is here 112 | static const void **dispatch_table =3D NULL; | ^ 1 warning generated. nodeAgg.c:4073:20: warning: declaration shadows a local variable = [-Wshadow] 4073 | AggStatePerPhase phase =3D = &aggstate->phases[phaseidx]; | ^ nodeAgg.c:3293:8: note: previous declaration is here 3293 | int phase; | ^ 1 warning generated. nodeValuesscan.c:144:16: warning: declaration shadows a local variable = [-Wshadow] 144 | ExprState *estate =3D (ExprState *) = lfirst(lc); | ^ nodeValuesscan.c:50:13: note: previous declaration is here 50 | EState *estate; | ^ 1 warning generated. be-secure-common.c:114:44: warning: declaration shadows a variable in = the global scope [-Wshadow] 114 | check_ssl_key_file_permissions(const char *ssl_key_file, bool = isServerStart) | ^ ../../../src/include/libpq/libpq.h:107:26: note: previous declaration is = here 107 | extern PGDLLIMPORT char *ssl_key_file; | ^ 1 warning generated. main.c:280:27: warning: declaration shadows a variable in the global = scope [-Wshadow] 280 | startup_hacks(const char *progname) | ^ main.c:44:13: note: previous declaration is here 44 | const char *progname; | ^ main.c:384:18: warning: declaration shadows a variable in the global = scope [-Wshadow] 384 | help(const char *progname) | ^ main.c:44:13: note: previous declaration is here 44 | const char *progname; | ^ main.c:443:24: warning: declaration shadows a variable in the global = scope [-Wshadow] 443 | check_root(const char *progname) | ^ main.c:44:13: note: previous declaration is here 44 | const char *progname; | ^ 3 warnings generated. equivclass.c:879:16: warning: declaration shadows a local variable = [-Wshadow] 879 | RelOptInfo *rel =3D = root->simple_rel_array[i]; | ^ equivclass.c:742:15: note: previous declaration is here 742 | Relids rel, | ^ 1 warning generated. createplan.c:1246:12: warning: declaration shadows a local variable = [-Wshadow] 1246 | Plan *plan; | ^ createplan.c:1218:13: note: previous declaration is here 1218 | Append *plan; | ^ createplan.c:2559:12: warning: declaration shadows a local variable = [-Wshadow] 2559 | Plan *plan; | ^ createplan.c:2549:13: note: previous declaration is here 2549 | Result *plan; | ^ 2 warnings generated. partdesc.c:229:16: warning: declaration shadows a local variable = [-Wshadow] 229 | ScanKeyData key[1]; | ^ partdesc.c:149:15: note: previous declaration is here 149 | PartitionKey key =3D RelationGetPartitionKey(rel); | ^ 1 warning generated. dependencies.c:1192:14: warning: declaration shadows a local variable = [-Wshadow] 1192 | OpExpr *expr =3D (OpExpr *) clause; | ^ dependencies.c:1168:87: note: previous declaration is here 1168 | dependency_is_compatible_expression(Node *clause, Index relid, = List *statlist, Node **expr) | = ^ dependencies.c:1226:22: warning: declaration shadows a local variable = [-Wshadow] 1226 | ScalarArrayOpExpr *expr =3D (ScalarArrayOpExpr = *) clause; | ^ dependencies.c:1168:87: note: previous declaration is here 1168 | dependency_is_compatible_expression(Node *clause, Index relid, = List *statlist, Node **expr) | = ^ 2 warnings generated. extended_stats.c:1053:10: warning: declaration shadows a local variable = [-Wshadow] 1053 | bool isnull; | ^ extended_stats.c:1005:11: note: previous declaration is here 1005 | bool *isnull; | ^ 1 warning generated. read_stream.c:963:12: warning: declaration shadows a local variable = [-Wshadow] 963 | void *per_buffer_data; | ^ read_stream.c:790:52: note: previous declaration is here 790 | read_stream_next_buffer(ReadStream *stream, void = **per_buffer_data) | ^ 1 warning generated. bufmgr.c:1210:11: warning: declaration shadows a local variable = [-Wshadow] 1210 | uint32 flags =3D = EB_SKIP_EXTENSION_LOCK; | ^ bufmgr.c:1200:8: note: previous declaration is here 1200 | int flags; | ^ 1 warning generated. date.c:572:9: warning: declaration shadows a variable in the global = scope [-Wshadow] 572 | int32 days =3D PG_GETARG_INT32(1); | ^ ../../../../src/include/utils/datetime.h:261:38: note: previous = declaration is here 261 | extern PGDLLIMPORT const char *const days[]; /* days (full = names) */ | ^ date.c:596:9: warning: declaration shadows a variable in the global = scope [-Wshadow] 596 | int32 days =3D PG_GETARG_INT32(1); | ^ ../../../../src/include/utils/datetime.h:261:38: note: previous = declaration is here 261 | extern PGDLLIMPORT const char *const days[]; /* days (full = names) */ | ^ date.c:3131:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 3131 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 3 warnings generated. datetime.c:645:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 645 | int days; | ^ datetime.c:84:19: note: previous declaration is here 84 | const char *const days[] =3D {"Sunday", "Monday", "Tuesday", = "Wednesday", | ^ datetime.c:3288:32: warning: declaration shadows a variable in the = global scope [-Wshadow] 3288 | DecodeTimezoneName(const char *tzname, int *offset, pg_tz **tz) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ datetime.c:3343:36: warning: declaration shadows a variable in the = global scope [-Wshadow] 3343 | DecodeTimezoneNameToTz(const char *tzname) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 3 warnings generated. formatting.c:3076:25: warning: declaration shadows a variable in the = global scope [-Wshadow] 3076 | const char *const = *months; | ^ ../../../../src/include/utils/datetime.h:259:38: note: previous = declaration is here 259 | extern PGDLLIMPORT const char *const months[]; /* months = (3-char | ^ 1 warning generated. jsonpath_exec.c:538:17: warning: declaration shadows a local variable = [-Wshadow] 538 | JsonValueList found =3D {0}; | ^ jsonpath_exec.c:527:11: note: previous declaration is here 527 | List *found; | ^ jsonpath_exec.c:1880:24: warning: declaration shadows a local variable = [-Wshadow] 1880 | JsonPathExecResult res =3D | ^ jsonpath_exec.c:1781:15: note: previous declaration is here 1781 | JsonPathBool res; | ^ jsonpath_exec.c:1891:24: warning: declaration shadows a local variable = [-Wshadow] 1891 | JsonPathExecResult res =3D | ^ jsonpath_exec.c:1781:15: note: previous declaration is here 1781 | JsonPathBool res; | ^ jsonpath_exec.c:2067:17: warning: declaration shadows a local variable = [-Wshadow] 2067 | JsonPathBool res =3D exec(pred, lval, = rval, param); | ^ jsonpath_exec.c:2029:21: note: previous declaration is here 2029 | JsonPathExecResult res; | ^ jsonpath_exec.c:4137:16: warning: declaration shadows a local variable = [-Wshadow] 4137 | ExprState *state =3D = lfirst_node(ExprState, exprlc); | ^ jsonpath_exec.c:4110:41: note: previous declaration is here 4110 | JsonTableInitOpaque(TableFuncScanState *state, int natts) | ^ 5 warnings generated. pg_upgrade_support.c:229:13: warning: declaration shadows a local = variable [-Wshadow] 229 | char *extName =3D = TextDatumGetCString(textDatums[i]); | ^ pg_upgrade_support.c:186:11: note: previous declaration is here 186 | text *extName; | ^ 1 warning generated. timestamp.c:493:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 493 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ timestamp.c:562:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 562 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ timestamp.c:1533:9: warning: declaration shadows a variable in the = global scope [-Wshadow] 1533 | int32 months =3D PG_GETARG_INT32(1); | ^ ../../../../src/include/utils/datetime.h:259:38: note: previous = declaration is here 259 | extern PGDLLIMPORT const char *const months[]; /* months = (3-char | ^ timestamp.c:1535:9: warning: declaration shadows a variable in the = global scope [-Wshadow] 1535 | int32 days =3D PG_GETARG_INT32(3); | ^ ../../../../src/include/utils/datetime.h:261:38: note: previous = declaration is here 261 | extern PGDLLIMPORT const char *const days[]; /* days (full = names) */ | ^ timestamp.c:2134:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 2134 | dt2local(Timestamp dt, int timezone) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:106:13: note: previous declaration is here 106 | extern long timezone __DARWIN_ALIAS(timezone); | ^ timestamp.c:2545:9: warning: declaration shadows a variable in the = global scope [-Wshadow] 2545 | int64 days; | ^ ../../../../src/include/utils/datetime.h:261:38: note: previous = declaration is here 261 | extern PGDLLIMPORT const char *const days[]; /* days (full = names) */ | ^ timestamp.c:6243:11: warning: declaration shadows a local variable = [-Wshadow] 6243 | int64 val; | ^ timestamp.c:6104:5: note: previous declaration is here 6104 | val; | ^ timestamp.c:6332:8: warning: declaration shadows a variable in the = global scope [-Wshadow] 6332 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ timestamp.c:6570:8: warning: declaration shadows a variable in the = global scope [-Wshadow] 6570 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 9 warnings generated. varlena.c:4438:13: warning: declaration shadows a local variable = [-Wshadow] 4438 | char *chunk_start; | ^ varlena.c:4373:15: note: previous declaration is here 4373 | const char *chunk_start =3D p; | ^ varlena.c:6067:14: warning: declaration shadows a local variable = [-Wshadow] 6067 | char *str; | ^ varlena.c:5902:17: note: previous declaration is here 5902 | StringInfoData str; | ^ 2 warnings generated. inval.c:481:2: warning: declaration shadows a local variable [-Wshadow] 481 | ProcessMessageSubGroup(group, RelCacheMsgs, | ^ inval.c:390:31: note: expanded from macro 'ProcessMessageSubGroup' 390 | SharedInvalidationMessage *msg =3D \ | ^ inval.c:474:28: note: previous declaration is here 474 | SharedInvalidationMessage msg; | ^ inval.c:511:2: warning: declaration shadows a local variable [-Wshadow] 511 | ProcessMessageSubGroup(group, RelCacheMsgs, | ^ inval.c:390:31: note: expanded from macro 'ProcessMessageSubGroup' 390 | SharedInvalidationMessage *msg =3D \ | ^ inval.c:508:28: note: previous declaration is here 508 | SharedInvalidationMessage msg; | ^ inval.c:540:2: warning: declaration shadows a local variable [-Wshadow] 540 | ProcessMessageSubGroup(group, RelCacheMsgs, | ^ inval.c:390:31: note: expanded from macro 'ProcessMessageSubGroup' 390 | SharedInvalidationMessage *msg =3D \ | ^ inval.c:536:28: note: previous declaration is here 536 | SharedInvalidationMessage msg; | ^ inval.c:1053:2: warning: declaration shadows a local variable [-Wshadow] 1053 | = ProcessMessageSubGroupMulti(&transInvalInfo->PriorCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1012:66: note: previous declaration is here 1012 | xactGetCommittedInvalidationMessages(SharedInvalidationMessage = **msgs, | = ^ inval.c:1059:2: warning: declaration shadows a local variable [-Wshadow] 1059 | = ProcessMessageSubGroupMulti(&transInvalInfo->ii.CurrentCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1012:66: note: previous declaration is here 1012 | xactGetCommittedInvalidationMessages(SharedInvalidationMessage = **msgs, | = ^ inval.c:1065:2: warning: declaration shadows a local variable [-Wshadow] 1065 | = ProcessMessageSubGroupMulti(&transInvalInfo->PriorCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1012:66: note: previous declaration is here 1012 | xactGetCommittedInvalidationMessages(SharedInvalidationMessage = **msgs, | = ^ inval.c:1071:2: warning: declaration shadows a local variable [-Wshadow] 1071 | = ProcessMessageSubGroupMulti(&transInvalInfo->ii.CurrentCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1012:66: note: previous declaration is here 1012 | xactGetCommittedInvalidationMessages(SharedInvalidationMessage = **msgs, | = ^ inval.c:1109:2: warning: declaration shadows a local variable [-Wshadow] 1109 | = ProcessMessageSubGroupMulti(&inplaceInvalInfo->CurrentCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1088:60: note: previous declaration is here 1088 | inplaceGetInvalidationMessages(SharedInvalidationMessage **msgs, | ^ inval.c:1115:2: warning: declaration shadows a local variable [-Wshadow] 1115 | = ProcessMessageSubGroupMulti(&inplaceInvalInfo->CurrentCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1088:60: note: previous declaration is here 1088 | inplaceGetInvalidationMessages(SharedInvalidationMessage **msgs, | ^ 9 warnings generated. freepage.c:1589:9: warning: declaration shadows a local variable = [-Wshadow] 1589 | Size result; | ^ freepage.c:1480:28: note: previous declaration is here 1480 | FreePageBtreeSearchResult result; | ^ 1 warning generated. fe-connect.c:3988:11: warning: declaration shadows a local variable = [-Wshadow] 3988 | int res; | ^ fe-connect.c:2912:14: note: previous declaration is here 2912 | PGresult *res; | ^ 1 warning generated. descriptor.c:75:46: warning: declaration shadows a variable in the = global scope [-Wshadow] 75 | add_descriptor(const char *name, const char *connection) | ^ ./preproc_extern.h:39:14: note: previous declaration is here 39 | extern char *connection; | ^ descriptor.c:94:47: warning: declaration shadows a variable in the = global scope [-Wshadow] 94 | drop_descriptor(const char *name, const char *connection) | ^ ./preproc_extern.h:39:14: note: previous declaration is here 39 | extern char *connection; | ^ descriptor.c:125:49: warning: declaration shadows a variable in the = global scope [-Wshadow] 125 | lookup_descriptor(const char *name, const char *connection) | ^ ./preproc_extern.h:39:14: note: previous declaration is here 39 | extern char *connection; | ^ 3 warnings generated. ecpg.c:35:18: warning: declaration shadows a variable in the global = scope [-Wshadow] 35 | help(const char *progname) | ^ ecpg.c:23:20: note: previous declaration is here 23 | static const char *progname; | ^ 1 warning generated. preproc.y:182:46: warning: declaration shadows a variable in the global = scope [-Wshadow] 182 | adjust_outofscope_cursor_vars(struct cursor *cur) | ^ ./preproc_extern.h:53:23: note: previous declaration is here 53 | extern struct cursor *cur; | ^ preproc.y:494:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 494 | int initializer, int array) | ^ preproc.y:41:12: note: previous declaration is here 41 | static int initializer =3D 0; | ^ 2 warnings generated. print.c:956:10: warning: declaration shadows a local variable [-Wshadow] 956 | int curr_nl_line; | ^ print.c:654:8: note: previous declaration is here 654 | *curr_nl_line, | ^ 1 warning generated. findtimezone.c:234:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 234 | score_timezone(const char *tzname, struct tztry *tt) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ findtimezone.c:320:36: warning: declaration shadows a variable in the = global scope [-Wshadow] 320 | perfect_timezone_match(const char *tzname, struct tztry *tt) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ findtimezone.c:1728:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 1728 | validate_zone(const char *tzname) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ findtimezone.c:1759:14: warning: declaration shadows a variable in the = global scope [-Wshadow] 1759 | const char *tzname; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 4 warnings generated. initdb.c:817:14: warning: declaration shadows a variable in the global = scope [-Wshadow] 817 | const char *username; | ^ initdb.c:153:14: note: previous declaration is here 153 | static char *username =3D NULL; | ^ initdb.c:1049:11: warning: declaration shadows a variable in the global = scope [-Wshadow] 1049 | FILE *conf_file; | ^ initdb.c:180:14: note: previous declaration is here 180 | static char *conf_file; | ^ initdb.c:2143:31: warning: declaration shadows a variable in the global = scope [-Wshadow] 2143 | locale_date_order(const char *locale) | ^ initdb.c:140:14: note: previous declaration is here 140 | static char *locale =3D NULL; | ^ initdb.c:2202:45: warning: declaration shadows a variable in the global = scope [-Wshadow] 2202 | check_locale_name(int category, const char *locale, char = **canonname) | ^ initdb.c:140:14: note: previous declaration is here 140 | static char *locale =3D NULL; | ^ initdb.c:2265:35: warning: declaration shadows a variable in the global = scope [-Wshadow] 2265 | check_locale_encoding(const char *locale, int user_enc) | ^ initdb.c:140:14: note: previous declaration is here 140 | static char *locale =3D NULL; | ^ initdb.c:2517:19: warning: declaration shadows a variable in the global = scope [-Wshadow] 2517 | usage(const char *progname) | ^ initdb.c:175:20: note: previous declaration is here 175 | static const char *progname; | ^ initdb.c:2597:33: warning: declaration shadows a variable in the global = scope [-Wshadow] 2597 | check_need_password(const char *authmethodlocal, const char = *authmethodhost) | ^ initdb.c:158:20: note: previous declaration is here 158 | static const char *authmethodlocal =3D NULL; | ^ initdb.c:2597:62: warning: declaration shadows a variable in the global = scope [-Wshadow] 2597 | check_need_password(const char *authmethodlocal, const char = *authmethodhost) | ^ initdb.c:157:20: note: previous declaration is here 157 | static const char *authmethodhost =3D NULL; | ^ 8 warnings generated. pg_amcheck.c:1183:18: warning: declaration shadows a variable in the = global scope [-Wshadow] 1183 | help(const char *progname) | ^ pg_amcheck.c:141:20: note: previous declaration is here 141 | static const char *progname =3D NULL; | ^ 1 warning generated. pg_basebackup.c:1015:25: warning: declaration shadows a variable in the = global scope [-Wshadow] 1015 | ReceiveCopyData(PGconn *conn, WriteDataCallback callback, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_basebackup.c:1285:30: warning: declaration shadows a variable in the = global scope [-Wshadow] 1285 | ReceiveArchiveStream(PGconn *conn, pg_compress_specification = *compress) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_basebackup.c:1600:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 1600 | ReceiveTarFile(PGconn *conn, char *archive_name, char = *spclocation, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_basebackup.c:1699:31: warning: declaration shadows a variable in the = global scope [-Wshadow] 1699 | ReceiveBackupManifest(PGconn *conn) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_basebackup.c:1736:39: warning: declaration shadows a variable in the = global scope [-Wshadow] 1736 | ReceiveBackupManifestInMemory(PGconn *conn, PQExpBuffer buf) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ 5 warnings generated. receivelog.c:336:22: warning: declaration shadows a variable in the = global scope [-Wshadow] 336 | sendFeedback(PGconn *conn, XLogRecPtr blockpos, TimestampTz now, = bool replyRequested) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:374:40: warning: declaration shadows a variable in the = global scope [-Wshadow] 374 | CheckServerVersionForStreaming(PGconn *conn) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:452:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 452 | ReceiveXlogStream(PGconn *conn, StreamCtl *stream) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:744:26: warning: declaration shadows a variable in the = global scope [-Wshadow] 744 | HandleCopyStream(PGconn *conn, StreamCtl *stream, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:877:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 877 | CopyStreamPoll(PGconn *conn, long timeout_ms, pgsocket = stop_socket) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:939:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 939 | CopyStreamReceive(PGconn *conn, long timeout, pgsocket = stop_socket, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:993:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 993 | ProcessKeepaliveMsg(PGconn *conn, StreamCtl *stream, char = *copybuf, int len, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:1047:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 1047 | ProcessXLogDataMsg(PGconn *conn, StreamCtl *stream, char = *copybuf, int len, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:1178:31: warning: declaration shadows a variable in the = global scope [-Wshadow] 1178 | HandleEndOfCopyStream(PGconn *conn, StreamCtl *stream, char = *copybuf, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:1217:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 1217 | CheckCopyStreamStop(PGconn *conn, StreamCtl *stream, XLogRecPtr = blockpos) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ 10 warnings generated. streamutil.c:276:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 276 | RetrieveWalSegSize(PGconn *conn) | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:355:35: warning: declaration shadows a variable in the = global scope [-Wshadow] 355 | RetrieveDataDirCreatePerm(PGconn *conn) | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:409:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 409 | RunIdentifySystem(PGconn *conn, char **sysid, TimeLineID = *starttli, | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:490:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 490 | GetSlotInformation(PGconn *conn, const char *slot_name, | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:584:31: warning: declaration shadows a variable in the = global scope [-Wshadow] 584 | CreateReplicationSlot(PGconn *conn, const char *slot_name, const = char *plugin, | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:697:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 697 | DropReplicationSlot(PGconn *conn, const char *slot_name) | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ 6 warnings generated. pg_createsubscriber.c:371:46: warning: declaration shadows a variable in = the global scope [-Wshadow] 371 | get_exec_path(const char *argv0, const char *progname) | ^ pg_createsubscriber.c:134:20: note: previous declaration is here 134 | static const char *progname; | ^ 1 warning generated. pg_receivewal.c:280:11: warning: declaration shadows a local variable = [-Wshadow] 280 | uint32 tli; | ^ pg_receivewal.c:268:28: note: previous declaration is here 268 | FindStreamingStart(uint32 *tli) | ^ 1 warning generated. pg_recvlogical.c:128:22: warning: declaration shadows a variable in the = global scope [-Wshadow] 128 | sendFeedback(PGconn *conn, TimestampTz now, bool force, bool = replyRequested) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_recvlogical.c:1047:30: warning: declaration shadows a variable in the = global scope [-Wshadow] 1047 | flushAndSendFeedback(PGconn *conn, TimestampTz *now) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_recvlogical.c:1064:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 1064 | prepareToTerminate(PGconn *conn, XLogRecPtr endpos, = StreamStopReason reason, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_recvlogical.c:1064:45: warning: declaration shadows a variable in the = global scope [-Wshadow] 1064 | prepareToTerminate(PGconn *conn, XLogRecPtr endpos, = StreamStopReason reason, | ^ pg_recvlogical.c:50:19: note: previous declaration is here 50 | static XLogRecPtr endpos =3D InvalidXLogRecPtr; | ^ 4 warnings generated. pg_controldata.c:73:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 73 | wal_level_str(WalLevel wal_level) | ^ ../../../src/include/access/xlog.h:96:24: note: previous declaration is = here 96 | extern PGDLLIMPORT int wal_level; | ^ 1 warning generated. pg_ctl.c:875:36: warning: declaration shadows a variable in the global = scope [-Wshadow] 875 | find_other_exec_or_die(const char *argv0, const char *target, = const char *versionstr) | ^ pg_ctl.c:93:14: note: previous declaration is here 93 | static char *argv0 =3D NULL; | ^ 1 warning generated. pg_dump.c:1264:18: warning: declaration shadows a variable in the global = scope [-Wshadow] 1264 | help(const char *progname) | ^ ./pg_backup_utils.h:28:20: note: previous declaration is here 28 | extern const char *progname; | ^ pg_dump.c:1612:13: warning: declaration shadows a variable in the global = scope [-Wshadow] 1612 | bool = strict_names) | ^ pg_dump.c:154:12: note: previous declaration is here 154 | static int strict_names =3D 0; | ^ pg_dump.c:1671:16: warning: declaration shadows a variable in the global = scope [-Wshadow] 1671 | bool = strict_names) | = ^ pg_dump.c:154:12: note: previous declaration is here 154 | static int strict_names =3D 0; | ^ pg_dump.c:1775:15: warning: declaration shadows a variable in the global = scope [-Wshadow] 1775 | bool = strict_names, bool with_child_tables) | ^ pg_dump.c:154:12: note: previous declaration is here 154 | static int strict_names =3D 0; | ^ pg_dump.c:10713:15: warning: declaration shadows a variable in the = global scope [-Wshadow] 10713 | CommentItem *comments; | ^ pg_dump.c:199:21: note: previous declaration is here 199 | static CommentItem *comments =3D NULL; | ^ pg_dump.c:10714:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 10714 | int ncomments; | ^ pg_dump.c:200:12: note: previous declaration is here 200 | static int ncomments =3D 0; | ^ pg_dump.c:11231:15: warning: declaration shadows a variable in the = global scope [-Wshadow] 11231 | CommentItem *comments; | ^ pg_dump.c:199:21: note: previous declaration is here 199 | static CommentItem *comments =3D NULL; | ^ pg_dump.c:11232:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 11232 | int ncomments; | ^ pg_dump.c:200:12: note: previous declaration is here 200 | static int ncomments =3D 0; | ^ pg_dump.c:12964:15: warning: declaration shadows a variable in the = global scope [-Wshadow] 12964 | CommentItem *comments; | ^ pg_dump.c:199:21: note: previous declaration is here 199 | static CommentItem *comments =3D NULL; | ^ pg_dump.c:12965:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 12965 | int ncomments; | ^ pg_dump.c:200:12: note: previous declaration is here 200 | static int ncomments =3D 0; | ^ 10 warnings generated. connectdb.c:42:63: warning: declaration shadows a variable in the global = scope [-Wshadow] 42 | trivalue prompt_password, bool = fail_on_error, const char *progname, | = ^ ./pg_backup_utils.h:28:20: note: previous declaration is here 28 | extern const char *progname; | ^ 1 warning generated. pg_restore.c:533:19: warning: declaration shadows a variable in the = global scope [-Wshadow] 533 | usage(const char *progname) | ^ ./pg_backup_utils.h:28:20: note: previous declaration is here 28 | extern const char *progname; | ^ 1 warning generated. pg_dumpall.c:1840:34: warning: declaration shadows a variable in the = global scope [-Wshadow] 1840 | read_dumpall_filters(const char *filename, SimpleStringList = *pattern) | ^ pg_dumpall.c:120:14: note: previous declaration is here 120 | static char *filename =3D NULL; | ^ 1 warning generated. pg_resetwal.c:743:25: warning: declaration shadows a variable in the = global scope [-Wshadow] 743 | PrintControlValues(bool guessed) | ^ pg_resetwal.c:64:13: note: previous declaration is here 64 | static bool guessed =3D false; /* T if we had to guess at any = values */ | ^ 1 warning generated. file_ops.c:189:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 189 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:208:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 208 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:231:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 231 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:245:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 245 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:259:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 259 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:273:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 273 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ 6 warnings generated. pg_rewind.c:92:19: warning: declaration shadows a variable in the global = scope [-Wshadow] 92 | usage(const char *progname) | ^ pg_rewind.c:63:20: note: previous declaration is here 63 | static const char *progname; | ^ pg_rewind.c:555:51: warning: declaration shadows a variable in the = global scope [-Wshadow] 555 | perform_rewind(filemap_t *filemap, rewind_source *source, | ^ pg_rewind.c:89:23: note: previous declaration is here 89 | static rewind_source *source; | ^ 2 warnings generated. xlogreader.c:107:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 107 | XLogReaderAllocate(int wal_segment_size, const char *waldir, | ^ ../../../src/include/access/xlog.h:37:24: note: previous declaration is = here 37 | extern PGDLLIMPORT int wal_segment_size; | ^ 1 warning generated. pg_test_fsync.c:628:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 628 | print_elapse(struct timeval start_t, struct timeval stop_t, int = ops) | ^ pg_test_fsync.c:74:23: note: previous declaration is here 74 | static struct timeval start_t, | ^ pg_test_fsync.c:628:53: warning: declaration shadows a variable in the = global scope [-Wshadow] 628 | print_elapse(struct timeval start_t, struct timeval stop_t, int = ops) | ^ pg_test_fsync.c:75:4: note: previous declaration is here 75 | stop_t; | ^ 2 warnings generated. xlogdesc.c:40:26: warning: declaration shadows a variable in the global = scope [-Wshadow] 40 | get_wal_level_string(int wal_level) | ^ ../../../src/include/access/xlog.h:96:24: note: previous declaration is = here 96 | extern PGDLLIMPORT int wal_level; | ^ xlogdesc.c:165:9: warning: declaration shadows a variable in the global = scope [-Wshadow] 165 | int wal_level; | ^ ../../../src/include/access/xlog.h:96:24: note: previous declaration is = here 96 | extern PGDLLIMPORT int wal_level; | ^ 2 warnings generated. xlogreader.c:107:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 107 | XLogReaderAllocate(int wal_segment_size, const char *waldir, | ^ ../../../src/include/access/xlog.h:37:24: note: previous declaration is = here 37 | extern PGDLLIMPORT int wal_segment_size; | ^ 1 warning generated. pgbench.c:4654:11: warning: declaration shadows a local variable = [-Wshadow] 4654 | int64 skipped =3D 0; | ^ pgbench.c:4622:25: note: previous declaration is here 4622 | StatsData *agg, bool skipped, double latency, double = lag) | ^ 1 warning generated. describe.c:1761:17: warning: declaration shadows a local variable = [-Wshadow] 1761 | printQueryOpt myopt =3D pset.popt; | ^ describe.c:1579:16: note: previous declaration is here 1579 | printTableOpt myopt =3D pset.popt.topt; | ^ describe.c:2287:13: warning: declaration shadows a local variable = [-Wshadow] 2287 | char *schemaname =3D = PQgetvalue(result, 0, 0); | ^ describe.c:1571:37: note: previous declaration is here 1571 | describeOneTableDetails(const char *schemaname, | ^ 2 warnings generated. prompt.c:193:24: warning: declaration shadows a local variable = [-Wshadow] 193 | PGpipelineStatus = status =3D PQpipelineStatus(pset.db); | = ^ prompt.c:68:27: note: previous declaration is here 68 | get_prompt(promptStatus_t status, ConditionalStack cstack) | ^ prompt.c:364:12: warning: declaration shadows a local variable = [-Wshadow] 364 | char *p =3D destination; | ^ prompt.c:74:14: note: previous declaration is here 74 | const char *p; | ^ 2 warnings generated. --Apple-Mail=_CC8D6DC3-B6A1-478F-A73F-7E3087844CD8 Content-Disposition: attachment; filename=v19-shadow-warnings-master.txt Content-Type: text/plain; x-unix-mode=0644; name="v19-shadow-warnings-master.txt" Content-Transfer-Encoding: quoted-printable controldata_utils.c:53:29: warning: declaration shadows a variable in = the global scope [-Wshadow] 53 | get_controlfile(const char *DataDir, bool *crc_ok_p) | ^ ../../src/include/miscadmin.h:175:26: note: previous declaration is here 175 | extern PGDLLIMPORT char *DataDir; | ^ controldata_utils.c:190:32: warning: declaration shadows a variable in = the global scope [-Wshadow] 190 | update_controlfile(const char *DataDir, | ^ ../../src/include/miscadmin.h:175:26: note: previous declaration is here 175 | extern PGDLLIMPORT char *DataDir; | ^ 2 warnings generated. pgtz.c:234:22: warning: declaration shadows a variable in the global = scope [-Wshadow] 234 | pg_tzset(const char *tzname) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ pgtz.c:324:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 324 | char tzname[128]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 2 warnings generated. brin.c:702:16: warning: declaration shadows a local variable [-Wshadow] 702 | FmgrInfo *tmp; | ^ brin.c:594:11: note: previous declaration is here 594 | char *tmp PG_USED_FOR_ASSERTS_ONLY; | ^ 1 warning generated. gistbuild.c:1161:23: warning: declaration shadows a local variable = [-Wshadow] 1161 | GISTPageSplitInfo *splitinfo =3D = lfirst(lc); | ^ gistbuild.c:1061:11: note: previous declaration is here 1061 | List *splitinfo; | ^ 1 warning generated. xlogdesc.c:41:26: warning: declaration shadows a variable in the global = scope [-Wshadow] 41 | get_wal_level_string(int wal_level) | ^ ../../../../src/include/access/xlog.h:98:24: note: previous declaration = is here 98 | extern PGDLLIMPORT int wal_level; | ^ 1 warning generated. xlogreader.c:108:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 108 | XLogReaderAllocate(int wal_segment_size, const char *waldir, | ^ ../../../../src/include/access/xlog.h:38:24: note: previous declaration = is here 38 | extern PGDLLIMPORT int wal_segment_size; | ^ 1 warning generated. xlogrecovery.c:1168:13: warning: declaration shadows a variable in the = global scope [-Wshadow] 1168 | bool *backupEndRequired, bool = *backupFromStandby) | ^ xlogrecovery.c:287:13: note: previous declaration is here 287 | static bool backupEndRequired =3D false; | ^ xlogrecovery.c:1880:33: warning: declaration shadows a variable in the = global scope [-Wshadow] 1880 | ApplyWalRecord(XLogReaderState *xlogreader, XLogRecord *record, = TimeLineID *replayTLI) | ^ xlogrecovery.c:192:25: note: previous declaration is here 192 | static XLogReaderState *xlogreader =3D NULL; | ^ xlogrecovery.c:3105:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 3105 | ReadRecord(XLogPrefetcher *xlogprefetcher, int emode, | ^ xlogrecovery.c:195:24: note: previous declaration is here 195 | static XLogPrefetcher *xlogprefetcher =3D NULL; | ^ xlogrecovery.c:3109:19: warning: declaration shadows a variable in the = global scope [-Wshadow] 3109 | XLogReaderState *xlogreader =3D = XLogPrefetcherGetReader(xlogprefetcher); | ^ xlogrecovery.c:192:25: note: previous declaration is here 192 | static XLogReaderState *xlogreader =3D NULL; | ^ xlogrecovery.c:3274:31: warning: declaration shadows a variable in the = global scope [-Wshadow] 3274 | XLogPageRead(XLogReaderState *xlogreader, XLogRecPtr = targetPagePtr, int reqLen, | ^ xlogrecovery.c:192:25: note: previous declaration is here 192 | static XLogReaderState *xlogreader =3D NULL; | ^ xlogrecovery.c:4057:38: warning: declaration shadows a variable in the = global scope [-Wshadow] 4057 | ReadCheckpointRecord(XLogPrefetcher *xlogprefetcher, XLogRecPtr = RecPtr, | ^ xlogrecovery.c:195:24: note: previous declaration is here 195 | static XLogPrefetcher *xlogprefetcher =3D NULL; | ^ 6 warnings generated. bootstrap.c:240:11: warning: declaration shadows a variable in the = global scope [-Wshadow] 240 | char *progname =3D argv[0]; | ^ ../../../src/include/postmaster/postmaster.h:88:32: note: previous = declaration is here 88 | extern PGDLLIMPORT const char *progname; | ^ 1 warning generated. objectaddress.c:2239:12: warning: declaration shadows a local variable = [-Wshadow] 2239 | bool *nulls; | ^ objectaddress.c:2218:8: note: previous declaration is here 2218 | bool nulls[3]; | ^ objectaddress.c:2256:12: warning: declaration shadows a local variable = [-Wshadow] 2256 | bool *nulls; | ^ objectaddress.c:2218:8: note: previous declaration is here 2218 | bool nulls[3]; | ^ objectaddress.c:2293:12: warning: declaration shadows a local variable = [-Wshadow] 2293 | bool *nulls; | ^ objectaddress.c:2218:8: note: previous declaration is here 2218 | bool nulls[3]; | ^ 3 warnings generated. pg_constraint.c:864:22: warning: declaration shadows a local variable = [-Wshadow] 864 | CookedConstraint *cooked; | ^ pg_constraint.c:834:47: note: previous declaration is here 834 | RelationGetNotNullConstraints(Oid relid, bool cooked, bool = include_noinh) | ^ 1 warning generated. extension.c:1456:13: warning: declaration shadows a local variable = [-Wshadow] 1456 | char *schemaName =3D = get_namespace_name(reqschema); | ^ extension.c:1250:20: note: previous declaration is here 1250 | const char = *schemaName) | ^ 1 warning generated. schemacmds.c:208:12: warning: declaration shadows a local variable = [-Wshadow] 208 | Node *stmt =3D (Node *) = lfirst(parsetree_item); | ^ schemacmds.c:52:59: note: previous declaration is here 52 | CreateSchemaCommand(ParseState *pstate, CreateSchemaStmt *stmt, | ^ 1 warning generated. statscmds.c:352:16: warning: declaration shadows a local variable = [-Wshadow] 352 | Bitmapset *attnums =3D NULL; | ^ statscmds.c:66:9: note: previous declaration is here 66 | int16 attnums[STATS_MAX_DIMENSIONS]; | ^ 1 warning generated. tablecmds.c:15965:20: warning: declaration shadows a local variable = [-Wshadow] 15965 | AlterTableCmd *cmd =3D = lfirst_node(AlterTableCmd, lcmd); | ^ tablecmds.c:15874:67: note: previous declaration is here 15874 | ATPostAlterTypeParse(Oid oldId, Oid oldRelId, Oid refRelId, = char *cmd, | = ^ tablecmds.c:16036:20: warning: declaration shadows a local variable = [-Wshadow] 16036 | AlterTableCmd *cmd =3D = makeNode(AlterTableCmd); | ^ tablecmds.c:15874:67: note: previous declaration is here 15874 | ATPostAlterTypeParse(Oid oldId, Oid oldRelId, Oid refRelId, = char *cmd, | = ^ tablecmds.c:22613:15: warning: declaration shadows a local variable = [-Wshadow] 22613 | Constraint *constr; | ^ tablecmds.c:22526:15: note: previous declaration is here 22526 | TupleConstr *constr; | ^ 3 warnings generated. trigger.c:1170:13: warning: declaration shadows a local variable = [-Wshadow] 1170 | Node *qual; | ^ trigger.c:190:11: note: previous declaration is here 190 | char *qual; | ^ 1 warning generated. wait.c:95:12: warning: declaration shadows a local variable [-Wshadow] 95 | double result; | ^ wait.c:44:14: note: previous declaration is here 44 | const char *result =3D ""; | ^ 1 warning generated. execExprInterp.c:476:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 476 | static const void *const dispatch_table[] =3D { | ^ execExprInterp.c:114:21: note: previous declaration is here 114 | static const void **dispatch_table =3D NULL; | ^ 1 warning generated. nodeAgg.c:4070:20: warning: declaration shadows a local variable = [-Wshadow] 4070 | AggStatePerPhase phase =3D = &aggstate->phases[phaseidx]; | ^ nodeAgg.c:3295:8: note: previous declaration is here 3295 | int phase; | ^ 1 warning generated. nodeValuesscan.c:144:16: warning: declaration shadows a local variable = [-Wshadow] 144 | ExprState *estate =3D (ExprState *) = lfirst(lc); | ^ nodeValuesscan.c:50:13: note: previous declaration is here 50 | EState *estate; | ^ 1 warning generated. be-secure-common.c:121:44: warning: declaration shadows a variable in = the global scope [-Wshadow] 121 | check_ssl_key_file_permissions(const char *ssl_key_file, bool = isServerStart) | ^ ../../../src/include/libpq/libpq.h:110:26: note: previous declaration is = here 110 | extern PGDLLIMPORT char *ssl_key_file; | ^ 1 warning generated. main.c:284:27: warning: declaration shadows a variable in the global = scope [-Wshadow] 284 | startup_hacks(const char *progname) | ^ main.c:44:13: note: previous declaration is here 44 | const char *progname; | ^ main.c:388:18: warning: declaration shadows a variable in the global = scope [-Wshadow] 388 | help(const char *progname) | ^ main.c:44:13: note: previous declaration is here 44 | const char *progname; | ^ main.c:447:24: warning: declaration shadows a variable in the global = scope [-Wshadow] 447 | check_root(const char *progname) | ^ main.c:44:13: note: previous declaration is here 44 | const char *progname; | ^ 3 warnings generated. equivclass.c:879:16: warning: declaration shadows a local variable = [-Wshadow] 879 | RelOptInfo *rel =3D = root->simple_rel_array[i]; | ^ equivclass.c:742:15: note: previous declaration is here 742 | Relids rel, | ^ 1 warning generated. createplan.c:1238:12: warning: declaration shadows a local variable = [-Wshadow] 1238 | Plan *plan; | ^ createplan.c:1210:13: note: previous declaration is here 1210 | Append *plan; | ^ createplan.c:2410:12: warning: declaration shadows a local variable = [-Wshadow] 2410 | Plan *plan; | ^ createplan.c:2400:13: note: previous declaration is here 2400 | Result *plan; | ^ 2 warnings generated. partdesc.c:229:16: warning: declaration shadows a local variable = [-Wshadow] 229 | ScanKeyData key[1]; | ^ partdesc.c:149:15: note: previous declaration is here 149 | PartitionKey key =3D RelationGetPartitionKey(rel); | ^ 1 warning generated. datachecksum_state.c:549:8: warning: declaration shadows a variable in = the global scope [-Wshadow] 549 | bool launcher_running; | ^ datachecksum_state.c:344:30: note: previous declaration is here 344 | static volatile sig_atomic_t launcher_running =3D false; | ^ 1 warning generated. dependencies.c:1176:14: warning: declaration shadows a local variable = [-Wshadow] 1176 | OpExpr *expr =3D (OpExpr *) clause; | ^ dependencies.c:1152:87: note: previous declaration is here 1152 | dependency_is_compatible_expression(Node *clause, Index relid, = List *statlist, Node **expr) | = ^ dependencies.c:1210:22: warning: declaration shadows a local variable = [-Wshadow] 1210 | ScalarArrayOpExpr *expr =3D (ScalarArrayOpExpr = *) clause; | ^ dependencies.c:1152:87: note: previous declaration is here 1152 | dependency_is_compatible_expression(Node *clause, Index relid, = List *statlist, Node **expr) | = ^ 2 warnings generated. extended_stats.c:1093:10: warning: declaration shadows a local variable = [-Wshadow] 1093 | bool isnull; | ^ extended_stats.c:1043:11: note: previous declaration is here 1043 | bool *isnull; | ^ 1 warning generated. read_stream.c:1297:12: warning: declaration shadows a local variable = [-Wshadow] 1297 | void *per_buffer_data; | ^ read_stream.c:1020:52: note: previous declaration is here 1020 | read_stream_next_buffer(ReadStream *stream, void = **per_buffer_data) | ^ 1 warning generated. bufmgr.c:1302:11: warning: declaration shadows a local variable = [-Wshadow] 1302 | uint32 flags =3D = EB_SKIP_EXTENSION_LOCK; | ^ bufmgr.c:1292:8: note: previous declaration is here 1292 | int flags; | ^ 1 warning generated. date.c:565:9: warning: declaration shadows a variable in the global = scope [-Wshadow] 565 | int32 days =3D PG_GETARG_INT32(1); | ^ ../../../../src/include/utils/datetime.h:261:38: note: previous = declaration is here 261 | extern PGDLLIMPORT const char *const days[]; /* days (full = names) */ | ^ date.c:589:9: warning: declaration shadows a variable in the global = scope [-Wshadow] 589 | int32 days =3D PG_GETARG_INT32(1); | ^ ../../../../src/include/utils/datetime.h:261:38: note: previous = declaration is here 261 | extern PGDLLIMPORT const char *const days[]; /* days (full = names) */ | ^ date.c:3155:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 3155 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 3 warnings generated. datetime.c:646:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 646 | int days; | ^ datetime.c:85:19: note: previous declaration is here 85 | const char *const days[] =3D {"Sunday", "Monday", "Tuesday", = "Wednesday", | ^ 1 warning generated. formatting.c:3037:25: warning: declaration shadows a variable in the = global scope [-Wshadow] 3037 | const char *const = *months; | ^ ../../../../src/include/utils/datetime.h:259:38: note: previous = declaration is here 259 | extern PGDLLIMPORT const char *const months[]; /* months = (3-char | ^ 1 warning generated. jsonpath_exec.c:1928:24: warning: declaration shadows a local variable = [-Wshadow] 1928 | JsonPathExecResult res; | ^ jsonpath_exec.c:1829:15: note: previous declaration is here 1829 | JsonPathBool res; | ^ jsonpath_exec.c:1946:24: warning: declaration shadows a local variable = [-Wshadow] 1946 | JsonPathExecResult res =3D | ^ jsonpath_exec.c:1829:15: note: previous declaration is here 1829 | JsonPathBool res; | ^ jsonpath_exec.c:2131:17: warning: declaration shadows a local variable = [-Wshadow] 2131 | JsonPathBool res =3D exec(pred, lval, = rval, param); | ^ jsonpath_exec.c:2084:21: note: previous declaration is here 2084 | JsonPathExecResult res; | ^ jsonpath_exec.c:4447:16: warning: declaration shadows a local variable = [-Wshadow] 4447 | ExprState *state =3D = lfirst_node(ExprState, exprlc); | ^ jsonpath_exec.c:4420:41: note: previous declaration is here 4420 | JsonTableInitOpaque(TableFuncScanState *state, int natts) | ^ 4 warnings generated. pg_upgrade_support.c:230:13: warning: declaration shadows a local = variable [-Wshadow] 230 | char *extName =3D = TextDatumGetCString(textDatums[i]); | ^ pg_upgrade_support.c:187:11: note: previous declaration is here 187 | text *extName; | ^ 1 warning generated. ruleutils.c:13100:23: warning: declaration shadows a local variable = [-Wshadow] 13100 | deparse_context = context =3D {0}; | = ^ ruleutils.c:12955:67: note: previous declaration is here 12955 | get_from_clause_item(Node *jtnode, Query *query, = deparse_context *context) | = ^ 1 warning generated. timestamp.c:485:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 485 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ timestamp.c:554:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 554 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ timestamp.c:1527:9: warning: declaration shadows a variable in the = global scope [-Wshadow] 1527 | int32 months =3D PG_GETARG_INT32(1); | ^ ../../../../src/include/utils/datetime.h:259:38: note: previous = declaration is here 259 | extern PGDLLIMPORT const char *const months[]; /* months = (3-char | ^ timestamp.c:1529:9: warning: declaration shadows a variable in the = global scope [-Wshadow] 1529 | int32 days =3D PG_GETARG_INT32(3); | ^ ../../../../src/include/utils/datetime.h:261:38: note: previous = declaration is here 261 | extern PGDLLIMPORT const char *const days[]; /* days (full = names) */ | ^ timestamp.c:2128:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 2128 | dt2local(Timestamp dt, int timezone) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:106:13: note: previous declaration is here 106 | extern long timezone __DARWIN_ALIAS(timezone); | ^ timestamp.c:2521:9: warning: declaration shadows a variable in the = global scope [-Wshadow] 2521 | int64 days; | ^ ../../../../src/include/utils/datetime.h:261:38: note: previous = declaration is here 261 | extern PGDLLIMPORT const char *const days[]; /* days (full = names) */ | ^ timestamp.c:6219:11: warning: declaration shadows a local variable = [-Wshadow] 6219 | int64 val; | ^ timestamp.c:6080:5: note: previous declaration is here 6080 | val; | ^ timestamp.c:6308:8: warning: declaration shadows a variable in the = global scope [-Wshadow] 6308 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ timestamp.c:6573:8: warning: declaration shadows a variable in the = global scope [-Wshadow] 6573 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 9 warnings generated. varlena.c:3318:13: warning: declaration shadows a local variable = [-Wshadow] 3318 | char *chunk_start; | ^ varlena.c:3253:15: note: previous declaration is here 3253 | const char *chunk_start =3D p; | ^ varlena.c:4949:14: warning: declaration shadows a local variable = [-Wshadow] 4949 | char *str; | ^ varlena.c:4784:17: note: previous declaration is here 4784 | StringInfoData str; | ^ 2 warnings generated. inval.c:481:2: warning: declaration shadows a local variable [-Wshadow] 481 | ProcessMessageSubGroup(group, RelCacheMsgs, | ^ inval.c:390:31: note: expanded from macro 'ProcessMessageSubGroup' 390 | SharedInvalidationMessage *msg =3D \ | ^ inval.c:474:28: note: previous declaration is here 474 | SharedInvalidationMessage msg; | ^ inval.c:511:2: warning: declaration shadows a local variable [-Wshadow] 511 | ProcessMessageSubGroup(group, RelCacheMsgs, | ^ inval.c:390:31: note: expanded from macro 'ProcessMessageSubGroup' 390 | SharedInvalidationMessage *msg =3D \ | ^ inval.c:508:28: note: previous declaration is here 508 | SharedInvalidationMessage msg; | ^ inval.c:540:2: warning: declaration shadows a local variable [-Wshadow] 540 | ProcessMessageSubGroup(group, RelCacheMsgs, | ^ inval.c:390:31: note: expanded from macro 'ProcessMessageSubGroup' 390 | SharedInvalidationMessage *msg =3D \ | ^ inval.c:536:28: note: previous declaration is here 536 | SharedInvalidationMessage msg; | ^ inval.c:1053:2: warning: declaration shadows a local variable [-Wshadow] 1053 | = ProcessMessageSubGroupMulti(&transInvalInfo->PriorCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1012:66: note: previous declaration is here 1012 | xactGetCommittedInvalidationMessages(SharedInvalidationMessage = **msgs, | = ^ inval.c:1059:2: warning: declaration shadows a local variable [-Wshadow] 1059 | = ProcessMessageSubGroupMulti(&transInvalInfo->ii.CurrentCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1012:66: note: previous declaration is here 1012 | xactGetCommittedInvalidationMessages(SharedInvalidationMessage = **msgs, | = ^ inval.c:1065:2: warning: declaration shadows a local variable [-Wshadow] 1065 | = ProcessMessageSubGroupMulti(&transInvalInfo->PriorCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1012:66: note: previous declaration is here 1012 | xactGetCommittedInvalidationMessages(SharedInvalidationMessage = **msgs, | = ^ inval.c:1071:2: warning: declaration shadows a local variable [-Wshadow] 1071 | = ProcessMessageSubGroupMulti(&transInvalInfo->ii.CurrentCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1012:66: note: previous declaration is here 1012 | xactGetCommittedInvalidationMessages(SharedInvalidationMessage = **msgs, | = ^ inval.c:1109:2: warning: declaration shadows a local variable [-Wshadow] 1109 | = ProcessMessageSubGroupMulti(&inplaceInvalInfo->CurrentCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1088:60: note: previous declaration is here 1088 | inplaceGetInvalidationMessages(SharedInvalidationMessage **msgs, | ^ inval.c:1115:2: warning: declaration shadows a local variable [-Wshadow] 1115 | = ProcessMessageSubGroupMulti(&inplaceInvalInfo->CurrentCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1088:60: note: previous declaration is here 1088 | inplaceGetInvalidationMessages(SharedInvalidationMessage **msgs, | ^ 9 warnings generated. freepage.c:1589:9: warning: declaration shadows a local variable = [-Wshadow] 1589 | Size result; | ^ freepage.c:1480:28: note: previous declaration is here 1480 | FreePageBtreeSearchResult result; | ^ 1 warning generated. fe-connect.c:4005:11: warning: declaration shadows a local variable = [-Wshadow] 4005 | int res; | ^ fe-connect.c:2929:14: note: previous declaration is here 2929 | PGresult *res; | ^ 1 warning generated. descriptor.c:75:46: warning: declaration shadows a variable in the = global scope [-Wshadow] 75 | add_descriptor(const char *name, const char *connection) | ^ ./preproc_extern.h:39:14: note: previous declaration is here 39 | extern char *connection; | ^ descriptor.c:94:47: warning: declaration shadows a variable in the = global scope [-Wshadow] 94 | drop_descriptor(const char *name, const char *connection) | ^ ./preproc_extern.h:39:14: note: previous declaration is here 39 | extern char *connection; | ^ descriptor.c:125:49: warning: declaration shadows a variable in the = global scope [-Wshadow] 125 | lookup_descriptor(const char *name, const char *connection) | ^ ./preproc_extern.h:39:14: note: previous declaration is here 39 | extern char *connection; | ^ 3 warnings generated. ecpg.c:35:18: warning: declaration shadows a variable in the global = scope [-Wshadow] 35 | help(const char *progname) | ^ ecpg.c:23:20: note: previous declaration is here 23 | static const char *progname; | ^ 1 warning generated. preproc.y:182:46: warning: declaration shadows a variable in the global = scope [-Wshadow] 182 | adjust_outofscope_cursor_vars(struct cursor *cur) | ^ ./preproc_extern.h:53:23: note: previous declaration is here 53 | extern struct cursor *cur; | ^ preproc.y:494:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 494 | int initializer, int array) | ^ preproc.y:41:12: note: previous declaration is here 41 | static int initializer =3D 0; | ^ 2 warnings generated. print.c:936:10: warning: declaration shadows a local variable [-Wshadow] 936 | int curr_nl_line; | ^ print.c:670:8: note: previous declaration is here 670 | *curr_nl_line, | ^ 1 warning generated. findtimezone.c:234:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 234 | score_timezone(const char *tzname, struct tztry *tt) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ findtimezone.c:320:36: warning: declaration shadows a variable in the = global scope [-Wshadow] 320 | perfect_timezone_match(const char *tzname, struct tztry *tt) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ findtimezone.c:1728:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 1728 | validate_zone(const char *tzname) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ findtimezone.c:1759:14: warning: declaration shadows a variable in the = global scope [-Wshadow] 1759 | const char *tzname; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 4 warnings generated. initdb.c:831:14: warning: declaration shadows a variable in the global = scope [-Wshadow] 831 | const char *username; | ^ initdb.c:153:14: note: previous declaration is here 153 | static char *username =3D NULL; | ^ initdb.c:1065:11: warning: declaration shadows a variable in the global = scope [-Wshadow] 1065 | FILE *conf_file; | ^ initdb.c:181:14: note: previous declaration is here 181 | static char *conf_file; | ^ initdb.c:2166:31: warning: declaration shadows a variable in the global = scope [-Wshadow] 2166 | locale_date_order(const char *locale) | ^ initdb.c:140:14: note: previous declaration is here 140 | static char *locale =3D NULL; | ^ initdb.c:2225:45: warning: declaration shadows a variable in the global = scope [-Wshadow] 2225 | check_locale_name(int category, const char *locale, char = **canonname) | ^ initdb.c:140:14: note: previous declaration is here 140 | static char *locale =3D NULL; | ^ initdb.c:2288:35: warning: declaration shadows a variable in the global = scope [-Wshadow] 2288 | check_locale_encoding(const char *locale, int user_enc) | ^ initdb.c:140:14: note: previous declaration is here 140 | static char *locale =3D NULL; | ^ initdb.c:2540:19: warning: declaration shadows a variable in the global = scope [-Wshadow] 2540 | usage(const char *progname) | ^ initdb.c:175:20: note: previous declaration is here 175 | static const char *progname; | ^ initdb.c:2620:33: warning: declaration shadows a variable in the global = scope [-Wshadow] 2620 | check_need_password(const char *authmethodlocal, const char = *authmethodhost) | ^ initdb.c:158:20: note: previous declaration is here 158 | static const char *authmethodlocal =3D NULL; | ^ initdb.c:2620:62: warning: declaration shadows a variable in the global = scope [-Wshadow] 2620 | check_need_password(const char *authmethodlocal, const char = *authmethodhost) | ^ initdb.c:157:20: note: previous declaration is here 157 | static const char *authmethodhost =3D NULL; | ^ 8 warnings generated. pg_amcheck.c:1183:18: warning: declaration shadows a variable in the = global scope [-Wshadow] 1183 | help(const char *progname) | ^ pg_amcheck.c:141:20: note: previous declaration is here 141 | static const char *progname =3D NULL; | ^ 1 warning generated. pg_basebackup.c:1016:25: warning: declaration shadows a variable in the = global scope [-Wshadow] 1016 | ReceiveCopyData(PGconn *conn, WriteDataCallback callback, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_basebackup.c:1272:30: warning: declaration shadows a variable in the = global scope [-Wshadow] 1272 | ReceiveArchiveStream(PGconn *conn, pg_compress_specification = *compress) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_basebackup.c:1587:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 1587 | ReceiveTarFile(PGconn *conn, char *archive_name, char = *spclocation, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_basebackup.c:1686:31: warning: declaration shadows a variable in the = global scope [-Wshadow] 1686 | ReceiveBackupManifest(PGconn *conn) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_basebackup.c:1723:39: warning: declaration shadows a variable in the = global scope [-Wshadow] 1723 | ReceiveBackupManifestInMemory(PGconn *conn, PQExpBuffer buf) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ 5 warnings generated. receivelog.c:337:22: warning: declaration shadows a variable in the = global scope [-Wshadow] 337 | sendFeedback(PGconn *conn, XLogRecPtr blockpos, TimestampTz now, = bool replyRequested) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:375:40: warning: declaration shadows a variable in the = global scope [-Wshadow] 375 | CheckServerVersionForStreaming(PGconn *conn) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:453:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 453 | ReceiveXlogStream(PGconn *conn, StreamCtl *stream) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:745:26: warning: declaration shadows a variable in the = global scope [-Wshadow] 745 | HandleCopyStream(PGconn *conn, StreamCtl *stream, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:878:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 878 | CopyStreamPoll(PGconn *conn, long timeout_ms, pgsocket = stop_socket) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:940:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 940 | CopyStreamReceive(PGconn *conn, long timeout, pgsocket = stop_socket, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:994:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 994 | ProcessKeepaliveMsg(PGconn *conn, StreamCtl *stream, char = *copybuf, int len, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:1048:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 1048 | ProcessWALDataMsg(PGconn *conn, StreamCtl *stream, char = *copybuf, int len, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:1179:31: warning: declaration shadows a variable in the = global scope [-Wshadow] 1179 | HandleEndOfCopyStream(PGconn *conn, StreamCtl *stream, char = *copybuf, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:1218:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 1218 | CheckCopyStreamStop(PGconn *conn, StreamCtl *stream, XLogRecPtr = blockpos) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ 10 warnings generated. streamutil.c:276:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 276 | RetrieveWalSegSize(PGconn *conn) | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:355:35: warning: declaration shadows a variable in the = global scope [-Wshadow] 355 | RetrieveDataDirCreatePerm(PGconn *conn) | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:409:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 409 | RunIdentifySystem(PGconn *conn, char **sysid, TimeLineID = *starttli, | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:490:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 490 | GetSlotInformation(PGconn *conn, const char *slot_name, | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:584:31: warning: declaration shadows a variable in the = global scope [-Wshadow] 584 | CreateReplicationSlot(PGconn *conn, const char *slot_name, const = char *plugin, | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:697:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 697 | DropReplicationSlot(PGconn *conn, const char *slot_name) | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ 6 warnings generated. pg_createsubscriber.c:414:46: warning: declaration shadows a variable in = the global scope [-Wshadow] 414 | get_exec_path(const char *argv0, const char *progname) | ^ pg_createsubscriber.c:157:20: note: previous declaration is here 157 | static const char *progname; | ^ 1 warning generated. pg_receivewal.c:280:11: warning: declaration shadows a local variable = [-Wshadow] 280 | uint32 tli; | ^ pg_receivewal.c:268:28: note: previous declaration is here 268 | FindStreamingStart(uint32 *tli) | ^ 1 warning generated. pg_recvlogical.c:129:22: warning: declaration shadows a variable in the = global scope [-Wshadow] 129 | sendFeedback(PGconn *conn, TimestampTz now, bool force, bool = replyRequested) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_recvlogical.c:1055:30: warning: declaration shadows a variable in the = global scope [-Wshadow] 1055 | flushAndSendFeedback(PGconn *conn, TimestampTz *now) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_recvlogical.c:1071:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 1071 | prepareToTerminate(PGconn *conn, XLogRecPtr endpos, = StreamStopReason reason, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_recvlogical.c:1071:45: warning: declaration shadows a variable in the = global scope [-Wshadow] 1071 | prepareToTerminate(PGconn *conn, XLogRecPtr endpos, = StreamStopReason reason, | ^ pg_recvlogical.c:51:19: note: previous declaration is here 51 | static XLogRecPtr endpos =3D InvalidXLogRecPtr; | ^ 4 warnings generated. pg_controldata.c:73:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 73 | wal_level_str(WalLevel wal_level) | ^ ../../../src/include/access/xlog.h:98:24: note: previous declaration is = here 98 | extern PGDLLIMPORT int wal_level; | ^ 1 warning generated. pg_ctl.c:876:36: warning: declaration shadows a variable in the global = scope [-Wshadow] 876 | find_other_exec_or_die(const char *argv0, const char *target, = const char *versionstr) | ^ pg_ctl.c:94:14: note: previous declaration is here 94 | static char *argv0 =3D NULL; | ^ 1 warning generated. pg_dump.c:1291:18: warning: declaration shadows a variable in the global = scope [-Wshadow] 1291 | help(const char *progname) | ^ ./pg_backup_utils.h:28:20: note: previous declaration is here 28 | extern const char *progname; | ^ pg_dump.c:1650:13: warning: declaration shadows a variable in the global = scope [-Wshadow] 1650 | bool = strict_names) | ^ pg_dump.c:157:12: note: previous declaration is here 157 | static int strict_names =3D 0; | ^ pg_dump.c:1709:16: warning: declaration shadows a variable in the global = scope [-Wshadow] 1709 | bool = strict_names) | = ^ pg_dump.c:157:12: note: previous declaration is here 157 | static int strict_names =3D 0; | ^ pg_dump.c:1813:15: warning: declaration shadows a variable in the global = scope [-Wshadow] 1813 | bool = strict_names, bool with_child_tables) | ^ pg_dump.c:157:12: note: previous declaration is here 157 | static int strict_names =3D 0; | ^ pg_dump.c:11005:15: warning: declaration shadows a variable in the = global scope [-Wshadow] 11005 | CommentItem *comments; | ^ pg_dump.c:202:21: note: previous declaration is here 202 | static CommentItem *comments =3D NULL; | ^ pg_dump.c:11006:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 11006 | int ncomments; | ^ pg_dump.c:203:12: note: previous declaration is here 203 | static int ncomments =3D 0; | ^ pg_dump.c:11563:15: warning: declaration shadows a variable in the = global scope [-Wshadow] 11563 | CommentItem *comments; | ^ pg_dump.c:202:21: note: previous declaration is here 202 | static CommentItem *comments =3D NULL; | ^ pg_dump.c:11564:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 11564 | int ncomments; | ^ pg_dump.c:203:12: note: previous declaration is here 203 | static int ncomments =3D 0; | ^ pg_dump.c:13292:15: warning: declaration shadows a variable in the = global scope [-Wshadow] 13292 | CommentItem *comments; | ^ pg_dump.c:202:21: note: previous declaration is here 202 | static CommentItem *comments =3D NULL; | ^ pg_dump.c:13293:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 13293 | int ncomments; | ^ pg_dump.c:203:12: note: previous declaration is here 203 | static int ncomments =3D 0; | ^ 10 warnings generated. connectdb.c:42:63: warning: declaration shadows a variable in the global = scope [-Wshadow] 42 | trivalue prompt_password, bool = fail_on_error, const char *progname, | = ^ ./pg_backup_utils.h:28:20: note: previous declaration is here 28 | extern const char *progname; | ^ 1 warning generated. pg_restore.c:746:19: warning: declaration shadows a variable in the = global scope [-Wshadow] 746 | usage(const char *progname) | ^ ./pg_backup_utils.h:28:20: note: previous declaration is here 28 | extern const char *progname; | ^ 1 warning generated. pg_dumpall.c:2272:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 2272 | = SimpleStringList *database_exclude_names) | = ^ pg_dumpall.c:136:25: note: previous declaration is here 136 | static SimpleStringList database_exclude_names =3D {NULL, NULL}; | ^ pg_dumpall.c:2352:34: warning: declaration shadows a variable in the = global scope [-Wshadow] 2352 | read_dumpall_filters(const char *filename, SimpleStringList = *pattern) | ^ pg_dumpall.c:133:14: note: previous declaration is here 133 | static char *filename =3D NULL; | ^ pg_dumpall.c:2409:16: warning: declaration shadows a variable in the = global scope [-Wshadow] 2409 | ArchiveFormat archDumpFormat; | ^ pg_dumpall.c:141:22: note: previous declaration is here 141 | static ArchiveFormat archDumpFormat =3D archNull; | ^ 3 warnings generated. pg_resetwal.c:754:25: warning: declaration shadows a variable in the = global scope [-Wshadow] 754 | PrintControlValues(bool guessed) | ^ pg_resetwal.c:65:13: note: previous declaration is here 65 | static bool guessed =3D false; /* T if we had to guess at any = values */ | ^ 1 warning generated. file_ops.c:189:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 189 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:208:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 208 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:231:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 231 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:245:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 245 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:259:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 259 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:273:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 273 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ 6 warnings generated. pg_rewind.c:92:19: warning: declaration shadows a variable in the global = scope [-Wshadow] 92 | usage(const char *progname) | ^ pg_rewind.c:63:20: note: previous declaration is here 63 | static const char *progname; | ^ pg_rewind.c:564:51: warning: declaration shadows a variable in the = global scope [-Wshadow] 564 | perform_rewind(filemap_t *filemap, rewind_source *source, | ^ pg_rewind.c:89:23: note: previous declaration is here 89 | static rewind_source *source; | ^ 2 warnings generated. xlogreader.c:108:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 108 | XLogReaderAllocate(int wal_segment_size, const char *waldir, | ^ ../../../src/include/access/xlog.h:38:24: note: previous declaration is = here 38 | extern PGDLLIMPORT int wal_segment_size; | ^ 1 warning generated. pg_test_fsync.c:625:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 625 | print_elapse(struct timeval start_t, struct timeval stop_t, int = ops) | ^ pg_test_fsync.c:73:23: note: previous declaration is here 73 | static struct timeval start_t, | ^ pg_test_fsync.c:625:53: warning: declaration shadows a variable in the = global scope [-Wshadow] 625 | print_elapse(struct timeval start_t, struct timeval stop_t, int = ops) | ^ pg_test_fsync.c:74:4: note: previous declaration is here 74 | stop_t; | ^ 2 warnings generated. xlogdesc.c:41:26: warning: declaration shadows a variable in the global = scope [-Wshadow] 41 | get_wal_level_string(int wal_level) | ^ ../../../src/include/access/xlog.h:98:24: note: previous declaration is = here 98 | extern PGDLLIMPORT int wal_level; | ^ 1 warning generated. xlogreader.c:108:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 108 | XLogReaderAllocate(int wal_segment_size, const char *waldir, | ^ ../../../src/include/access/xlog.h:38:24: note: previous declaration is = here 38 | extern PGDLLIMPORT int wal_segment_size; | ^ 1 warning generated. pgbench.c:4664:11: warning: declaration shadows a local variable = [-Wshadow] 4664 | int64 skipped =3D 0; | ^ pgbench.c:4632:25: note: previous declaration is here 4632 | StatsData *agg, bool skipped, double latency, double = lag) | ^ 1 warning generated. describe.c:1780:17: warning: declaration shadows a local variable = [-Wshadow] 1780 | printQueryOpt myopt =3D pset.popt; | ^ describe.c:1596:16: note: previous declaration is here 1596 | printTableOpt myopt =3D pset.popt.topt; | ^ describe.c:1941:17: warning: declaration shadows a local variable = [-Wshadow] 1941 | printQueryOpt myopt =3D pset.popt; | ^ describe.c:1596:16: note: previous declaration is here 1596 | printTableOpt myopt =3D pset.popt.topt; | ^ describe.c:2427:13: warning: declaration shadows a local variable = [-Wshadow] 2427 | char *schemaname =3D = PQgetvalue(result, 0, 0); | ^ describe.c:1588:37: note: previous declaration is here 1588 | describeOneTableDetails(const char *schemaname, | ^ 3 warnings generated. prompt.c:206:24: warning: declaration shadows a local variable = [-Wshadow] 206 | PGpipelineStatus = status =3D PQpipelineStatus(pset.db); | = ^ prompt.c:71:27: note: previous declaration is here 71 | get_prompt(promptStatus_t status, ConditionalStack cstack) | ^ prompt.c:393:12: warning: declaration shadows a local variable = [-Wshadow] 393 | char *p =3D destination; | ^ prompt.c:77:14: note: previous declaration is here 77 | const char *p; | ^ 2 warnings generated. --Apple-Mail=_CC8D6DC3-B6A1-478F-A73F-7E3087844CD8 Content-Disposition: attachment; filename=v19-shadow-warnings-patched.txt Content-Type: text/plain; x-unix-mode=0644; name="v19-shadow-warnings-patched.txt" Content-Transfer-Encoding: quoted-printable controldata_utils.c:53:29: warning: declaration shadows a variable in = the global scope [-Wshadow] 53 | get_controlfile(const char *DataDir, bool *crc_ok_p) | ^ ../../src/include/miscadmin.h:175:26: note: previous declaration is here 175 | extern PGDLLIMPORT char *DataDir; | ^ controldata_utils.c:190:32: warning: declaration shadows a variable in = the global scope [-Wshadow] 190 | update_controlfile(const char *DataDir, | ^ ../../src/include/miscadmin.h:175:26: note: previous declaration is here 175 | extern PGDLLIMPORT char *DataDir; | ^ 2 warnings generated. pgtz.c:234:22: warning: declaration shadows a variable in the global = scope [-Wshadow] 234 | pg_tzset(const char *tzname) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ pgtz.c:324:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 324 | char tzname[128]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 2 warnings generated. brin.c:702:16: warning: declaration shadows a local variable [-Wshadow] 702 | FmgrInfo *tmp; | ^ brin.c:594:11: note: previous declaration is here 594 | char *tmp PG_USED_FOR_ASSERTS_ONLY; | ^ 1 warning generated. gistbuild.c:1161:23: warning: declaration shadows a local variable = [-Wshadow] 1161 | GISTPageSplitInfo *splitinfo =3D = lfirst(lc); | ^ gistbuild.c:1061:11: note: previous declaration is here 1061 | List *splitinfo; | ^ 1 warning generated. xlogdesc.c:41:26: warning: declaration shadows a variable in the global = scope [-Wshadow] 41 | get_wal_level_string(int wal_level) | ^ ../../../../src/include/access/xlog.h:98:24: note: previous declaration = is here 98 | extern PGDLLIMPORT int wal_level; | ^ 1 warning generated. xlogreader.c:108:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 108 | XLogReaderAllocate(int wal_segment_size, const char *waldir, | ^ ../../../../src/include/access/xlog.h:38:24: note: previous declaration = is here 38 | extern PGDLLIMPORT int wal_segment_size; | ^ 1 warning generated. xlogrecovery.c:1168:13: warning: declaration shadows a variable in the = global scope [-Wshadow] 1168 | bool *backupEndRequired, bool = *backupFromStandby) | ^ xlogrecovery.c:287:13: note: previous declaration is here 287 | static bool backupEndRequired =3D false; | ^ xlogrecovery.c:1880:33: warning: declaration shadows a variable in the = global scope [-Wshadow] 1880 | ApplyWalRecord(XLogReaderState *xlogreader, XLogRecord *record, = TimeLineID *replayTLI) | ^ xlogrecovery.c:192:25: note: previous declaration is here 192 | static XLogReaderState *xlogreader =3D NULL; | ^ xlogrecovery.c:3105:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 3105 | ReadRecord(XLogPrefetcher *xlogprefetcher, int emode, | ^ xlogrecovery.c:195:24: note: previous declaration is here 195 | static XLogPrefetcher *xlogprefetcher =3D NULL; | ^ xlogrecovery.c:3109:19: warning: declaration shadows a variable in the = global scope [-Wshadow] 3109 | XLogReaderState *xlogreader =3D = XLogPrefetcherGetReader(xlogprefetcher); | ^ xlogrecovery.c:192:25: note: previous declaration is here 192 | static XLogReaderState *xlogreader =3D NULL; | ^ xlogrecovery.c:3274:31: warning: declaration shadows a variable in the = global scope [-Wshadow] 3274 | XLogPageRead(XLogReaderState *xlogreader, XLogRecPtr = targetPagePtr, int reqLen, | ^ xlogrecovery.c:192:25: note: previous declaration is here 192 | static XLogReaderState *xlogreader =3D NULL; | ^ xlogrecovery.c:4057:38: warning: declaration shadows a variable in the = global scope [-Wshadow] 4057 | ReadCheckpointRecord(XLogPrefetcher *xlogprefetcher, XLogRecPtr = RecPtr, | ^ xlogrecovery.c:195:24: note: previous declaration is here 195 | static XLogPrefetcher *xlogprefetcher =3D NULL; | ^ 6 warnings generated. bootstrap.c:240:11: warning: declaration shadows a variable in the = global scope [-Wshadow] 240 | char *progname =3D argv[0]; | ^ ../../../src/include/postmaster/postmaster.h:88:32: note: previous = declaration is here 88 | extern PGDLLIMPORT const char *progname; | ^ 1 warning generated. objectaddress.c:2239:12: warning: declaration shadows a local variable = [-Wshadow] 2239 | bool *nulls; | ^ objectaddress.c:2218:8: note: previous declaration is here 2218 | bool nulls[3]; | ^ objectaddress.c:2256:12: warning: declaration shadows a local variable = [-Wshadow] 2256 | bool *nulls; | ^ objectaddress.c:2218:8: note: previous declaration is here 2218 | bool nulls[3]; | ^ objectaddress.c:2293:12: warning: declaration shadows a local variable = [-Wshadow] 2293 | bool *nulls; | ^ objectaddress.c:2218:8: note: previous declaration is here 2218 | bool nulls[3]; | ^ 3 warnings generated. pg_constraint.c:864:22: warning: declaration shadows a local variable = [-Wshadow] 864 | CookedConstraint *cooked; | ^ pg_constraint.c:834:47: note: previous declaration is here 834 | RelationGetNotNullConstraints(Oid relid, bool cooked, bool = include_noinh) | ^ 1 warning generated. extension.c:1456:13: warning: declaration shadows a local variable = [-Wshadow] 1456 | char *schemaName =3D = get_namespace_name(reqschema); | ^ extension.c:1250:20: note: previous declaration is here 1250 | const char = *schemaName) | ^ 1 warning generated. schemacmds.c:208:12: warning: declaration shadows a local variable = [-Wshadow] 208 | Node *stmt =3D (Node *) = lfirst(parsetree_item); | ^ schemacmds.c:52:59: note: previous declaration is here 52 | CreateSchemaCommand(ParseState *pstate, CreateSchemaStmt *stmt, | ^ 1 warning generated. statscmds.c:352:16: warning: declaration shadows a local variable = [-Wshadow] 352 | Bitmapset *attnums =3D NULL; | ^ statscmds.c:66:9: note: previous declaration is here 66 | int16 attnums[STATS_MAX_DIMENSIONS]; | ^ 1 warning generated. tablecmds.c:15965:20: warning: declaration shadows a local variable = [-Wshadow] 15965 | AlterTableCmd *cmd =3D = lfirst_node(AlterTableCmd, lcmd); | ^ tablecmds.c:15874:67: note: previous declaration is here 15874 | ATPostAlterTypeParse(Oid oldId, Oid oldRelId, Oid refRelId, = char *cmd, | = ^ tablecmds.c:16036:20: warning: declaration shadows a local variable = [-Wshadow] 16036 | AlterTableCmd *cmd =3D = makeNode(AlterTableCmd); | ^ tablecmds.c:15874:67: note: previous declaration is here 15874 | ATPostAlterTypeParse(Oid oldId, Oid oldRelId, Oid refRelId, = char *cmd, | = ^ 2 warnings generated. trigger.c:1170:13: warning: declaration shadows a local variable = [-Wshadow] 1170 | Node *qual; | ^ trigger.c:190:11: note: previous declaration is here 190 | char *qual; | ^ 1 warning generated. execExprInterp.c:476:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 476 | static const void *const dispatch_table[] =3D { | ^ execExprInterp.c:114:21: note: previous declaration is here 114 | static const void **dispatch_table =3D NULL; | ^ 1 warning generated. nodeAgg.c:4070:20: warning: declaration shadows a local variable = [-Wshadow] 4070 | AggStatePerPhase phase =3D = &aggstate->phases[phaseidx]; | ^ nodeAgg.c:3295:8: note: previous declaration is here 3295 | int phase; | ^ 1 warning generated. nodeValuesscan.c:144:16: warning: declaration shadows a local variable = [-Wshadow] 144 | ExprState *estate =3D (ExprState *) = lfirst(lc); | ^ nodeValuesscan.c:50:13: note: previous declaration is here 50 | EState *estate; | ^ 1 warning generated. be-secure-common.c:121:44: warning: declaration shadows a variable in = the global scope [-Wshadow] 121 | check_ssl_key_file_permissions(const char *ssl_key_file, bool = isServerStart) | ^ ../../../src/include/libpq/libpq.h:110:26: note: previous declaration is = here 110 | extern PGDLLIMPORT char *ssl_key_file; | ^ 1 warning generated. main.c:284:27: warning: declaration shadows a variable in the global = scope [-Wshadow] 284 | startup_hacks(const char *progname) | ^ main.c:44:13: note: previous declaration is here 44 | const char *progname; | ^ main.c:388:18: warning: declaration shadows a variable in the global = scope [-Wshadow] 388 | help(const char *progname) | ^ main.c:44:13: note: previous declaration is here 44 | const char *progname; | ^ main.c:447:24: warning: declaration shadows a variable in the global = scope [-Wshadow] 447 | check_root(const char *progname) | ^ main.c:44:13: note: previous declaration is here 44 | const char *progname; | ^ 3 warnings generated. equivclass.c:879:16: warning: declaration shadows a local variable = [-Wshadow] 879 | RelOptInfo *rel =3D = root->simple_rel_array[i]; | ^ equivclass.c:742:15: note: previous declaration is here 742 | Relids rel, | ^ 1 warning generated. createplan.c:1238:12: warning: declaration shadows a local variable = [-Wshadow] 1238 | Plan *plan; | ^ createplan.c:1210:13: note: previous declaration is here 1210 | Append *plan; | ^ createplan.c:2410:12: warning: declaration shadows a local variable = [-Wshadow] 2410 | Plan *plan; | ^ createplan.c:2400:13: note: previous declaration is here 2400 | Result *plan; | ^ 2 warnings generated. partdesc.c:229:16: warning: declaration shadows a local variable = [-Wshadow] 229 | ScanKeyData key[1]; | ^ partdesc.c:149:15: note: previous declaration is here 149 | PartitionKey key =3D RelationGetPartitionKey(rel); | ^ 1 warning generated. dependencies.c:1176:14: warning: declaration shadows a local variable = [-Wshadow] 1176 | OpExpr *expr =3D (OpExpr *) clause; | ^ dependencies.c:1152:87: note: previous declaration is here 1152 | dependency_is_compatible_expression(Node *clause, Index relid, = List *statlist, Node **expr) | = ^ dependencies.c:1210:22: warning: declaration shadows a local variable = [-Wshadow] 1210 | ScalarArrayOpExpr *expr =3D (ScalarArrayOpExpr = *) clause; | ^ dependencies.c:1152:87: note: previous declaration is here 1152 | dependency_is_compatible_expression(Node *clause, Index relid, = List *statlist, Node **expr) | = ^ 2 warnings generated. extended_stats.c:1093:10: warning: declaration shadows a local variable = [-Wshadow] 1093 | bool isnull; | ^ extended_stats.c:1043:11: note: previous declaration is here 1043 | bool *isnull; | ^ 1 warning generated. read_stream.c:1297:12: warning: declaration shadows a local variable = [-Wshadow] 1297 | void *per_buffer_data; | ^ read_stream.c:1020:52: note: previous declaration is here 1020 | read_stream_next_buffer(ReadStream *stream, void = **per_buffer_data) | ^ 1 warning generated. bufmgr.c:1302:11: warning: declaration shadows a local variable = [-Wshadow] 1302 | uint32 flags =3D = EB_SKIP_EXTENSION_LOCK; | ^ bufmgr.c:1292:8: note: previous declaration is here 1292 | int flags; | ^ 1 warning generated. date.c:565:9: warning: declaration shadows a variable in the global = scope [-Wshadow] 565 | int32 days =3D PG_GETARG_INT32(1); | ^ ../../../../src/include/utils/datetime.h:261:38: note: previous = declaration is here 261 | extern PGDLLIMPORT const char *const days[]; /* days (full = names) */ | ^ date.c:589:9: warning: declaration shadows a variable in the global = scope [-Wshadow] 589 | int32 days =3D PG_GETARG_INT32(1); | ^ ../../../../src/include/utils/datetime.h:261:38: note: previous = declaration is here 261 | extern PGDLLIMPORT const char *const days[]; /* days (full = names) */ | ^ date.c:3155:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 3155 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 3 warnings generated. datetime.c:646:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 646 | int days; | ^ datetime.c:85:19: note: previous declaration is here 85 | const char *const days[] =3D {"Sunday", "Monday", "Tuesday", = "Wednesday", | ^ 1 warning generated. formatting.c:3037:25: warning: declaration shadows a variable in the = global scope [-Wshadow] 3037 | const char *const = *months; | ^ ../../../../src/include/utils/datetime.h:259:38: note: previous = declaration is here 259 | extern PGDLLIMPORT const char *const months[]; /* months = (3-char | ^ 1 warning generated. jsonpath_exec.c:1928:24: warning: declaration shadows a local variable = [-Wshadow] 1928 | JsonPathExecResult res; | ^ jsonpath_exec.c:1829:15: note: previous declaration is here 1829 | JsonPathBool res; | ^ jsonpath_exec.c:1946:24: warning: declaration shadows a local variable = [-Wshadow] 1946 | JsonPathExecResult res =3D | ^ jsonpath_exec.c:1829:15: note: previous declaration is here 1829 | JsonPathBool res; | ^ jsonpath_exec.c:2131:17: warning: declaration shadows a local variable = [-Wshadow] 2131 | JsonPathBool res =3D exec(pred, lval, = rval, param); | ^ jsonpath_exec.c:2084:21: note: previous declaration is here 2084 | JsonPathExecResult res; | ^ jsonpath_exec.c:4447:16: warning: declaration shadows a local variable = [-Wshadow] 4447 | ExprState *state =3D = lfirst_node(ExprState, exprlc); | ^ jsonpath_exec.c:4420:41: note: previous declaration is here 4420 | JsonTableInitOpaque(TableFuncScanState *state, int natts) | ^ 4 warnings generated. pg_upgrade_support.c:230:13: warning: declaration shadows a local = variable [-Wshadow] 230 | char *extName =3D = TextDatumGetCString(textDatums[i]); | ^ pg_upgrade_support.c:187:11: note: previous declaration is here 187 | text *extName; | ^ 1 warning generated. ruleutils.c:13100:23: warning: declaration shadows a local variable = [-Wshadow] 13100 | deparse_context = context =3D {0}; | = ^ ruleutils.c:12955:67: note: previous declaration is here 12955 | get_from_clause_item(Node *jtnode, Query *query, = deparse_context *context) | = ^ 1 warning generated. timestamp.c:485:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 485 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ timestamp.c:554:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 554 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ timestamp.c:1527:9: warning: declaration shadows a variable in the = global scope [-Wshadow] 1527 | int32 months =3D PG_GETARG_INT32(1); | ^ ../../../../src/include/utils/datetime.h:259:38: note: previous = declaration is here 259 | extern PGDLLIMPORT const char *const months[]; /* months = (3-char | ^ timestamp.c:1529:9: warning: declaration shadows a variable in the = global scope [-Wshadow] 1529 | int32 days =3D PG_GETARG_INT32(3); | ^ ../../../../src/include/utils/datetime.h:261:38: note: previous = declaration is here 261 | extern PGDLLIMPORT const char *const days[]; /* days (full = names) */ | ^ timestamp.c:2128:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 2128 | dt2local(Timestamp dt, int timezone) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:106:13: note: previous declaration is here 106 | extern long timezone __DARWIN_ALIAS(timezone); | ^ timestamp.c:2521:9: warning: declaration shadows a variable in the = global scope [-Wshadow] 2521 | int64 days; | ^ ../../../../src/include/utils/datetime.h:261:38: note: previous = declaration is here 261 | extern PGDLLIMPORT const char *const days[]; /* days (full = names) */ | ^ timestamp.c:6219:11: warning: declaration shadows a local variable = [-Wshadow] 6219 | int64 val; | ^ timestamp.c:6080:5: note: previous declaration is here 6080 | val; | ^ timestamp.c:6308:8: warning: declaration shadows a variable in the = global scope [-Wshadow] 6308 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ timestamp.c:6573:8: warning: declaration shadows a variable in the = global scope [-Wshadow] 6573 | char tzname[TZ_STRLEN_MAX + 1]; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 9 warnings generated. varlena.c:3318:13: warning: declaration shadows a local variable = [-Wshadow] 3318 | char *chunk_start; | ^ varlena.c:3253:15: note: previous declaration is here 3253 | const char *chunk_start =3D p; | ^ varlena.c:4949:14: warning: declaration shadows a local variable = [-Wshadow] 4949 | char *str; | ^ varlena.c:4784:17: note: previous declaration is here 4784 | StringInfoData str; | ^ 2 warnings generated. inval.c:481:2: warning: declaration shadows a local variable [-Wshadow] 481 | ProcessMessageSubGroup(group, RelCacheMsgs, | ^ inval.c:390:31: note: expanded from macro 'ProcessMessageSubGroup' 390 | SharedInvalidationMessage *msg =3D \ | ^ inval.c:474:28: note: previous declaration is here 474 | SharedInvalidationMessage msg; | ^ inval.c:511:2: warning: declaration shadows a local variable [-Wshadow] 511 | ProcessMessageSubGroup(group, RelCacheMsgs, | ^ inval.c:390:31: note: expanded from macro 'ProcessMessageSubGroup' 390 | SharedInvalidationMessage *msg =3D \ | ^ inval.c:508:28: note: previous declaration is here 508 | SharedInvalidationMessage msg; | ^ inval.c:540:2: warning: declaration shadows a local variable [-Wshadow] 540 | ProcessMessageSubGroup(group, RelCacheMsgs, | ^ inval.c:390:31: note: expanded from macro 'ProcessMessageSubGroup' 390 | SharedInvalidationMessage *msg =3D \ | ^ inval.c:536:28: note: previous declaration is here 536 | SharedInvalidationMessage msg; | ^ inval.c:1053:2: warning: declaration shadows a local variable [-Wshadow] 1053 | = ProcessMessageSubGroupMulti(&transInvalInfo->PriorCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1012:66: note: previous declaration is here 1012 | xactGetCommittedInvalidationMessages(SharedInvalidationMessage = **msgs, | = ^ inval.c:1059:2: warning: declaration shadows a local variable [-Wshadow] 1059 | = ProcessMessageSubGroupMulti(&transInvalInfo->ii.CurrentCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1012:66: note: previous declaration is here 1012 | xactGetCommittedInvalidationMessages(SharedInvalidationMessage = **msgs, | = ^ inval.c:1065:2: warning: declaration shadows a local variable [-Wshadow] 1065 | = ProcessMessageSubGroupMulti(&transInvalInfo->PriorCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1012:66: note: previous declaration is here 1012 | xactGetCommittedInvalidationMessages(SharedInvalidationMessage = **msgs, | = ^ inval.c:1071:2: warning: declaration shadows a local variable [-Wshadow] 1071 | = ProcessMessageSubGroupMulti(&transInvalInfo->ii.CurrentCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1012:66: note: previous declaration is here 1012 | xactGetCommittedInvalidationMessages(SharedInvalidationMessage = **msgs, | = ^ inval.c:1109:2: warning: declaration shadows a local variable [-Wshadow] 1109 | = ProcessMessageSubGroupMulti(&inplaceInvalInfo->CurrentCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1088:60: note: previous declaration is here 1088 | inplaceGetInvalidationMessages(SharedInvalidationMessage **msgs, | ^ inval.c:1115:2: warning: declaration shadows a local variable [-Wshadow] 1115 | = ProcessMessageSubGroupMulti(&inplaceInvalInfo->CurrentCmdInvalidMsgs, | ^ inval.c:406:31: note: expanded from macro 'ProcessMessageSubGroupMulti' 406 | SharedInvalidationMessage *msgs =3D \ | ^ inval.c:1088:60: note: previous declaration is here 1088 | inplaceGetInvalidationMessages(SharedInvalidationMessage **msgs, | ^ 9 warnings generated. freepage.c:1589:9: warning: declaration shadows a local variable = [-Wshadow] 1589 | Size result; | ^ freepage.c:1480:28: note: previous declaration is here 1480 | FreePageBtreeSearchResult result; | ^ 1 warning generated. fe-connect.c:4005:11: warning: declaration shadows a local variable = [-Wshadow] 4005 | int res; | ^ fe-connect.c:2929:14: note: previous declaration is here 2929 | PGresult *res; | ^ 1 warning generated. descriptor.c:75:46: warning: declaration shadows a variable in the = global scope [-Wshadow] 75 | add_descriptor(const char *name, const char *connection) | ^ ./preproc_extern.h:39:14: note: previous declaration is here 39 | extern char *connection; | ^ descriptor.c:94:47: warning: declaration shadows a variable in the = global scope [-Wshadow] 94 | drop_descriptor(const char *name, const char *connection) | ^ ./preproc_extern.h:39:14: note: previous declaration is here 39 | extern char *connection; | ^ descriptor.c:125:49: warning: declaration shadows a variable in the = global scope [-Wshadow] 125 | lookup_descriptor(const char *name, const char *connection) | ^ ./preproc_extern.h:39:14: note: previous declaration is here 39 | extern char *connection; | ^ 3 warnings generated. ecpg.c:35:18: warning: declaration shadows a variable in the global = scope [-Wshadow] 35 | help(const char *progname) | ^ ecpg.c:23:20: note: previous declaration is here 23 | static const char *progname; | ^ 1 warning generated. preproc.y:182:46: warning: declaration shadows a variable in the global = scope [-Wshadow] 182 | adjust_outofscope_cursor_vars(struct cursor *cur) | ^ ./preproc_extern.h:53:23: note: previous declaration is here 53 | extern struct cursor *cur; | ^ preproc.y:494:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 494 | int initializer, int array) | ^ preproc.y:41:12: note: previous declaration is here 41 | static int initializer =3D 0; | ^ 2 warnings generated. print.c:936:10: warning: declaration shadows a local variable [-Wshadow] 936 | int curr_nl_line; | ^ print.c:670:8: note: previous declaration is here 670 | *curr_nl_line, | ^ 1 warning generated. findtimezone.c:234:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 234 | score_timezone(const char *tzname, struct tztry *tt) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ findtimezone.c:320:36: warning: declaration shadows a variable in the = global scope [-Wshadow] 320 | perfect_timezone_match(const char *tzname, struct tztry *tt) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ findtimezone.c:1728:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 1728 | validate_zone(const char *tzname) | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ findtimezone.c:1759:14: warning: declaration shadows a variable in the = global scope [-Wshadow] 1759 | const char *tzname; | ^ = /Library/Developer/CommandLineTools/SDKs/MacOSX26.2.sdk/usr/include/_time.= h:101:25: note: previous declaration is here 101 | extern char *_LIBC_CSTR tzname[_LIBC_COUNT(2)]; | ^ 4 warnings generated. initdb.c:831:14: warning: declaration shadows a variable in the global = scope [-Wshadow] 831 | const char *username; | ^ initdb.c:153:14: note: previous declaration is here 153 | static char *username =3D NULL; | ^ initdb.c:1065:11: warning: declaration shadows a variable in the global = scope [-Wshadow] 1065 | FILE *conf_file; | ^ initdb.c:181:14: note: previous declaration is here 181 | static char *conf_file; | ^ initdb.c:2166:31: warning: declaration shadows a variable in the global = scope [-Wshadow] 2166 | locale_date_order(const char *locale) | ^ initdb.c:140:14: note: previous declaration is here 140 | static char *locale =3D NULL; | ^ initdb.c:2225:45: warning: declaration shadows a variable in the global = scope [-Wshadow] 2225 | check_locale_name(int category, const char *locale, char = **canonname) | ^ initdb.c:140:14: note: previous declaration is here 140 | static char *locale =3D NULL; | ^ initdb.c:2288:35: warning: declaration shadows a variable in the global = scope [-Wshadow] 2288 | check_locale_encoding(const char *locale, int user_enc) | ^ initdb.c:140:14: note: previous declaration is here 140 | static char *locale =3D NULL; | ^ initdb.c:2540:19: warning: declaration shadows a variable in the global = scope [-Wshadow] 2540 | usage(const char *progname) | ^ initdb.c:175:20: note: previous declaration is here 175 | static const char *progname; | ^ initdb.c:2620:33: warning: declaration shadows a variable in the global = scope [-Wshadow] 2620 | check_need_password(const char *authmethodlocal, const char = *authmethodhost) | ^ initdb.c:158:20: note: previous declaration is here 158 | static const char *authmethodlocal =3D NULL; | ^ initdb.c:2620:62: warning: declaration shadows a variable in the global = scope [-Wshadow] 2620 | check_need_password(const char *authmethodlocal, const char = *authmethodhost) | ^ initdb.c:157:20: note: previous declaration is here 157 | static const char *authmethodhost =3D NULL; | ^ 8 warnings generated. pg_amcheck.c:1183:18: warning: declaration shadows a variable in the = global scope [-Wshadow] 1183 | help(const char *progname) | ^ pg_amcheck.c:141:20: note: previous declaration is here 141 | static const char *progname =3D NULL; | ^ 1 warning generated. pg_basebackup.c:1016:25: warning: declaration shadows a variable in the = global scope [-Wshadow] 1016 | ReceiveCopyData(PGconn *conn, WriteDataCallback callback, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_basebackup.c:1272:30: warning: declaration shadows a variable in the = global scope [-Wshadow] 1272 | ReceiveArchiveStream(PGconn *conn, pg_compress_specification = *compress) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_basebackup.c:1587:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 1587 | ReceiveTarFile(PGconn *conn, char *archive_name, char = *spclocation, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_basebackup.c:1686:31: warning: declaration shadows a variable in the = global scope [-Wshadow] 1686 | ReceiveBackupManifest(PGconn *conn) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_basebackup.c:1723:39: warning: declaration shadows a variable in the = global scope [-Wshadow] 1723 | ReceiveBackupManifestInMemory(PGconn *conn, PQExpBuffer buf) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ 5 warnings generated. receivelog.c:337:22: warning: declaration shadows a variable in the = global scope [-Wshadow] 337 | sendFeedback(PGconn *conn, XLogRecPtr blockpos, TimestampTz now, = bool replyRequested) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:375:40: warning: declaration shadows a variable in the = global scope [-Wshadow] 375 | CheckServerVersionForStreaming(PGconn *conn) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:453:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 453 | ReceiveXlogStream(PGconn *conn, StreamCtl *stream) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:745:26: warning: declaration shadows a variable in the = global scope [-Wshadow] 745 | HandleCopyStream(PGconn *conn, StreamCtl *stream, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:878:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 878 | CopyStreamPoll(PGconn *conn, long timeout_ms, pgsocket = stop_socket) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:940:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 940 | CopyStreamReceive(PGconn *conn, long timeout, pgsocket = stop_socket, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:994:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 994 | ProcessKeepaliveMsg(PGconn *conn, StreamCtl *stream, char = *copybuf, int len, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:1048:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 1048 | ProcessWALDataMsg(PGconn *conn, StreamCtl *stream, char = *copybuf, int len, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:1179:31: warning: declaration shadows a variable in the = global scope [-Wshadow] 1179 | HandleEndOfCopyStream(PGconn *conn, StreamCtl *stream, char = *copybuf, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ receivelog.c:1218:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 1218 | CheckCopyStreamStop(PGconn *conn, StreamCtl *stream, XLogRecPtr = blockpos) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ 10 warnings generated. streamutil.c:276:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 276 | RetrieveWalSegSize(PGconn *conn) | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:355:35: warning: declaration shadows a variable in the = global scope [-Wshadow] 355 | RetrieveDataDirCreatePerm(PGconn *conn) | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:409:27: warning: declaration shadows a variable in the = global scope [-Wshadow] 409 | RunIdentifySystem(PGconn *conn, char **sysid, TimeLineID = *starttli, | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:490:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 490 | GetSlotInformation(PGconn *conn, const char *slot_name, | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:584:31: warning: declaration shadows a variable in the = global scope [-Wshadow] 584 | CreateReplicationSlot(PGconn *conn, const char *slot_name, const = char *plugin, | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ streamutil.c:697:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 697 | DropReplicationSlot(PGconn *conn, const char *slot_name) | ^ streamutil.c:52:12: note: previous declaration is here 52 | PGconn *conn =3D NULL; | ^ 6 warnings generated. pg_createsubscriber.c:414:46: warning: declaration shadows a variable in = the global scope [-Wshadow] 414 | get_exec_path(const char *argv0, const char *progname) | ^ pg_createsubscriber.c:157:20: note: previous declaration is here 157 | static const char *progname; | ^ 1 warning generated. pg_receivewal.c:280:11: warning: declaration shadows a local variable = [-Wshadow] 280 | uint32 tli; | ^ pg_receivewal.c:268:28: note: previous declaration is here 268 | FindStreamingStart(uint32 *tli) | ^ 1 warning generated. pg_recvlogical.c:129:22: warning: declaration shadows a variable in the = global scope [-Wshadow] 129 | sendFeedback(PGconn *conn, TimestampTz now, bool force, bool = replyRequested) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_recvlogical.c:1055:30: warning: declaration shadows a variable in the = global scope [-Wshadow] 1055 | flushAndSendFeedback(PGconn *conn, TimestampTz *now) | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_recvlogical.c:1071:28: warning: declaration shadows a variable in the = global scope [-Wshadow] 1071 | prepareToTerminate(PGconn *conn, XLogRecPtr endpos, = StreamStopReason reason, | ^ ./streamutil.h:30:16: note: previous declaration is here 30 | extern PGconn *conn; | ^ pg_recvlogical.c:1071:45: warning: declaration shadows a variable in the = global scope [-Wshadow] 1071 | prepareToTerminate(PGconn *conn, XLogRecPtr endpos, = StreamStopReason reason, | ^ pg_recvlogical.c:51:19: note: previous declaration is here 51 | static XLogRecPtr endpos =3D InvalidXLogRecPtr; | ^ 4 warnings generated. pg_controldata.c:73:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 73 | wal_level_str(WalLevel wal_level) | ^ ../../../src/include/access/xlog.h:98:24: note: previous declaration is = here 98 | extern PGDLLIMPORT int wal_level; | ^ 1 warning generated. pg_ctl.c:876:36: warning: declaration shadows a variable in the global = scope [-Wshadow] 876 | find_other_exec_or_die(const char *argv0, const char *target, = const char *versionstr) | ^ pg_ctl.c:94:14: note: previous declaration is here 94 | static char *argv0 =3D NULL; | ^ 1 warning generated. pg_dump.c:1291:18: warning: declaration shadows a variable in the global = scope [-Wshadow] 1291 | help(const char *progname) | ^ ./pg_backup_utils.h:28:20: note: previous declaration is here 28 | extern const char *progname; | ^ pg_dump.c:1650:13: warning: declaration shadows a variable in the global = scope [-Wshadow] 1650 | bool = strict_names) | ^ pg_dump.c:157:12: note: previous declaration is here 157 | static int strict_names =3D 0; | ^ pg_dump.c:1709:16: warning: declaration shadows a variable in the global = scope [-Wshadow] 1709 | bool = strict_names) | = ^ pg_dump.c:157:12: note: previous declaration is here 157 | static int strict_names =3D 0; | ^ pg_dump.c:1813:15: warning: declaration shadows a variable in the global = scope [-Wshadow] 1813 | bool = strict_names, bool with_child_tables) | ^ pg_dump.c:157:12: note: previous declaration is here 157 | static int strict_names =3D 0; | ^ pg_dump.c:11005:15: warning: declaration shadows a variable in the = global scope [-Wshadow] 11005 | CommentItem *comments; | ^ pg_dump.c:202:21: note: previous declaration is here 202 | static CommentItem *comments =3D NULL; | ^ pg_dump.c:11006:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 11006 | int ncomments; | ^ pg_dump.c:203:12: note: previous declaration is here 203 | static int ncomments =3D 0; | ^ pg_dump.c:11563:15: warning: declaration shadows a variable in the = global scope [-Wshadow] 11563 | CommentItem *comments; | ^ pg_dump.c:202:21: note: previous declaration is here 202 | static CommentItem *comments =3D NULL; | ^ pg_dump.c:11564:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 11564 | int ncomments; | ^ pg_dump.c:203:12: note: previous declaration is here 203 | static int ncomments =3D 0; | ^ pg_dump.c:13292:15: warning: declaration shadows a variable in the = global scope [-Wshadow] 13292 | CommentItem *comments; | ^ pg_dump.c:202:21: note: previous declaration is here 202 | static CommentItem *comments =3D NULL; | ^ pg_dump.c:13293:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 13293 | int ncomments; | ^ pg_dump.c:203:12: note: previous declaration is here 203 | static int ncomments =3D 0; | ^ 10 warnings generated. connectdb.c:42:63: warning: declaration shadows a variable in the global = scope [-Wshadow] 42 | trivalue prompt_password, bool = fail_on_error, const char *progname, | = ^ ./pg_backup_utils.h:28:20: note: previous declaration is here 28 | extern const char *progname; | ^ 1 warning generated. pg_restore.c:746:19: warning: declaration shadows a variable in the = global scope [-Wshadow] 746 | usage(const char *progname) | ^ ./pg_backup_utils.h:28:20: note: previous declaration is here 28 | extern const char *progname; | ^ 1 warning generated. pg_dumpall.c:2352:34: warning: declaration shadows a variable in the = global scope [-Wshadow] 2352 | read_dumpall_filters(const char *filename, SimpleStringList = *pattern) | ^ pg_dumpall.c:133:14: note: previous declaration is here 133 | static char *filename =3D NULL; | ^ 1 warning generated. pg_resetwal.c:754:25: warning: declaration shadows a variable in the = global scope [-Wshadow] 754 | PrintControlValues(bool guessed) | ^ pg_resetwal.c:65:13: note: previous declaration is here 65 | static bool guessed =3D false; /* T if we had to guess at any = values */ | ^ 1 warning generated. file_ops.c:189:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 189 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:208:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 208 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:231:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 231 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:245:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 245 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:259:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 259 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ file_ops.c:273:8: warning: declaration shadows a variable in the global = scope [-Wshadow] 273 | char dstpath[MAXPGPATH]; | ^ file_ops.c:32:13: note: previous declaration is here 32 | static char dstpath[MAXPGPATH] =3D ""; | ^ 6 warnings generated. pg_rewind.c:92:19: warning: declaration shadows a variable in the global = scope [-Wshadow] 92 | usage(const char *progname) | ^ pg_rewind.c:63:20: note: previous declaration is here 63 | static const char *progname; | ^ pg_rewind.c:564:51: warning: declaration shadows a variable in the = global scope [-Wshadow] 564 | perform_rewind(filemap_t *filemap, rewind_source *source, | ^ pg_rewind.c:89:23: note: previous declaration is here 89 | static rewind_source *source; | ^ 2 warnings generated. xlogreader.c:108:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 108 | XLogReaderAllocate(int wal_segment_size, const char *waldir, | ^ ../../../src/include/access/xlog.h:38:24: note: previous declaration is = here 38 | extern PGDLLIMPORT int wal_segment_size; | ^ 1 warning generated. pg_test_fsync.c:625:29: warning: declaration shadows a variable in the = global scope [-Wshadow] 625 | print_elapse(struct timeval start_t, struct timeval stop_t, int = ops) | ^ pg_test_fsync.c:73:23: note: previous declaration is here 73 | static struct timeval start_t, | ^ pg_test_fsync.c:625:53: warning: declaration shadows a variable in the = global scope [-Wshadow] 625 | print_elapse(struct timeval start_t, struct timeval stop_t, int = ops) | ^ pg_test_fsync.c:74:4: note: previous declaration is here 74 | stop_t; | ^ 2 warnings generated. xlogdesc.c:41:26: warning: declaration shadows a variable in the global = scope [-Wshadow] 41 | get_wal_level_string(int wal_level) | ^ ../../../src/include/access/xlog.h:98:24: note: previous declaration is = here 98 | extern PGDLLIMPORT int wal_level; | ^ 1 warning generated. xlogreader.c:108:24: warning: declaration shadows a variable in the = global scope [-Wshadow] 108 | XLogReaderAllocate(int wal_segment_size, const char *waldir, | ^ ../../../src/include/access/xlog.h:38:24: note: previous declaration is = here 38 | extern PGDLLIMPORT int wal_segment_size; | ^ 1 warning generated. pgbench.c:4664:11: warning: declaration shadows a local variable = [-Wshadow] 4664 | int64 skipped =3D 0; | ^ pgbench.c:4632:25: note: previous declaration is here 4632 | StatsData *agg, bool skipped, double latency, double = lag) | ^ 1 warning generated. describe.c:1780:17: warning: declaration shadows a local variable = [-Wshadow] 1780 | printQueryOpt myopt =3D pset.popt; | ^ describe.c:1596:16: note: previous declaration is here 1596 | printTableOpt myopt =3D pset.popt.topt; | ^ describe.c:2427:13: warning: declaration shadows a local variable = [-Wshadow] 2427 | char *schemaname =3D = PQgetvalue(result, 0, 0); | ^ describe.c:1588:37: note: previous declaration is here 1588 | describeOneTableDetails(const char *schemaname, | ^ 2 warnings generated. prompt.c:206:24: warning: declaration shadows a local variable = [-Wshadow] 206 | PGpipelineStatus = status =3D PQpipelineStatus(pset.db); | = ^ prompt.c:71:27: note: previous declaration is here 71 | get_prompt(promptStatus_t status, ConditionalStack cstack) | ^ prompt.c:393:12: warning: declaration shadows a local variable = [-Wshadow] 393 | char *p =3D destination; | ^ prompt.c:77:14: note: previous declaration is here 77 | const char *p; | ^ 2 warnings generated. --Apple-Mail=_CC8D6DC3-B6A1-478F-A73F-7E3087844CD8 Content-Disposition: attachment; filename=v1-0001-Cleanup-v19-introduced-shadow-variable-warnings.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="v1-0001-Cleanup-v19-introduced-shadow-variable-warnings.patch" Content-Transfer-Encoding: quoted-printable =46rom=20dd204c1fcc6bdec7ba73f55afcb26a3d39c96bd5=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20"Chao=20Li=20(Evan)"=20=0A= Date:=20Wed,=2022=20Apr=202026=2011:33:16=20+0800=0ASubject:=20[PATCH=20= v1]=20Cleanup=20v19=20introduced=20shadow-variable=20warnings=0A=0A= Suggested-by:=20David=20Rowley=20=0AAuthor:=20Chao=20= Li=20=0AReviewed-by:=0ADiscussion:=20= https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=3DjfC+p5YXHkJyHrDTiQw2nn2FJTmQ@= mail.gmail.com=0A---=0A=20src/backend/commands/tablecmds.c=20=20=20=20=20= =20=20=20=20=20=20=20|=2028=20++++++++++-----------=0A=20= src/backend/commands/wait.c=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20|=2012=20++++-----=0A=20src/backend/postmaster/datachecksum_state.c=20= |=20=208=20+++---=0A=20src/bin/pg_dump/pg_dumpall.c=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20|=2026=20+++++++++----------=0A=20= src/bin/psql/describe.c=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20|=2012=20++++-----=0A=205=20files=20changed,=2043=20= insertions(+),=2043=20deletions(-)=0A=0Adiff=20--git=20= a/src/backend/commands/tablecmds.c=20b/src/backend/commands/tablecmds.c=0A= index=201068d7c7b6a..ec8207687c0=20100644=0A---=20= a/src/backend/commands/tablecmds.c=0A+++=20= b/src/backend/commands/tablecmds.c=0A@@=20-22610,7=20+22610,7=20@@=20= createTableConstraints(List=20**wqueue,=20AlteredTableInfo=20*tab,=0A=20=09= =09bool=09=09ccvalid=20=3D=20constr->check[ccnum].ccvalid;=0A=20=09=09= Node=09=20=20=20*ccbin_node;=0A=20=09=09bool=09=09found_whole_row;=0A-=09= =09Constraint=20*constr;=0A+=09=09Constraint=20*con;=0A=20=0A=20=09=09/*=0A= =20=09=09=20*=20The=20partitioned=20table=20can=20not=20have=20a=20NO=20= INHERIT=20check=20constraint=0A@@=20-22632,19=20+22632,19=20@@=20= createTableConstraints(List=20**wqueue,=20AlteredTableInfo=20*tab,=0A=20=09= =09=09=09=20ccname,=0A=20=09=09=09=09=20= RelationGetRelationName(parent_rel));=0A=20=0A-=09=09constr=20=3D=20= makeNode(Constraint);=0A-=09=09constr->contype=20=3D=20CONSTR_CHECK;=0A-=09= =09constr->conname=20=3D=20pstrdup(ccname);=0A-=09=09constr->deferrable=20= =3D=20false;=0A-=09=09constr->initdeferred=20=3D=20false;=0A-=09=09= constr->is_enforced=20=3D=20ccenforced;=0A-=09=09constr->skip_validation=20= =3D=20!ccvalid;=0A-=09=09constr->initially_valid=20=3D=20ccvalid;=0A-=09=09= constr->is_no_inherit=20=3D=20ccnoinherit;=0A-=09=09constr->raw_expr=20=3D= =20NULL;=0A-=09=09constr->cooked_expr=20=3D=20nodeToString(ccbin_node);=0A= -=09=09constr->location=20=3D=20-1;=0A-=09=09constraints=20=3D=20= lappend(constraints,=20constr);=0A+=09=09con=20=3D=20= makeNode(Constraint);=0A+=09=09con->contype=20=3D=20CONSTR_CHECK;=0A+=09=09= con->conname=20=3D=20pstrdup(ccname);=0A+=09=09con->deferrable=20=3D=20= false;=0A+=09=09con->initdeferred=20=3D=20false;=0A+=09=09= con->is_enforced=20=3D=20ccenforced;=0A+=09=09con->skip_validation=20=3D=20= !ccvalid;=0A+=09=09con->initially_valid=20=3D=20ccvalid;=0A+=09=09= con->is_no_inherit=20=3D=20ccnoinherit;=0A+=09=09con->raw_expr=20=3D=20= NULL;=0A+=09=09con->cooked_expr=20=3D=20nodeToString(ccbin_node);=0A+=09=09= con->location=20=3D=20-1;=0A+=09=09constraints=20=3D=20= lappend(constraints,=20con);=0A=20=09}=0A=20=0A=20=09/*=20Install=20all=20= CHECK=20constraints.=20*/=0Adiff=20--git=20a/src/backend/commands/wait.c=20= b/src/backend/commands/wait.c=0Aindex=20382d5c2d44f..7fe53a6f045=20= 100644=0A---=20a/src/backend/commands/wait.c=0A+++=20= b/src/backend/commands/wait.c=0A@@=20-92,7=20+92,7=20@@=20= ExecWaitStmt(ParseState=20*pstate,=20WaitStmt=20*stmt,=20bool=20= isTopLevel,=0A=20=09=09{=0A=20=09=09=09char=09=20=20=20*timeout_str;=0A=20= =09=09=09const=20char=20*hintmsg;=0A-=09=09=09double=09=09result;=0A+=09=09= =09double=09=09val;=0A=20=0A=20=09=09=09if=20(timeout_specified)=0A=20=09= =09=09=09errorConflictingDefElem(defel,=20pstate);=0A@@=20-100,7=20= +100,7=20@@=20ExecWaitStmt(ParseState=20*pstate,=20WaitStmt=20*stmt,=20= bool=20isTopLevel,=0A=20=0A=20=09=09=09timeout_str=20=3D=20= defGetString(defel);=0A=20=0A-=09=09=09if=20(!parse_real(timeout_str,=20= &result,=20GUC_UNIT_MS,=20&hintmsg))=0A+=09=09=09if=20= (!parse_real(timeout_str,=20&val,=20GUC_UNIT_MS,=20&hintmsg))=0A=20=09=09= =09{=0A=20=09=09=09=09ereport(ERROR,=0A=20=09=09=09=09=09=09= errcode(ERRCODE_INVALID_PARAMETER_VALUE),=0A@@=20-113,20=20+113,20=20@@=20= ExecWaitStmt(ParseState=20*pstate,=20WaitStmt=20*stmt,=20bool=20= isTopLevel,=0A=20=09=09=09=20*=20don't=20fail=20on=20just-out-of-range=20= values=20that=20would=20round=20into=0A=20=09=09=09=20*=20range.=0A=20=09= =09=09=20*/=0A-=09=09=09result=20=3D=20rint(result);=0A+=09=09=09val=20=3D= =20rint(val);=0A=20=0A=20=09=09=09/*=20Range=20check=20*/=0A-=09=09=09if=20= (unlikely(isnan(result)=20||=20!FLOAT8_FITS_IN_INT64(result)))=0A+=09=09=09= if=20(unlikely(isnan(val)=20||=20!FLOAT8_FITS_IN_INT64(val)))=0A=20=09=09= =09=09ereport(ERROR,=0A=20=09=09=09=09=09=09= errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),=0A=20=09=09=09=09=09=09= errmsg("timeout=20value=20is=20out=20of=20range"));=0A=20=0A-=09=09=09if=20= (result=20<=200)=0A+=09=09=09if=20(val=20<=200)=0A=20=09=09=09=09= ereport(ERROR,=0A=20=09=09=09=09=09=09= errcode(ERRCODE_INVALID_PARAMETER_VALUE),=0A=20=09=09=09=09=09=09= errmsg("timeout=20cannot=20be=20negative"));=0A=20=0A-=09=09=09timeout=20= =3D=20(int64)=20result;=0A+=09=09=09timeout=20=3D=20(int64)=20val;=0A=20=09= =09}=0A=20=09=09else=20if=20(strcmp(defel->defname,=20"no_throw")=20=3D=3D= =200)=0A=20=09=09{=0Adiff=20--git=20= a/src/backend/postmaster/datachecksum_state.c=20= b/src/backend/postmaster/datachecksum_state.c=0Aindex=20= b3e99170669..9f9a2f9c40e=20100644=0A---=20= a/src/backend/postmaster/datachecksum_state.c=0A+++=20= b/src/backend/postmaster/datachecksum_state.c=0A@@=20-546,7=20+546,7=20= @@=20StartDataChecksumsWorkerLauncher(DataChecksumsWorkerOperation=20op,=0A= =20{=0A=20=09BackgroundWorker=20bgw;=0A=20=09BackgroundWorkerHandle=20= *bgw_handle;=0A-=09bool=09=09launcher_running;=0A+=09bool=09=09= is_running;=0A=20=09DataChecksumsWorkerOperation=20launcher_running_op;=0A= =20=0A=20#ifdef=20USE_ASSERT_CHECKING=0A@@=20-565,8=20+565,8=20@@=20= StartDataChecksumsWorkerLauncher(DataChecksumsWorkerOperation=20op,=0A=20= =09DataChecksumState->launch_cost_limit=20=3D=20cost_limit;=0A=20=0A=20=09= /*=20Is=20the=20launcher=20already=20running?=20If=20so,=20what=20is=20= it=20doing?=20*/=0A-=09launcher_running=20=3D=20= DataChecksumState->launcher_running;=0A-=09if=20(launcher_running)=0A+=09= is_running=20=3D=20DataChecksumState->launcher_running;=0A+=09if=20= (is_running)=0A=20=09=09launcher_running_op=20=3D=20= DataChecksumState->operation;=0A=20=0A=20=09= LWLockRelease(DataChecksumsWorkerLock);=0A@@=20-589,7=20+589,7=20@@=20= StartDataChecksumsWorkerLauncher(DataChecksumsWorkerOperation=20op,=0A=20= =09=20*=20already=20in=20the=20desired=20state,=20i.e.=20if=20the=20= checksums=20are=20already=20enabled=0A=20=09=20*=20and=20you=20call=20= pg_enable_data_checksums().=0A=20=09=20*/=0A-=09if=20(!launcher_running)=0A= +=09if=20(!is_running)=0A=20=09{=0A=20=09=09/*=0A=20=09=09=20*=20Prepare=20= the=20BackgroundWorker=20and=20launch=20it.=0Adiff=20--git=20= a/src/bin/pg_dump/pg_dumpall.c=20b/src/bin/pg_dump/pg_dumpall.c=0Aindex=20= 9e904f76baa..847310f258d=20100644=0A---=20a/src/bin/pg_dump/pg_dumpall.c=0A= +++=20b/src/bin/pg_dump/pg_dumpall.c=0A@@=20-83,7=20+83,7=20@@=20static=20= void=20buildShSecLabels(PGconn=20*conn,=0A=20=09=09=09=09=09=09=09=20= PQExpBuffer=20buffer);=0A=20static=20void=20executeCommand(PGconn=20= *conn,=20const=20char=20*query);=0A=20static=20void=20= check_for_invalid_global_names(PGconn=20*conn,=0A-=09=09=09=09=09=09=09=09= =09=09=20=20=20SimpleStringList=20*database_exclude_names);=0A+=09=09=09=09= =09=09=09=09=09=09=20=20=20SimpleStringList=20*db_exclude_names);=0A=20= static=20void=20expand_dbname_patterns(PGconn=20*conn,=20= SimpleStringList=20*patterns,=0A=20=09=09=09=09=09=09=09=09=20=20=20= SimpleStringList=20*names);=0A=20static=20void=20= read_dumpall_filters(const=20char=20*filename,=20SimpleStringList=20= *pattern);=0A@@=20-2269,7=20+2269,7=20@@=20executeCommand(PGconn=20= *conn,=20const=20char=20*query)=0A=20=20*/=0A=20static=20void=0A=20= check_for_invalid_global_names(PGconn=20*conn,=0A-=09=09=09=09=09=09=09=20= =20=20SimpleStringList=20*database_exclude_names)=0A+=09=09=09=09=09=09=09= =20=20=20SimpleStringList=20*db_exclude_names)=0A=20{=0A=20=09PGresult=20= =20=20*res;=0A=20=09int=09=09=09i;=0A@@=20-2296,7=20+2296,7=20@@=20= check_for_invalid_global_names(PGconn=20*conn,=0A=20=0A=20=09=09/*=20= Skip=20excluded=20databases=20since=20they=20won't=20be=20in=20map.dat=20= */=0A=20=09=09if=20(strcmp(objtype,=20"database")=20=3D=3D=200=20&&=0A-=09= =09=09simple_string_list_member(database_exclude_names,=20objname))=0A+=09= =09=09simple_string_list_member(db_exclude_names,=20objname))=0A=20=09=09= =09continue;=0A=20=0A=20=09=09if=20(strpbrk(objname,=20"\n\r"))=0A@@=20= -2406,29=20+2406,29=20@@=20read_dumpall_filters(const=20char=20= *filename,=20SimpleStringList=20*pattern)=0A=20static=20ArchiveFormat=0A=20= parseDumpFormat(const=20char=20*format)=0A=20{=0A-=09ArchiveFormat=20= archDumpFormat;=0A+=09ArchiveFormat=20archFormat;=0A=20=0A=20=09if=20= (pg_strcasecmp(format,=20"c")=20=3D=3D=200)=0A-=09=09archDumpFormat=20=3D=20= archCustom;=0A+=09=09archFormat=20=3D=20archCustom;=0A=20=09else=20if=20= (pg_strcasecmp(format,=20"custom")=20=3D=3D=200)=0A-=09=09archDumpFormat=20= =3D=20archCustom;=0A+=09=09archFormat=20=3D=20archCustom;=0A=20=09else=20= if=20(pg_strcasecmp(format,=20"d")=20=3D=3D=200)=0A-=09=09archDumpFormat=20= =3D=20archDirectory;=0A+=09=09archFormat=20=3D=20archDirectory;=0A=20=09= else=20if=20(pg_strcasecmp(format,=20"directory")=20=3D=3D=200)=0A-=09=09= archDumpFormat=20=3D=20archDirectory;=0A+=09=09archFormat=20=3D=20= archDirectory;=0A=20=09else=20if=20(pg_strcasecmp(format,=20"p")=20=3D=3D=20= 0)=0A-=09=09archDumpFormat=20=3D=20archNull;=0A+=09=09archFormat=20=3D=20= archNull;=0A=20=09else=20if=20(pg_strcasecmp(format,=20"plain")=20=3D=3D=20= 0)=0A-=09=09archDumpFormat=20=3D=20archNull;=0A+=09=09archFormat=20=3D=20= archNull;=0A=20=09else=20if=20(pg_strcasecmp(format,=20"t")=20=3D=3D=20= 0)=0A-=09=09archDumpFormat=20=3D=20archTar;=0A+=09=09archFormat=20=3D=20= archTar;=0A=20=09else=20if=20(pg_strcasecmp(format,=20"tar")=20=3D=3D=20= 0)=0A-=09=09archDumpFormat=20=3D=20archTar;=0A+=09=09archFormat=20=3D=20= archTar;=0A=20=09else=0A=20=09=09pg_fatal("unrecognized=20output=20= format=20\"%s\";=20please=20specify=20\"c\",=20\"d\",=20\"p\",=20or=20= \"t\"",=0A=20=09=09=09=09=20format);=0A=20=0A-=09return=20= archDumpFormat;=0A+=09return=20archFormat;=0A=20}=0A=20=0A=20/*=0Adiff=20= --git=20a/src/bin/psql/describe.c=20b/src/bin/psql/describe.c=0Aindex=20= dd1179ef927..974dbc5ec2c=20100644=0A---=20a/src/bin/psql/describe.c=0A= +++=20b/src/bin/psql/describe.c=0A@@=20-1938,7=20+1938,7=20@@=20= describeOneTableDetails(const=20char=20*schemaname,=0A=20=09=20*/=0A=20=09= if=20(tableinfo.relkind=20=3D=3D=20RELKIND_PROPGRAPH)=0A=20=09{=0A-=09=09= printQueryOpt=20myopt=20=3D=20pset.popt;=0A+=09=09printQueryOpt=20mypopt=20= =3D=20pset.popt;=0A=20=09=09char=09=20=20=20*footers[3]=20=3D=20{NULL,=20= NULL,=20NULL};=0A=20=0A=20=09=09printfPQExpBuffer(&buf,=20"/*=20%s=20= */\n",=20_("Get=20property=20graph=20information"));=0A@@=20-1993,12=20= +1993,12=20@@=20describeOneTableDetails(const=20char=20*schemaname,=0A=20= =09=09=09}=0A=20=09=09}=0A=20=0A-=09=09myopt.footers=20=3D=20footers;=0A= -=09=09myopt.topt.default_footer=20=3D=20false;=0A-=09=09myopt.title=20=3D= =20title.data;=0A-=09=09myopt.translate_header=20=3D=20true;=0A+=09=09= mypopt.footers=20=3D=20footers;=0A+=09=09mypopt.topt.default_footer=20=3D=20= false;=0A+=09=09mypopt.title=20=3D=20title.data;=0A+=09=09= mypopt.translate_header=20=3D=20true;=0A=20=0A-=09=09printQuery(res,=20= &myopt,=20pset.queryFout,=20false,=20pset.logfile);=0A+=09=09= printQuery(res,=20&mypopt,=20pset.queryFout,=20false,=20pset.logfile);=0A= =20=0A=20=09=09free(footers[0]);=0A=20=09=09free(footers[1]);=0A--=20=0A= 2.50.1=20(Apple=20Git-155)=0A=0A= --Apple-Mail=_CC8D6DC3-B6A1-478F-A73F-7E3087844CD8--