public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Michael Paquier <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Remove support for OpenSSL *eay32 libs on Windows
Date: Mon, 30 Dec 2024 12:00:26 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

> On 30 Dec 2024, at 02:24, Michael Paquier <[email protected]> wrote:
> 
> On Fri, Dec 27, 2024 at 03:09:48PM +0100, Daniel Gustafsson wrote:
>> The thread in [0] which adds Meson support for *eay32 OpenSSL library names on
>> Windows reminded me that we should remove these from master since we no longer
>> support OpenSSL 1.0.2 (which was the final version with those names).  Attached
>> is a small (as of yet untested on Windows/autoconf) diff removing these names
>> from the Makefiles.
>> 
>> [0] CAHrt6656W9OnFomQTHBGYDcM5CKZ7hcgzFt8L+N0ezBZfcN3zA@mail.gmail.com
> 
> Good idea, looks rather sane to me.

Thanks for looking.

> I don't have a clear idea about
> the WIN32/autoconf combination (sorry!), but I can't really believe
> that packagers of OpenSSL on Windows would want the same library name
> compatibility, patching upstream to be able to achieve the old naming.

I've never heard of anyone doing that, and it would only be additive leaving
the proper named files in place.

> fairywren, hamerkop and drongo use meson.  Lorikeet relies on
> ./configure and builds with OpenSSL 3.0.12, so even there I would hope
> that we are in the clear.

All animals building HEAD would have to be well past the renaming since we
don't support version 1.0.2 there, so they should already be using the new
names.

> Not something I'm planning to care about, just noting that from the
> top of OpenSSL master branch (0958f5a5bc47 as of today):
> $ git grep eay32
> .gitignore:/ms/libeay32.def
> .gitignore:/ms/ssleay32.def

Nice catch, they should indeed not be needed anymore.  I can submit a PR for it
if you don't want to deal with setting up a CLA.

--
Daniel Gustafsson

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Remove support for OpenSSL *eay32 libs on Windows
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox