public inbox for [email protected]
help / color / mirror / Atom feed[PATCH v8 8/8] pg_dump: partitioned index depend on its partitions
5+ messages / 5 participants
[nested] [flat]
* [PATCH v8 8/8] pg_dump: partitioned index depend on its partitions
@ 2020-11-25 23:34 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 5+ messages in thread
From: Justin Pryzby @ 2020-11-25 23:34 UTC (permalink / raw)
This is required for restoring clustered parent index, which is marked INVALID
until indexes have been built on all its child tables, and it's prohibited to
CLUSTER ON an INVALID index
See also: 8cff4f5348d075e063100071013f00a900c32b0f
---
src/backend/commands/tablecmds.c | 6 +++---
src/bin/pg_dump/common.c | 8 ++++++++
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 420991e315..a478c13990 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -17521,6 +17521,9 @@ validatePartitionedIndex(Relation partedIdx, Relation partedTbl)
table_close(idxRel, RowExclusiveLock);
}
+ /* make sure we see the validation we just did */
+ CommandCounterIncrement();
+
/*
* If this index is in turn a partition of a larger index, validating it
* might cause the parent to become valid also. Try that.
@@ -17532,9 +17535,6 @@ validatePartitionedIndex(Relation partedIdx, Relation partedTbl)
Relation parentIdx,
parentTbl;
- /* make sure we see the validation we just did */
- CommandCounterIncrement();
-
parentIdxId = get_partition_parent(RelationGetRelid(partedIdx));
parentTblId = get_partition_parent(RelationGetRelid(partedTbl));
parentIdx = relation_open(parentIdxId, AccessExclusiveLock);
diff --git a/src/bin/pg_dump/common.c b/src/bin/pg_dump/common.c
index 1a261a5545..cdfba058fc 100644
--- a/src/bin/pg_dump/common.c
+++ b/src/bin/pg_dump/common.c
@@ -429,6 +429,12 @@ flagInhIndexes(Archive *fout, TableInfo tblinfo[], int numTables)
attachinfo[k].parentIdx = parentidx;
attachinfo[k].partitionIdx = index;
+ /*
+ * We want dependencies from parent to partition (so that the
+ * partition index is created first)
+ */
+ addObjectDependency(&parentidx->dobj, index->dobj.dumpId);
+
/*
* We must state the DO_INDEX_ATTACH object's dependencies
* explicitly, since it will not match anything in pg_depend.
@@ -446,6 +452,8 @@ flagInhIndexes(Archive *fout, TableInfo tblinfo[], int numTables)
*/
addObjectDependency(&attachinfo[k].dobj, index->dobj.dumpId);
addObjectDependency(&attachinfo[k].dobj, parentidx->dobj.dumpId);
+ // addObjectDependency(&parentidx->dobj, attachinfo[k].dobj.dumpId);
+
addObjectDependency(&attachinfo[k].dobj,
index->indextable->dobj.dumpId);
addObjectDependency(&attachinfo[k].dobj,
--
2.17.0
--O5XBE6gyVG5Rl6Rj--
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: New buildfarm animals with FIPS mode enabled
@ 2025-02-17 10:36 Álvaro Herrera <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Álvaro Herrera @ 2025-02-17 10:36 UTC (permalink / raw)
To: Mark Wong <[email protected]>; +Cc: Tom Lane <[email protected]>; [email protected]; [email protected]
Hello,
So in light of this conversation, what to do about the following pending
requests?
pgbfprod=> select format('%s %s', operating_system, os_version) as "OS" from pending();
OS
---------------------------------------------
Ubuntu 20.04.6 LTS (Focal Fossa) FIPS-140
Ubuntu 20.04.6 LTS (Focal Fossa) FIPS-140
Ubuntu 18.04.6 LTS (Bionic Beaver) FIPS-140
As I understand, both of these Ubuntu versions ship with OpenSSL 1.1,
though of course OpenSSL 3 could be installed on them. Should I just
delete these requests?
Thanks
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Los dioses no protegen a los insensatos. Éstos reciben protección de
otros insensatos mejor dotados" (Luis Wu, Mundo Anillo)
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: New buildfarm animals with FIPS mode enabled
@ 2025-02-17 16:10 Mark Wong <[email protected]>
parent: Álvaro Herrera <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Mark Wong @ 2025-02-17 16:10 UTC (permalink / raw)
To: Álvaro Herrera <[email protected]>; +Cc: Tom Lane <[email protected]>; [email protected]; [email protected]
> On Feb 17, 2025, at 2:36 AM, Álvaro Herrera <[email protected]> wrote:
> Hello,
>
> So in light of this conversation, what to do about the following pending
> requests?
>
> pgbfprod=> select format('%s %s', operating_system, os_version) as "OS" from pending();
> OS
> ---------------------------------------------
> Ubuntu 20.04.6 LTS (Focal Fossa) FIPS-140
> Ubuntu 20.04.6 LTS (Focal Fossa) FIPS-140
> Ubuntu 18.04.6 LTS (Bionic Beaver) FIPS-140
>
> As I understand, both of these Ubuntu versions ship with OpenSSL 1.1,
> though of course OpenSSL 3 could be installed on them. Should I just
> delete these requests?
I’m away from my desk until later this week so I don’t recall whether Ubuntu with FIPS is supposed to work. If someone already knows I’m ok with deleting them. Otherwise I will double check soon…
Regards,
Mark
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: New buildfarm animals with FIPS mode enabled
@ 2025-02-17 16:26 Tom Lane <[email protected]>
parent: Mark Wong <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Tom Lane @ 2025-02-17 16:26 UTC (permalink / raw)
To: Mark Wong <[email protected]>; +Cc: Álvaro Herrera <[email protected]>; [email protected]; [email protected]
Mark Wong <[email protected]> writes:
> On Feb 17, 2025, at 2:36 AM, Álvaro Herrera <[email protected]> wrote:
>> As I understand, both of these Ubuntu versions ship with OpenSSL 1.1,
>> though of course OpenSSL 3 could be installed on them. Should I just
>> delete these requests?
> I’m away from my desk until later this week so I don’t recall whether Ubuntu with FIPS is supposed to work. If someone already knows I’m ok with deleting them. Otherwise I will double check soon…
I believe the main concern is OpenSSL 1.x versus 3.x, not a specific
platform.
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: New buildfarm animals with FIPS mode enabled
@ 2025-02-17 19:03 Daniel Gustafsson <[email protected]>
parent: Tom Lane <[email protected]>
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Gustafsson @ 2025-02-17 19:03 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: Mark Wong <[email protected]>; Álvaro Herrera <[email protected]>; pgsql-hackers <[email protected]>; [email protected]
> On 17 Feb 2025, at 17:26, Tom Lane <[email protected]> wrote:
>
> Mark Wong <[email protected]> writes:
>> On Feb 17, 2025, at 2:36 AM, Álvaro Herrera <[email protected]> wrote:
>>> As I understand, both of these Ubuntu versions ship with OpenSSL 1.1,
>>> though of course OpenSSL 3 could be installed on them. Should I just
>>> delete these requests?
>
>> I’m away from my desk until later this week so I don’t recall whether Ubuntu with FIPS is supposed to work. If someone already knows I’m ok with deleting them. Otherwise I will double check soon…
>
> I believe the main concern is OpenSSL 1.x versus 3.x, not a specific
> platform.
Isn't it postgres version mostly? We fixed so the testsuite passed on FIPS
enabled machines by just not using anything that violates FIPS but I don't
remember anything OpenSSL version specific.
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2025-02-17 19:03 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-11-25 23:34 [PATCH v8 8/8] pg_dump: partitioned index depend on its partitions Justin Pryzby <[email protected]>
2025-02-17 10:36 Re: New buildfarm animals with FIPS mode enabled Álvaro Herrera <[email protected]>
2025-02-17 16:10 ` Re: New buildfarm animals with FIPS mode enabled Mark Wong <[email protected]>
2025-02-17 16:26 ` Re: New buildfarm animals with FIPS mode enabled Tom Lane <[email protected]>
2025-02-17 19:03 ` Re: New buildfarm animals with FIPS mode enabled Daniel Gustafsson <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox