Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\))
Subject: Re: ALTER TABLE: warn when actions do not recurse to partitions
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <fb70022a-5403-4e16-9efc-28b041f35d9a@uni-muenster.de>
Date: Fri, 23 Jan 2026 08:11:35 +0800
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 Greg Sabino Mullane <htamfids@gmail.com>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <8ECD9403-F0BB-4971-94CF-2709EEB4E3B9@gmail.com>
References: <CAEoWx2=SLga-xH09Cq_PAvsHhQHrBK+V0vF821JKgzS=Bm0haA@mail.gmail.com>
 <CAKFQuwZXt2dAuHFs6MtRCzfMP6YZFzssuzdW2woJBVmco=CDdQ@mail.gmail.com>
 <CAEoWx2nic2MaPUEKwb0Me1iwO3LsCf8wUHm55pjqaTRgJEZpcQ@mail.gmail.com>
 <CAKFQuwahxpPKT-LXGJ34BO5cVBUxFxzgNPTY8E_VW-cuNU_DkQ@mail.gmail.com>
 <CAEoWx2kQ9aSn-0LGPKc=woj+h-HR4uBV9TL20aeM3HzLmFqgFQ@mail.gmail.com>
 <6eff5e43-cacd-4a2a-ad1d-e3b313c86050@uni-muenster.de>
 <950BB7B5-0180-4C36-82A0-7E17B920F740@gmail.com>
 <CAEoWx2mZsWnyS_XLDL5mL+yuU_g65p_tmHNesyfngqow7gtS3A@mail.gmail.com>
 <fb70022a-5403-4e16-9efc-28b041f35d9a@uni-muenster.de>
To: Jim Jones <jim.jones@uni-muenster.de>
Archived-At: <https://www.postgresql.org/message-id/8ECD9403-F0BB-4971-94CF-2709EEB4E3B9%40gmail.com>
Precedence: bulk


> On Jan 23, 2026, at 03:27, Jim Jones <jim.jones@uni-muenster.de> =
wrote:
>=20
> Hi Chao
>=20
> On 22/01/2026 06:45, Chao Li wrote:
>> evantest=3D# alter table p_test replica identity full, alter column
>> username set (n_distinct =3D 0.1);
>> NOTICE:  ALTER action REPLICA IDENTITY on relation "p_test" does not
>> affect present partitions
>> HINT:  partitions may be modified individually, or specify ONLY to
>> suppress this message
>> NOTICE:  ALTER action ALTER COLUMN ... SET on relation "p_test" does =
not
>> affect present partitions
>> HINT:  partitions may be modified individually, or specify ONLY to
>> suppress this message
>> ALTER TABLE
>=20
>=20
> One could argue that encapsulating all conditions in
> EmitPartitionNoRecurseNotice(), meaning it is called all the time, is
> slightly inefficient, but the impact is really negligible in this case =
-
> and it is how it is done in similar functions in tablecmds.c :) The =
code
> LGTM.

Hi Jim, thanks a lot for the review.

>=20
> One small thing:
>=20
> errhint is supposed to be capitalised - see Error Message Style =
Guide[1]

Thanks for the info, I wasn=E2=80=99t aware of that. When I wrote the =
code, I searched =E2=80=9Cerrhint=E2=80=9D over the source tree, and =
didn=E2=80=99t find a standard to follow.

>=20
> "Detail and hint messages: Use complete sentences, and end each with a
> period. Capitalize the first word of sentences. Put two spaces after =
the
> period if another sentence follows (for English text; might be
> inappropriate in other languages)."
>=20
> ereport(NOTICE,
> errmsg("ALTER action %s on relation \"%s\" does not affect present
> partitions",
>   action_str,
>   RelationGetRelationName(rel)),
> errhint("partitions may be modified individually, or specify ONLY to
> suppress this message"));
>=20
> What about this?
>=20
> HINT: To update partitions, apply the command to each one =
individually,
> or specify ONLY to suppress this message.

Looks good. I will integrate your edit to the next version.

>=20
> I'll test the newly covered subcomands tomorrow.

Thanks again for testing. I will wait to see the test results and =
address all issues together in next version.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/