Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\))
Subject: Re: Rename setup_cancel_handler in pg_dump
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <20240126094245.cf6718cc659273765f3ab69a@sraoss.co.jp>
Date: Tue, 30 Jan 2024 13:44:28 +0100
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <8F0B5F18-59FE-46F0-8270-C7B4B6C342EB@yesql.se>
References: <20240126094245.cf6718cc659273765f3ab69a@sraoss.co.jp>
To: Yugo NAGATA <nagata@sraoss.co.jp>
Archived-At: 
 <https://www.postgresql.org/message-id/8F0B5F18-59FE-46F0-8270-C7B4B6C342EB%40yesql.se>
Precedence: bulk

> On 26 Jan 2024, at 01:42, Yugo NAGATA <nagata@sraoss.co.jp> wrote:

> I am proposing it because there is a public function with
> the same name in fe_utils/cancel.c. I know pg_dump/parallel.c
> does not include fe_utils/cancel.h, so there is no conflict,
> but I think it is better to use different names to reduce
> possible confusion.=20

Given that a "git grep setup_cancel_hander" returns hits in pg_dump =
along with
other frontend utils, I can see the risk of confusion.

-setup_cancel_handler(void)
+pg_dump_setup_cancel_handler(void)

We don't have any other functions prefixed with pg_dump_, based on the =
naming
of the surrounding code in the file I wonder if set_cancel_handler is a =
more
appropriate name?

--
Daniel Gustafsson