Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: Granting SET and ALTER SYSTE privileges for GUCs
From: Mark Dilger <mark.dilger@enterprisedb.com>
In-Reply-To: <2347082.1637100769@sss.pgh.pa.us>
Date: Tue, 16 Nov 2021 14:45:12 -0800
Cc: Andrew Dunstan <andrew@dunslane.net>,
 Robert Haas <robertmhaas@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <8F320DC8-C312-40C0-AF41-7B3D8F21584A@enterprisedb.com>
References: <3D691E20-C1D5-4B80-8BA5-6BEB63AF3029@enterprisedb.com>
 <CA+TgmobaKUYZhfXs-7kHjsmDmkcttH7-r9E2BJXUHtv9mkUUcw@mail.gmail.com>
 <2226110.1637075835@sss.pgh.pa.us>
 <CA+TgmoYWqjpHEogdCEbRwzUb5ZoEaUt8ciNUXFCwLZDWBe+_BA@mail.gmail.com>
 <2226903.1637076537@sss.pgh.pa.us>
 <A6157072-B564-4171-8599-068C8D65BE9C@enterprisedb.com>
 <2231899.1637081047@sss.pgh.pa.us>
 <38BEC583-DB34-4918-BCBC-DC896F0D3844@enterprisedb.com>
 <055d86ff-9c95-f1d4-c974-29896767561e@dunslane.net>
 <7DFFECF0-373B-40B0-BCA0-A5ADD9266FFA@enterprisedb.com>
 <2347082.1637100769@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/8F320DC8-C312-40C0-AF41-7B3D8F21584A%40enterprisedb.com>
Precedence: bulk


> On Nov 16, 2021, at 2:12 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> BTW, another objection to pg_config_param as designed here is that
> a "name" is not an appropriate way to store possibly-qualified
> custom GUC names.  It's not long enough (cf. =
valid_custom_variable_name).

I was aware of that, but figured not all GUCs have to be grantable.  If =
it doesn't fit in a NameData, you can't grant on it.

If we want to be more accommodating than that, we can store it as text, =
just like pg_db_role_names does, but then we need more code complexity =
to look it up and to verify that it is unique.  (We wouldn't want =
multiple records for the same <role,guc> pair.)=20

=E2=80=94
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company