Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wKKIQ-000r8L-1F for pgsql-hackers@arkaria.postgresql.org; Tue, 05 May 2026 18:15:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wKKIP-00DFa3-0d for pgsql-hackers@arkaria.postgresql.org; Tue, 05 May 2026 18:15:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wKKIO-00DFZt-2Z for pgsql-hackers@lists.postgresql.org; Tue, 05 May 2026 18:15:00 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wKKIL-00000000M18-1yvt for pgsql-hackers@postgresql.org; Tue, 05 May 2026 18:14:59 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 01D895ED13F for ; Tue, 05 May 2026 20:14:54 +0200 (CEST) Received: from s980.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id E72175ED13E; Tue, 05 May 2026 20:14:53 +0200 (CEST) Received: from localhost (unknown [172.22.191.5]) by s980.loopia.se (Postfix) with ESMTP id E0D082201651; Tue, 05 May 2026 20:14:53 +0200 (CEST) X-Virus-Scanned: amavis at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s471.loopia.se (amavis); dkim=pass (2048-bit key) header.d=proxel.se Received: from s934.loopia.se ([172.22.191.6]) by localhost (s471.loopia.se [172.22.190.35]) (amavis, port 10024) with LMTP id pDaN5upuBa5w; Tue, 5 May 2026 20:14:53 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: andreas@proxel.se X-Loopia-Originating-IP: 147.28.75.140 Received: from [192.168.0.121] (customer-147-28-75-140.stosn.net [147.28.75.140]) (Authenticated sender: andreas@proxel.se) by s934.loopia.se (Postfix) with ESMTPSA id 6A139917F0B; Tue, 05 May 2026 20:14:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proxel.se; s=loopiadkim1707418970; t=1778004893; bh=jCorz4Rx+Rwb5sfK9I8ahpsf/SAG6SIGA30iFsoeO08=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=T7Pz+JC1LTFutm/6Uu6Og1vhKH1qQxD81vAlervmPg3B9lJKuKo1gwjJEvawI00s6 w6H5wt+fnd/irIFCKyvl3ighkwDInuc1KAQ/vb7rcjFek/I846suUD7ytJPIHWxyAz rqgP9X+8jckWXpth56g6M+yVfRqq7QkSAOSdnLnBObWpMX/iVTXTO1IZ6DIKueAzsL /v6wzMXyaep1Zso526/WL1y51UquKp551zepSRE6fBF2j6o2+qElIfL9K23VeBAkbG a4/JchDFbnjoIQMNu2ZWN1zas+FypKk9p2L+16vfRXBiNBax8pMjOjyc+RPUCF1Znr sIcGvuYBIGZPQ== Message-ID: <8a75291c-580d-42d6-9ae9-8d3b84b54b72@proxel.se> Date: Tue, 5 May 2026 20:14:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Improve pgindent's formatting named fields in struct literals and varidic functions To: Tom Lane Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= , Jelte Fennema-Nio , pgsql-hackers References: <202603311716.cribie6xvxhn@alvherre.pgsql> <2737243.1774980800@sss.pgh.pa.us> <9a949301-eb31-4245-aef5-6ced20716ec4@proxel.se> <71e9889c-86be-4084-a5ae-fc535221b5fb@proxel.se> <664781.1778004610@sss.pgh.pa.us> From: Andreas Karlsson Content-Language: en-US In-Reply-To: <664781.1778004610@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 5/5/26 8:10 PM, Tom Lane wrote: > I've reviewed and tested this, and attached is the version I have > staged for commit. Differences from yours: Thanks! > * Bump pg_bsd_indent's version number to ensure people use the > right version. Sounds good. > * Include the change in tests/declarations.0.stdout in the main > patch. Without this, "make check-world" fails after that patch. > We don't want to create land-mines like that for future git > bisect runs. Thanks for fixing that! -- Andreas Karlsson Percona