Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHPgv-0000vK-14 for pgsql-hackers@arkaria.postgresql.org; Fri, 29 Jul 2022 13:06:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oHPgt-0001Az-H6 for pgsql-hackers@arkaria.postgresql.org; Fri, 29 Jul 2022 13:06:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHPgt-0001Ao-7F for pgsql-hackers@lists.postgresql.org; Fri, 29 Jul 2022 13:06:07 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHPgl-0006pC-Vz for pgsql-hackers@postgresql.org; Fri, 29 Jul 2022 13:06:06 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 8E725608BE for ; Fri, 29 Jul 2022 22:05:56 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.6 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_47bcc1aca81eff93839e7821f49485d7" Content-Transfer-Encoding: 7bit Date: Fri, 29 Jul 2022 22:05:56 +0900 From: torikoshia To: Pgsql Hackers Subject: Should fix a comment referring to stats collector? User-Agent: Roundcube Webmail/1.4.11 Message-ID: <8a82417cdb6e8038fe276d4960e3207a@oss.nttdata.com> X-Sender: torikoshia@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_47bcc1aca81eff93839e7821f49485d7 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi, Statistics collector has been removed since 5891c7a8ed8f2d3d5, but there was a comment referring 'statistics collector' in pg_statistic.h. > Note that since the arrays are variable-size, K may be chosen by the > statistics collector. Should it be modified to 'cumulative statistics system' like manual on monitoring stats[1]? Its title has changed from 'statistics collector' to 'cumulative statistics system'. [1] https://www.postgresql.org/docs/current/monitoring-stats.html -- Regards, -- Atsushi Torikoshi NTT DATA CORPORATION --=_47bcc1aca81eff93839e7821f49485d7 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=v1-0001-Modified-a-comment-referring-to-stats-collector.patch Content-Disposition: attachment; filename=v1-0001-Modified-a-comment-referring-to-stats-collector.patch; size=1536 RnJvbSA1YmU3ODQyNzhlOGU3YWVlZWFkZjYwYTc3MmFmY2NkYTdiNTllNmU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBdHN1c2hpIFRvcmlrb3NoaSA8dG9yaWtvc2hpYUBvc3MubnR0 ZGF0YS5jb20+CkRhdGU6IEZyaSwgMjkgSnVsIDIwMjIgMjE6MzQ6MTUgKzA5MDAKU3ViamVjdDog W1BBVENIIHYxXSBNb2RpZmllZCBhIGNvbW1lbnQgcmVmZXJyaW5nIHRvIHN0YXRzIGNvbGxlY3Rv ci4KCkFzIHN0YXRpc3RpY3MgY29sbGVjdG9yIGhhcyBiZWVuIHJlbW92ZWQgc2luY2UgNTg5MWM3 YThlZDhmMmQzZDUsCmNvbW1lbnRzIHJlZmVyaW5nIHRvIHN0YXRpc3RpY3MgY29sbGVjdG9yIHNo b3VsZCBiZSBtb2RpZmllZCB0bwpjdW11bGF0aXZlIHN0YXRpc3RpY3Mgc3lzdGVtLgotLS0KIHNy Yy9pbmNsdWRlL2NhdGFsb2cvcGdfc3RhdGlzdGljLmggfCA2ICsrKy0tLQogMSBmaWxlIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvaW5j bHVkZS9jYXRhbG9nL3BnX3N0YXRpc3RpYy5oIGIvc3JjL2luY2x1ZGUvY2F0YWxvZy9wZ19zdGF0 aXN0aWMuaAppbmRleCBjZGY3NDQ4MTM5Li5kMDdmZDJmOTNmIDEwMDY0NAotLS0gYS9zcmMvaW5j bHVkZS9jYXRhbG9nL3BnX3N0YXRpc3RpYy5oCisrKyBiL3NyYy9pbmNsdWRlL2NhdGFsb2cvcGdf c3RhdGlzdGljLmgKQEAgLTE3OCw5ICsxNzgsOSBAQCBERUNMQVJFX0ZPUkVJR05fS0VZKChzdGFy ZWxpZCwgc3RhYXR0bnVtKSwgcGdfYXR0cmlidXRlLCAoYXR0cmVsaWQsIGF0dG51bSkpOwogICog dGhlIEsgbW9zdCBjb21tb24gbm9uLW51bGwgdmFsdWVzIGFwcGVhcmluZyBpbiB0aGUgY29sdW1u LCBhbmQgc3RhbnVtYmVycwogICogY29udGFpbnMgdGhlaXIgZnJlcXVlbmNpZXMgKGZyYWN0aW9u cyBvZiB0b3RhbCByb3cgY291bnQpLiAgVGhlIHZhbHVlcwogICogc2hhbGwgYmUgb3JkZXJlZCBp biBkZWNyZWFzaW5nIGZyZXF1ZW5jeS4gIE5vdGUgdGhhdCBzaW5jZSB0aGUgYXJyYXlzIGFyZQot ICogdmFyaWFibGUtc2l6ZSwgSyBtYXkgYmUgY2hvc2VuIGJ5IHRoZSBzdGF0aXN0aWNzIGNvbGxl Y3Rvci4gIFZhbHVlcyBzaG91bGQKLSAqIG5vdCBhcHBlYXIgaW4gTUNWIHVubGVzcyB0aGV5IGhh dmUgYmVlbiBvYnNlcnZlZCB0byBvY2N1ciBtb3JlIHRoYW4gb25jZTsKLSAqIGEgdW5pcXVlIGNv bHVtbiB3aWxsIGhhdmUgbm8gTUNWIHNsb3QuCisgKiB2YXJpYWJsZS1zaXplLCBLIG1heSBiZSBj aG9zZW4gYnkgdGhlIGN1bXVsYXRpdmUgc3RhdGlzdGljcyBzeXN0ZW0uCisgKiBWYWx1ZXMgc2hv dWxkIG5vdCBhcHBlYXIgaW4gTUNWIHVubGVzcyB0aGV5IGhhdmUgYmVlbiBvYnNlcnZlZCB0byBv Y2N1cgorICogbW9yZSB0aGFuIG9uY2U7IGEgdW5pcXVlIGNvbHVtbiB3aWxsIGhhdmUgbm8gTUNW IHNsb3QuCiAgKi8KICNkZWZpbmUgU1RBVElTVElDX0tJTkRfTUNWCTEKIAoKYmFzZS1jb21taXQ6 IDU5YmUxYzk0MmE0N2Y2YzhhNGM0N2QyNDIyMDBmYmJmNGJlNTliODgKLS0gCjIuMjcuMAoK --=_47bcc1aca81eff93839e7821f49485d7--