Message-ID: <8a903769-f399-e840-274f-1ddf7a178617@gmx.de>
Date: Tue, 28 Mar 2023 12:17:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: doc: add missing "id" attributes to extension packaging page
To: Peter Smith <smithpb2250@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, "Karl O. Pinc"
 <kop@karlpinc.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 Tom Lane <tgl@sss.pgh.pa.us>, vignesh C <vignesh21@gmail.com>,
 Ian Lawrence Barwick <barwick@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <20230323093555.3icw7zetwtmtrrzu@alvherre.pgsql>
 <a41ed60d-2f95-da52-ba8b-b0b1cc37f3a4@gmx.de>
 <5a07674a-ab36-3924-7e35-52981c6d4882@gmx.de>
 <CAHut+Pvvi+dyXb-Gr56dD9xJrckEvopORFmbYr17_GxhekuWtA@mail.gmail.com>
Content-Language: de-DE
From: Brar Piening <brar@gmx.de>
In-Reply-To: <CAHut+Pvvi+dyXb-Gr56dD9xJrckEvopORFmbYr17_GxhekuWtA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:xbsA52Jfdzk=;n88E+E57+Dmbw1dw8nRhFSULM4g
 X6zDVAUJVYvFRwtPox3zqCWLBLO2oYQVq5Fq0bewyRylHYUowT3yrAfk4T+0RIb+CLA3n7EBJ
 IlrrHLdohPrBWPUe6lL0HYC2AXP0YZNf6RoSZ9I6qEgf/2/S+2MT9Zg6rqHxO1NOeD6ZHckSU
 +Rn4lhSBYzMj6vPcd3ZUKX4seHVpSL+LI2MJ9pzj/0chZH2qWopdGBrNA5aEou5vpyVgxu3JM
 rghHwC/bU6DrCSr6qDGY0seO6dBBJTIpb5Pl+NVkqCHQKyj0I5bE7RkZIFS4GnQiaZfB6MmBn
 Kr9bmrie5gEk5xHeyRojvwK5rwQnboJVbCkasFsh/6wBHpLR3YP2/shaTj42PopRx8jGu9x5n
 hNm4HZNBSIi8pOVKUJTes10G4tsCaspMd5KTGFb7OwoSUZlWwawio9XfRnUo2jFV1pgf0wUBP
 NCMFi5y7O84wOYVE0lGbvvXKb8hEkW80LcbNTUlhvbTp8xqq09s6+fEeKwRzfcYv3tKF9jWFh
 HkFYLXvZQ5uzzdiHjMN3ONqSkTcNGeYDV0UkGCoaDVoyi0R1KmTzdZXH+YyKGR0KYXJipGErP
 WPDntGo1QwfyJvmgDqiyqb7a04R6MkQp4sZaB4ZVzthmbWa/d31I0Q28IjjhxjYhCYvgavX0R
 43Cq6DpJoXCNFYfTkyFB8VKhjLW93FcSxqJkqvMBSEr/oSDXuYneF0iksIvs+G3c2cWpUwcik
 hksQzgKluMRdxMMl9CE3PrrxFCpR1Zn5pRpxFahbEbHdofOnaRdOCwf5jFCQO2yC8S53QCK6f
 Ngy2FRw/rZ3BM9SMBgQpWO/fWSOYY/KJkiJuZG6Q63jB3Bln0MWHznuQWMnLOXIqqFrHASvdv
 ju6AL1IGbQAE+YzU3ZAGm6SKCpjK4CKuqsheoS1TCcRLK48u3ISipuLb6XcUbH7dXbnkyTIL6
 yQqoHA==
Archived-At: <https://www.postgresql.org/message-id/8a903769-f399-e840-274f-1ddf7a178617%40gmx.de>
Precedence: bulk

On 28.03.2023 at 00:11, Peter Smith wrote:
> FYI, there is a lot of overlap between this last attachment and the
> patches of Kuroda-san's current thread here [1] which is also adding
> ids to create_subscription.sgml.
>
> (Anyway, I guess you might already be aware of that other thread
> because your new ids look like they have the same names as those
> chosen by Kuroda-san)
>
> ------
> [1] https://www.postgresql.org/message-id/flat/CAHut%2BPvzo6%3DKKLqMR6-m=
AQdM%2Bj_dse0eUreGmrFouL7gbLbv2w%40mail.gmail.com#7da8d0e3b73096375847c16c=
856b4aed

Thanks, I actually was not aware of this.

Also, kudos for capturing the missing id and advocating for consistency
regarding ids even before this is actively enforced. This nurtures my
optimism that consistency might actually be achieveable without
everybody getting angry at me because my patch will enforce it.

Regarding the overlap, I currently try to make it as easy as possible
for a potential committer and I'm happy to rebase my patch upon request
or if Kuroda-san's patch gets applied first.

Regards,

Brar