Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYdCh-00078Y-OR for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Sep 2022 00:58:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oYdCe-00037c-JC for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Sep 2022 00:58:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYdCe-00037T-AV for pgsql-hackers@lists.postgresql.org; Thu, 15 Sep 2022 00:58:04 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYdCa-0005C1-OM for pgsql-hackers@postgresql.org; Thu, 15 Sep 2022 00:58:03 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 752766079E; Thu, 15 Sep 2022 09:57:55 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.7 at oss.nttdata.com MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 15 Sep 2022 09:57:55 +0900 From: Shinya Kato To: bt22kawamotok Cc: Fujii Masao , pgsql-hackers@postgresql.org Subject: Re: [PATCH]Feature improvement for MERGE tab completion In-Reply-To: <8f1bd2324f335b27a9a7c84562e2a90b@oss.nttdata.com> References: <9f1ad2a87a58cd5e7d64f3993130958d@oss.nttdata.com> <359a46c295eae938d84552c11818ab62@oss.nttdata.com> <7d7eef0f596e449746766ff4fb7c9061@oss.nttdata.com> <6c943aa7b6064b56e7ebeb901f7c24b4@oss.nttdata.com> <5b2e2880da33f6356931beb5c0d68c84@oss.nttdata.com> <23586a9b-8978-61dc-0531-03acff3a7b90@oss.nttdata.com> <8f1bd2324f335b27a9a7c84562e2a90b@oss.nttdata.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <8ab5557f41c17cbceecc6a131023a775@oss.nttdata.com> X-Sender: Shinya11.Kato@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-09-14 18:12, bt22kawamotok wrote: > I fixed it in v6. Thanks for updating. + COMPLETE_WITH("UPDATE", "DELETE", "DO NOTHING"); "UPDATE" is always followed by "SET", so why not complement it with "UPDATE SET"? -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION