Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1st0yj-00CiDz-5u for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Sep 2024 08:33:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1st0yh-004gys-QR for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Sep 2024 08:32:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1st0yh-004gyj-GJ for pgsql-hackers@lists.postgresql.org; Tue, 24 Sep 2024 08:32:59 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1st0ya-000mIV-KS for pgsql-hackers@lists.postgresql.org; Tue, 24 Sep 2024 08:32:58 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 51C1761B75 for ; Tue, 24 Sep 2024 17:32:48 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_322a945fb5a40bd36613d5c3ccc70095" Content-Transfer-Encoding: 7bit Date: Tue, 24 Sep 2024 17:32:48 +0900 From: btnakamurakoukil To: pgsql-hackers@lists.postgresql.org Subject: index_delete_sort: Unnecessary variable "low" is used in heapam.c User-Agent: Roundcube Webmail/1.4.11 Message-ID: <8aeb7b3eda53ca4c65fbacf8f43628fb@oss.nttdata.com> X-Sender: btnakamurakoukil@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_322a945fb5a40bd36613d5c3ccc70095 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi hackers, I noticed unnecessary variable "low" in index_delete_sort() (/postgres/src/backend/access/heap/heapam.c), patch attached. What do you think? Regards, Koki Nakamura --=_322a945fb5a40bd36613d5c3ccc70095 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Delete-low.patch Content-Disposition: attachment; filename=0001-Delete-low.patch; size=1023 RnJvbSBjMGJmN2Y4NDY4Y2IwZTRmNzRjNDFlNDM0YWRmNzBiZGJmYjNhZDZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLb2tpTmFrYSA8YnRuYWthbXVyYWtvdWtpbEBvc3MubnR0ZGF0 YS5jb20+CkRhdGU6IFR1ZSwgMjQgU2VwIDIwMjQgMTA6NDY6MDkgKzA5MDAKU3ViamVjdDogW1BB VENIXSBEZWxldGUgbG93CgotLS0KIHNyYy9iYWNrZW5kL2FjY2Vzcy9oZWFwL2hlYXBhbS5jIHwg MyArLS0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9zcmMvYmFja2VuZC9hY2Nlc3MvaGVhcC9oZWFwYW0uYyBiL3NyYy9iYWNrZW5k L2FjY2Vzcy9oZWFwL2hlYXBhbS5jCmluZGV4IGYxNjcxMDcyNTcuLjY0OTUzNTQxY2QgMTAwNjQ0 Ci0tLSBhL3NyYy9iYWNrZW5kL2FjY2Vzcy9oZWFwL2hlYXBhbS5jCisrKyBiL3NyYy9iYWNrZW5k L2FjY2Vzcy9oZWFwL2hlYXBhbS5jCkBAIC03OTQwLDcgKzc5NDAsNiBAQCBpbmRleF9kZWxldGVf c29ydChUTV9JbmRleERlbGV0ZU9wICpkZWxzdGF0ZSkKIHsKIAlUTV9JbmRleERlbGV0ZSAqZGVs dGlkcyA9IGRlbHN0YXRlLT5kZWx0aWRzOwogCWludAkJCW5kZWx0aWRzID0gZGVsc3RhdGUtPm5k ZWx0aWRzOwotCWludAkJCWxvdyA9IDA7CiAKIAkvKgogCSAqIFNoZWxsc29ydCBnYXAgc2VxdWVu Y2UgKHRha2VuIGZyb20gU2VkZ2V3aWNrLUluY2VycGkgcGFwZXIpLgpAQCAtNzk1Niw3ICs3OTU1 LDcgQEAgaW5kZXhfZGVsZXRlX3NvcnQoVE1fSW5kZXhEZWxldGVPcCAqZGVsc3RhdGUpCiAKIAlm b3IgKGludCBnID0gMDsgZyA8IGxlbmd0aG9mKGdhcHMpOyBnKyspCiAJewotCQlmb3IgKGludCBo aSA9IGdhcHNbZ10sIGkgPSBsb3cgKyBoaTsgaSA8IG5kZWx0aWRzOyBpKyspCisJCWZvciAoaW50 IGhpID0gZ2Fwc1tnXSwgaSA9IGhpOyBpIDwgbmRlbHRpZHM7IGkrKykKIAkJewogCQkJVE1fSW5k ZXhEZWxldGUgZCA9IGRlbHRpZHNbaV07CiAJCQlpbnQJCQlqID0gaTsKLS0gCjIuNDAuMQoK --=_322a945fb5a40bd36613d5c3ccc70095--