Content-Type: multipart/alternative;
 boundary="------------CHJRVcuGBYvHSDnaPi2ngz16"
Message-ID: <8b2f3c20-02ac-4658-b78f-e9d7590f893b@postgrespro.ru>
Date: Wed, 16 Oct 2024 14:01:55 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Vacuum statistics
To: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: jian he <jian.universality@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>, Andrei Zubkov
 <zubkov@moonset.ru>, Alena Rybakina <lena.ribackina@yandex.ru>,
 a.lepikhov@postgrespro.ru
References: <bee34abe-fe87-49b3-8523-8ae19e641ccf@yandex.ru>
 <ff99283d-f9d4-4b37-b4fa-3a433fb408a4@tantorlabs.com>
 <e1f5b560691a4fe693625d529e19e13959210568.camel@moonset.ru>
 <53c47c2d-72a5-44f2-900c-9973b2af1808@tantorlabs.com>
 <c82e7776-7841-42a0-9247-878584174750@tantorlabs.com>
 <4a902cea-54fb-41b5-b208-b84731a5f577@postgrespro.ru>
 <CACJufxHb_YGCp=pVH6DZcpk9yML+SueffPeaRbX2LzXZVahd_w@mail.gmail.com>
 <CACJufxE6yAP+jUm4_GyKp7gUCkzbuJ9HGB-rR=92_hcLLZ9KTg@mail.gmail.com>
 <092adec6-4eae-4bd4-bd0d-473a9df1282b@tantorlabs.com>
 <3deae1bd-ad84-4459-a26e-04c9136b84e9@postgrespro.ru>
 <CAPpHfdug0s2MD7bBf-5nDQGn1WBxCKiTmZyGfxHz_7P0CDOjbg@mail.gmail.com>
 <c4e4e305-7119-4183-b49a-d7092f4efba3@postgrespro.ru>
 <f05a9031-f923-41b1-9bf9-81204cb56561@postgrespro.ru>
 <CACJufxFU4ej3iGtGg3GDqmGzRmTVq3d9RGq+ibLfQoS8E3hJEQ@mail.gmail.com>
 <9b10c6d3-52c4-4eef-b67c-c33442667729@postgrespro.ru>
 <30e2e941-b9f6-4ea1-aa3b-f0c406b8797d@postgrespro.ru>
 <1a960398-d12d-419a-af48-4acfe58d0c3a@tantorlabs.com>
Content-Language: en-US
From: Alena Rybakina <a.rybakina@postgrespro.ru>
In-Reply-To: <1a960398-d12d-419a-af48-4acfe58d0c3a@tantorlabs.com>
Archived-At: <https://www.postgresql.org/message-id/8b2f3c20-02ac-4658-b78f-e9d7590f893b%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------CHJRVcuGBYvHSDnaPi2ngz16
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi!

On 16.10.2024 13:31, Ilia Evdokimov wrote:
>
>
> On 08.10.2024 19:18, Alena Rybakina wrote:
>> Made a rebase on a fresh master branch.
>> -- 
>> Regards,
>> Alena Rybakina
>> Postgres Professional
>
> Thank you for rebasing.
>
> I have noticed that when I create a table or an index on this table, 
> there is no information about the table or index in 
> pg_stat_vacuum_tables and pg_stat_vacuum_indexes until we perform a 
> VACUUM.
>
> Example:
>
> CREATE TABLE t (i INT, j INT);
> INSERT INTO t SELECT i/10, i/100 FROM GENERATE_SERIES(1,1000000) i;
> SELECT * FROM pg_stat_vacuum_tables WHERE relname = 't';
> ....
> (0 rows)
> CREATE INDEX ON t (i);
> SELECT * FROM pg_stat_vacuum_indexes WHERE relname = 't_i_idx';
> ...
> (0 rows)
>
> I can see the entries after running VACUUM or executing autovacuum. or 
> when autovacuum is executed. I would suggest adding a line about the 
> relation even if it has not yet been processed by 
> vacuum. Interestingly, this issue does not occur with 
> pg_stat_vacuum_database:
>
> CREATE DATABASE example_db;
> SELECT * FROM pg_stat_vacuum_database WHERE dbname = 'example_db';
> dboid |       dbname | ...
>  ...      | example_db | ...
> (1 row)
>
> BTW, I recommend renaming the view pg_stat_vacuum_database to 
> pg_stat_vacuum_database_S_  for consistency with pg_stat_vacuum_tables 
> and pg_stat_vacuum_indexes
>
Thanks for the review. I'm investigating this. I agree with the 
renaming, I will do it in the next version of the patch.

-- 
Regards,
Alena Rybakina
Postgres Professional

--------------CHJRVcuGBYvHSDnaPi2ngz16
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Hi!<br>
    </p>
    <div class="moz-cite-prefix">On 16.10.2024 13:31, Ilia Evdokimov
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:1a960398-d12d-419a-af48-4acfe58d0c3a@tantorlabs.com">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      <p><br>
      </p>
      <div class="moz-cite-prefix">On 08.10.2024 19:18, Alena Rybakina
        wrote:<br>
      </div>
      <blockquote type="cite"
        cite="mid:30e2e941-b9f6-4ea1-aa3b-f0c406b8797d@postgrespro.ru">
        <meta http-equiv="Content-Type"
          content="text/html; charset=UTF-8">
        <pre class="tw-data-text tw-text-large tw-ta"
        data-placeholder="Перевод" id="tw-target-text"
        style="text-align:left"
        data-ved="2ahUKEwj_y7mqiv-IAxUAFxAIHZ3EMlIQ3ewLegQIBxAV"
        dir="ltr"
aria-label="Переведенный текст: Made a rebase on a fresh master branch"><span
        class="Y2IQFc" lang="en">Made a rebase on a fresh master branch.</span></pre>
        <pre class="moz-signature" cols="72">-- 
Regards,
Alena Rybakina
Postgres Professional</pre>
      </blockquote>
      <p>Thank you for rebasing.</p>
      <p>I have noticed that when I create a table or an index on this
        table, there is no information about the table or index in
        pg_stat_vacuum_tables and pg_stat_vacuum_indexes until we
        perform a VACUUM.</p>
      <p>Example:</p>
      <p>CREATE TABLE t (i INT, j INT);<br>
        INSERT INTO t SELECT i/10, i/100 FROM 
        GENERATE_SERIES(1,1000000) i;<br>
        SELECT * FROM pg_stat_vacuum_tables WHERE relname = 't';<br>
        ....<br>
        (0 rows)<br>
        CREATE INDEX ON t (i);<br>
        SELECT * FROM pg_stat_vacuum_indexes WHERE relname = 't_i_idx';<br>
        ...<br>
        (0 rows)</p>
      <p>I can see the entries after running VACUUM or executing
        autovacuum. or when autovacuum is executed. I would suggest
        adding a line about the relation even if it has not yet been
        processed by vacuum. Interestingly, this issue does not occur
        with pg_stat_vacuum_database:</p>
      <p>CREATE DATABASE example_db;<br>
        SELECT * FROM pg_stat_vacuum_database WHERE dbname =
        'example_db';<br>
        dboid |       dbname | ...<br>
         ...      | example_db | ...<br>
        (1 row)<br>
        <br>
        BTW, I recommend renaming the view pg_stat_vacuum_database to
        pg_stat_vacuum_database<u>S</u>  for consistency with
        pg_stat_vacuum_tables and pg_stat_vacuum_indexes</p>
    </blockquote>
    <p>Thanks for the review. I'm investigating this. I agree with the
      renaming, I will do it in the next version of the patch.<br>
    </p>
    <pre class="moz-signature" cols="72">-- 
Regards,
Alena Rybakina
Postgres Professional</pre>
  </body>
</html>

--------------CHJRVcuGBYvHSDnaPi2ngz16--