Message-ID: <8b587a55-148f-4cb4-8941-8fed282625a9@proxel.se>
Date: Sat, 4 Apr 2026 01:15:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [doc] pg_ctl: fix wrong description for -l
To: =?UTF-8?B?S3Vyb2RhLCBIYXlhdG8v6buS55SwIOmavOS6ug==?=
 <kuroda.hayato@fujitsu.com>,
 "'pgsql-hackers@lists.postgresql.org'" <pgsql-hackers@lists.postgresql.org>
References: 
 <OS9PR01MB1214959BE987B4839E3046050F54BA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
From: Andreas Karlsson <andreas@proxel.se>
Content-Language: en-US
In-Reply-To: 
 <OS9PR01MB1214959BE987B4839E3046050F54BA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/8b587a55-148f-4cb4-8941-8fed282625a9%40proxel.se>
Precedence: bulk

On 3/23/26 11:55 AM, Kuroda, Hayato/黒田 隼人 wrote:
> ```
> -l filename
> --log=filename
> Append the server log output to filename. If the file does not exist, it is created. The umask is set to 077, so access to the log file is disallowed to other users by default.
> ```
> 
> But users who are in the same group can also see the log if group permissions are
> enabled on the data directory. It was extended by c37b3d0 but updating the doc seemed
> to be missed. Attached patch can fix the issue.

Thanks for the patch.

Nicely spotted, but I am not sure I am a fan of the new text. Shouldn't 
we still mention that "If the file does not exist, it is created."? Also 
I think the last sentence would flow better as:

Access to the log file is disallowed to other users by default, but 
users in the same group can also read it if group permissions are 
enabled on the data directory.

Best regards,
Andreas

-- 
Andreas Karlsson
Percona