pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feed[PATCH] fix typo in commit a4523c5
2+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2017-01-18 1586317c3f 692a70427a b60f9820fb 6290f8e966 22b4b55b99 154875a77b Reset the proper GUC in create_index test.
* [PATCH] fix typo in commit a4523c5
@ 2017-01-18 20:01 Nikita Glukhov <n.gluhov@postgrespro.ru>
2017-01-18 21:34 ` Re: [PATCH] fix typo in commit a4523c5 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 2+ messages in thread
From: Nikita Glukhov @ 2017-01-18 20:01 UTC (permalink / raw)
To: pgsql-hackers
Attached patch fixes typo in regression test src/test/regress/sql/create_index.sql
that was introduced in commit a4523c5
("Improve planning of btree index scans using ScalarArrayOpExpr quals.").
In this commit the following lines were added to create_index.sql:
SET enable_indexonlyscan = OFF;
...
RESET enable_indexscan;
Obviously, the last line should be
RESET enable_indexonlyscan;
--
Nikita Glukhov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
fix-typo-in-commit-a4523c5.patch (text/x-patch, 871B) download
diff --git a/src/test/regress/expected/create_index.out b/src/test/regress/expected/create_index.out
index c6dfb26..e519fdb 100644
--- a/src/test/regress/expected/create_index.out
+++ b/src/test/regress/expected/create_index.out
@@ -2940,7 +2940,7 @@ ORDER BY thousand;
1 | 1001
(2 rows)
-RESET enable_indexscan;
+RESET enable_indexonlyscan;
--
-- Check elimination of constant-NULL subexpressions
--
diff --git a/src/test/regress/sql/create_index.sql b/src/test/regress/sql/create_index.sql
index 822c34a..1648072 100644
--- a/src/test/regress/sql/create_index.sql
+++ b/src/test/regress/sql/create_index.sql
@@ -1001,7 +1001,7 @@ SELECT thousand, tenthous FROM tenk1
WHERE thousand < 2 AND tenthous IN (1001,3000)
ORDER BY thousand;
-RESET enable_indexscan;
+RESET enable_indexonlyscan;
--
-- Check elimination of constant-NULL subexpressions
* Re: [PATCH] fix typo in commit a4523c5
2017-01-18 20:01 [PATCH] fix typo in commit a4523c5 Nikita Glukhov <n.gluhov@postgrespro.ru>
@ 2017-01-18 21:34 ` Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 2+ messages in thread
From: Tom Lane @ 2017-01-18 21:34 UTC (permalink / raw)
To: Nikita Glukhov <n.gluhov@postgrespro.ru>; +Cc: pgsql-hackers
Nikita Glukhov <n.gluhov@postgrespro.ru> writes:
> Obviously, the last line should be
> RESET enable_indexonlyscan;
Yeah, I think you're right. Pushed, thanks!
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2017-01-18 21:34 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-01-18 20:01 [PATCH] fix typo in commit a4523c5 Nikita Glukhov <n.gluhov@postgrespro.ru>
2017-01-18 21:34 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox