Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1Xym-0002YW-BM for pgsql-hackers@arkaria.postgresql.org; Fri, 21 Apr 2017 12:48:04 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d1Xyl-0006zB-Pn for pgsql-hackers@arkaria.postgresql.org; Fri, 21 Apr 2017 12:48:03 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d1Xx7-00042d-ML for pgsql-hackers@postgresql.org; Fri, 21 Apr 2017 12:46:21 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d1Xx4-000873-8I for pgsql-hackers@postgresql.org; Fri, 21 Apr 2017 12:46:19 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C40818C553; Fri, 21 Apr 2017 12:46:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C40818C553 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jesper.pedersen@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C40818C553 Received: from localhost.localdomain (ovpn-121-138.rdu2.redhat.com [10.10.121.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59E12828B1; Fri, 21 Apr 2017 12:46:16 +0000 (UTC) Subject: Re: dtrace probes To: Amit Kapila References: <19cb453b-6004-5006-1dbc-fc4fdafca7db@redhat.com> Cc: pgsql-hackers From: Jesper Pedersen Organization: JBoss, by Red Hat Message-ID: <8b892d27-fe7b-71e8-212b-b5bffb2f073f@redhat.com> Date: Fri, 21 Apr 2017 08:46:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <19cb453b-6004-5006-1dbc-fc4fdafca7db@redhat.com> Content-Type: multipart/mixed; boundary="------------A8A3019AE6736ACBBDED6BE7" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 21 Apr 2017 12:46:16 +0000 (UTC) X-Pg-Spam-Score: -6.9 (------) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org This is a multi-part message in MIME format. --------------A8A3019AE6736ACBBDED6BE7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 04/20/2017 10:30 AM, Jesper Pedersen wrote: >> I think this fix is harmless and has some value in terms of >> consistency. One minor suggestion is that you should leave a space >> after typecasting. >> >> - TRACE_POSTGRESQL_LWLOCK_WAIT_DONE(T_NAME(lock), mode); >> + TRACE_POSTGRESQL_LWLOCK_WAIT_DONE(T_NAME(lock), (int)mode); >> >> There should be a space like "(int) mode". >> >> > > v2 attached. > I managed to attach the same patch again, so here is v3. Best regards, Jesper --------------A8A3019AE6736ACBBDED6BE7 Content-Type: text/plain; charset=UTF-8; name="0001-Explicit-cast-LWLockMode-which-an-enum-to-int-in-ord_v3.pacth" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Explicit-cast-LWLockMode-which-an-enum-to-int-in-ord_v3"; filename*1=".pacth" RnJvbSAwZDk2NGRmODQ5NTBjYTkwYzA4ZWQ2ZGQ3N2E1NzVkNGI3MGVhN2Ri IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBqZXNwZXJwZWRlcnNl biA8amVzcGVyLnBlZGVyc2VuQHJlZGhhdC5jb20+CkRhdGU6IFR1ZSwgMTgg QXByIDIwMTcgMTE6NDQ6MTggLTA0MDAKU3ViamVjdDogW1BBVENIXSBFeHBs aWNpdCBjYXN0IExXTG9ja01vZGUsIHdoaWNoIGFuIGVudW0sIHRvIGludCBp biBvcmRlciB0bwogbWF0Y2ggdGhlIGR0cmFjZSBkZWZpbml0aW9uIG9mIHRo ZSBsd2xvY2sgbWV0aG9kcy4gVGhlcmVieSBhbGwgY2FsbCBzaXRlcwogd2ls bCBoYXZlIHRoZSBzYW1lIGRlZmluaXRpb24gaW5zdGVhZCBvZiBhIG1peCBi ZXR3ZWVuIHNpZ25lZCBhbmQgdW5zaWduZWQuCgpBdXRob3I6IEplc3BlciBQ ZWRlcnNlbiA8amVzcGVyLnBlZGVyc2VuQHJlZGhhdC5jb20+Ci0tLQogc3Jj L2JhY2tlbmQvc3RvcmFnZS9sbWdyL2x3bG9jay5jIHwgMTggKysrKysrKysr LS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCA5 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3N0b3Jh Z2UvbG1nci9sd2xvY2suYyBiL3NyYy9iYWNrZW5kL3N0b3JhZ2UvbG1nci9s d2xvY2suYwppbmRleCAzZTEzMzk0Li5jNTUxYmUyIDEwMDY0NAotLS0gYS9z cmMvYmFja2VuZC9zdG9yYWdlL2xtZ3IvbHdsb2NrLmMKKysrIGIvc3JjL2Jh Y2tlbmQvc3RvcmFnZS9sbWdyL2x3bG9jay5jCkBAIC0xMjI2LDcgKzEyMjYs NyBAQCBMV0xvY2tBY3F1aXJlKExXTG9jayAqbG9jaywgTFdMb2NrTW9kZSBt b2RlKQogI2VuZGlmCiAKIAkJTFdMb2NrUmVwb3J0V2FpdFN0YXJ0KGxvY2sp OwotCQlUUkFDRV9QT1NUR1JFU1FMX0xXTE9DS19XQUlUX1NUQVJUKFRfTkFN RShsb2NrKSwgbW9kZSk7CisJCVRSQUNFX1BPU1RHUkVTUUxfTFdMT0NLX1dB SVRfU1RBUlQoVF9OQU1FKGxvY2spLCAoaW50KSBtb2RlKTsKIAogCQlmb3Ig KDs7KQogCQl7CkBAIC0xMjQ4LDcgKzEyNDgsNyBAQCBMV0xvY2tBY3F1aXJl KExXTG9jayAqbG9jaywgTFdMb2NrTW9kZSBtb2RlKQogCQl9CiAjZW5kaWYK IAotCQlUUkFDRV9QT1NUR1JFU1FMX0xXTE9DS19XQUlUX0RPTkUoVF9OQU1F KGxvY2spLCBtb2RlKTsKKwkJVFJBQ0VfUE9TVEdSRVNRTF9MV0xPQ0tfV0FJ VF9ET05FKFRfTkFNRShsb2NrKSwgKGludCkgbW9kZSk7CiAJCUxXTG9ja1Jl cG9ydFdhaXRFbmQoKTsKIAogCQlMT0dfTFdERUJVRygiTFdMb2NrQWNxdWly ZSIsIGxvY2ssICJhd2FrZW5lZCIpOwpAQCAtMTI1Nyw3ICsxMjU3LDcgQEAg TFdMb2NrQWNxdWlyZShMV0xvY2sgKmxvY2ssIExXTG9ja01vZGUgbW9kZSkK IAkJcmVzdWx0ID0gZmFsc2U7CiAJfQogCi0JVFJBQ0VfUE9TVEdSRVNRTF9M V0xPQ0tfQUNRVUlSRShUX05BTUUobG9jayksIG1vZGUpOworCVRSQUNFX1BP U1RHUkVTUUxfTFdMT0NLX0FDUVVJUkUoVF9OQU1FKGxvY2spLCAoaW50KSBt b2RlKTsKIAogCS8qIEFkZCBsb2NrIHRvIGxpc3Qgb2YgbG9ja3MgaGVsZCBi eSB0aGlzIGJhY2tlbmQgKi8KIAloZWxkX2x3bG9ja3NbbnVtX2hlbGRfbHds b2Nrc10ubG9jayA9IGxvY2s7CkBAIC0xMzA4LDE0ICsxMzA4LDE0IEBAIExX TG9ja0NvbmRpdGlvbmFsQWNxdWlyZShMV0xvY2sgKmxvY2ssIExXTG9ja01v ZGUgbW9kZSkKIAkJUkVTVU1FX0lOVEVSUlVQVFMoKTsKIAogCQlMT0dfTFdE RUJVRygiTFdMb2NrQ29uZGl0aW9uYWxBY3F1aXJlIiwgbG9jaywgImZhaWxl ZCIpOwotCQlUUkFDRV9QT1NUR1JFU1FMX0xXTE9DS19DT05EQUNRVUlSRV9G QUlMKFRfTkFNRShsb2NrKSwgbW9kZSk7CisJCVRSQUNFX1BPU1RHUkVTUUxf TFdMT0NLX0NPTkRBQ1FVSVJFX0ZBSUwoVF9OQU1FKGxvY2spLCAoaW50KSBt b2RlKTsKIAl9CiAJZWxzZQogCXsKIAkJLyogQWRkIGxvY2sgdG8gbGlzdCBv ZiBsb2NrcyBoZWxkIGJ5IHRoaXMgYmFja2VuZCAqLwogCQloZWxkX2x3bG9j a3NbbnVtX2hlbGRfbHdsb2Nrc10ubG9jayA9IGxvY2s7CiAJCWhlbGRfbHds b2Nrc1tudW1faGVsZF9sd2xvY2tzKytdLm1vZGUgPSBtb2RlOwotCQlUUkFD RV9QT1NUR1JFU1FMX0xXTE9DS19DT05EQUNRVUlSRShUX05BTUUobG9jayks IG1vZGUpOworCQlUUkFDRV9QT1NUR1JFU1FMX0xXTE9DS19DT05EQUNRVUlS RShUX05BTUUobG9jayksIChpbnQpIG1vZGUpOwogCX0KIAlyZXR1cm4gIW11 c3R3YWl0OwogfQpAQCAtMTM4Nyw3ICsxMzg3LDcgQEAgTFdMb2NrQWNxdWly ZU9yV2FpdChMV0xvY2sgKmxvY2ssIExXTG9ja01vZGUgbW9kZSkKICNlbmRp ZgogCiAJCQlMV0xvY2tSZXBvcnRXYWl0U3RhcnQobG9jayk7Ci0JCQlUUkFD RV9QT1NUR1JFU1FMX0xXTE9DS19XQUlUX1NUQVJUKFRfTkFNRShsb2NrKSwg bW9kZSk7CisJCQlUUkFDRV9QT1NUR1JFU1FMX0xXTE9DS19XQUlUX1NUQVJU KFRfTkFNRShsb2NrKSwgKGludCkgbW9kZSk7CiAKIAkJCWZvciAoOzspCiAJ CQl7CkBAIC0xNDA1LDcgKzE0MDUsNyBAQCBMV0xvY2tBY3F1aXJlT3JXYWl0 KExXTG9jayAqbG9jaywgTFdMb2NrTW9kZSBtb2RlKQogCQkJCUFzc2VydChu d2FpdGVycyA8IE1BWF9CQUNLRU5EUyk7CiAJCQl9CiAjZW5kaWYKLQkJCVRS QUNFX1BPU1RHUkVTUUxfTFdMT0NLX1dBSVRfRE9ORShUX05BTUUobG9jayks IG1vZGUpOworCQkJVFJBQ0VfUE9TVEdSRVNRTF9MV0xPQ0tfV0FJVF9ET05F KFRfTkFNRShsb2NrKSwgKGludCkgbW9kZSk7CiAJCQlMV0xvY2tSZXBvcnRX YWl0RW5kKCk7CiAKIAkJCUxPR19MV0RFQlVHKCJMV0xvY2tBY3F1aXJlT3JX YWl0IiwgbG9jaywgImF3YWtlbmVkIik7CkBAIC0xNDM1LDcgKzE0MzUsNyBA QCBMV0xvY2tBY3F1aXJlT3JXYWl0KExXTG9jayAqbG9jaywgTFdMb2NrTW9k ZSBtb2RlKQogCQkvKiBGYWlsZWQgdG8gZ2V0IGxvY2ssIHNvIHJlbGVhc2Ug aW50ZXJydXB0IGhvbGRvZmYgKi8KIAkJUkVTVU1FX0lOVEVSUlVQVFMoKTsK IAkJTE9HX0xXREVCVUcoIkxXTG9ja0FjcXVpcmVPcldhaXQiLCBsb2NrLCAi ZmFpbGVkIik7Ci0JCVRSQUNFX1BPU1RHUkVTUUxfTFdMT0NLX0FDUVVJUkVf T1JfV0FJVF9GQUlMKFRfTkFNRShsb2NrKSwgbW9kZSk7CisJCVRSQUNFX1BP U1RHUkVTUUxfTFdMT0NLX0FDUVVJUkVfT1JfV0FJVF9GQUlMKFRfTkFNRShs b2NrKSwgKGludCkgbW9kZSk7CiAJfQogCWVsc2UKIAl7CkBAIC0xNDQzLDcg KzE0NDMsNyBAQCBMV0xvY2tBY3F1aXJlT3JXYWl0KExXTG9jayAqbG9jaywg TFdMb2NrTW9kZSBtb2RlKQogCQkvKiBBZGQgbG9jayB0byBsaXN0IG9mIGxv Y2tzIGhlbGQgYnkgdGhpcyBiYWNrZW5kICovCiAJCWhlbGRfbHdsb2Nrc1tu dW1faGVsZF9sd2xvY2tzXS5sb2NrID0gbG9jazsKIAkJaGVsZF9sd2xvY2tz W251bV9oZWxkX2x3bG9ja3MrK10ubW9kZSA9IG1vZGU7Ci0JCVRSQUNFX1BP U1RHUkVTUUxfTFdMT0NLX0FDUVVJUkVfT1JfV0FJVChUX05BTUUobG9jayks IG1vZGUpOworCQlUUkFDRV9QT1NUR1JFU1FMX0xXTE9DS19BQ1FVSVJFX09S X1dBSVQoVF9OQU1FKGxvY2spLCAoaW50KSBtb2RlKTsKIAl9CiAKIAlyZXR1 cm4gIW11c3R3YWl0OwotLSAKMi43LjQKCg== --------------A8A3019AE6736ACBBDED6BE7 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------A8A3019AE6736ACBBDED6BE7--