Content-Type: multipart/mixed; boundary="------------yNL0cHVpYSAQzY4bQAS0ebUi"
Message-ID: <8bc12186-b375-424d-be56-22b8f0f0e689@ardentperf.com>
Date: Tue, 9 Jan 2024 23:35:07 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Built-in CTYPE provider
To: Jeff Davis <pgsql@j-davis.com>
Cc: pgsql-hackers@postgresql.org
References: <dd9261f4-7a98-4565-93ec-336c1c110d90@manitou-mail.org>
 <6b1370d5eaba5e8c42f54c05f7bc2b8e27b8db12.camel@j-davis.com>
 <804eb67b37f41d3afeb2b6469cbe8bfa79c562cc.camel@j-davis.com>
 <2b98e5d9-6c51-41cf-8017-88a6a6a129bc@ardentperf.com>
 <c7d6df46ffbfb1af38b18d934ac3a81ffccb7fc8.camel@j-davis.com>
Content-Language: en-US
From: Jeremy Schneider <schneider@ardentperf.com>
In-Reply-To: <c7d6df46ffbfb1af38b18d934ac3a81ffccb7fc8.camel@j-davis.com>
Archived-At: <https://www.postgresql.org/message-id/8bc12186-b375-424d-be56-22b8f0f0e689%40ardentperf.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------yNL0cHVpYSAQzY4bQAS0ebUi
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 1/9/24 2:31 PM, Jeff Davis wrote:
> On Tue, 2024-01-09 at 14:17 -0800, Jeremy Schneider wrote:
>> I think we missed something in psql, pretty sure I applied all the
>> patches but I see this error:
>>
>> =# \l
>> ERROR:  42703: column d.datlocale does not exist
>> LINE 8:   d.datlocale as "Locale",
>>
> 
> Thank you. I'll fix this in the next patch set.

Very minor nitpick/request. Not directly with this patch set but with
the category_test which is related and also recently committed.

I'm testing out "make update-unicode" scripts, and due to my system ICU
version being different from the PostgreSQL unicode version I get the
expected warnings from category_test:

Postgres Unicode Version:       15.1
ICU Unicode Version:            14.0
Skipped 5116 codepoints unassigned in ICU due to Unicode version mismatch.
category_test: All tests successful!

I know it's minor, but I saw the 5116 skipped codepoints and saw "all
tests succeeded" but I thought the output might be a little nicer if we
showed the count of tests that succeeded. For example:

Postgres Unicode Version:       15.1
ICU Unicode Version:            14.0
Skipped 5116 codepoints unassigned in ICU due to Unicode version mismatch.
category_test: All 1108996 tests successful!

It's a minor tweak to a script that I don't think even runs in the
standard build; any objections?  Patch attached.

-Jeremy


-- 
http://about.me/jeremy_schneider

--------------yNL0cHVpYSAQzY4bQAS0ebUi
Content-Type: text/plain; charset=UTF-8;
 name="0001-Output-count-of-checked-codepoints.patch"
Content-Disposition: attachment;
 filename="0001-Output-count-of-checked-codepoints.patch"
Content-Transfer-Encoding: base64

RnJvbSA1ZmYwOWViNzM3MWFiYzE0Y2Q4NTM3YjRlMzI2NWUzNWYwMzA3OTRmIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZXJlbXkgU2NobmVpZGVyIDxzY2huZWlkZXJAYXJk
ZW50cGVyZi5jb20+CkRhdGU6IFdlZCwgMTAgSmFuIDIwMjQgMDc6MjU6MTcgKzAwMDAKU3Vi
amVjdDogW1BBVENIXSBPdXRwdXQgY291bnQgb2YgY2hlY2tlZCBjb2RlcG9pbnRzLgoKLS0t
CiBzcmMvY29tbW9uL3VuaWNvZGUvY2F0ZWdvcnlfdGVzdC5jIHwgOCArKysrKysrLQogMSBm
aWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdp
dCBhL3NyYy9jb21tb24vdW5pY29kZS9jYXRlZ29yeV90ZXN0LmMgYi9zcmMvY29tbW9uL3Vu
aWNvZGUvY2F0ZWdvcnlfdGVzdC5jCmluZGV4IDZjZDdjZDFhNWYuLjYyZmYzNDUwNjYgMTAw
NjQ0Ci0tLSBhL3NyYy9jb21tb24vdW5pY29kZS9jYXRlZ29yeV90ZXN0LmMKKysrIGIvc3Jj
L2NvbW1vbi91bmljb2RlL2NhdGVnb3J5X3Rlc3QuYwpAQCAtNTMsNiArNTMsNyBAQCBtYWlu
KGludCBhcmdjLCBjaGFyICoqYXJndikKIAlpbnQJCQlpY3VfdW5pY29kZV92ZXJzaW9uID0g
cGFyc2VfdW5pY29kZV92ZXJzaW9uKFVfVU5JQ09ERV9WRVJTSU9OKTsKIAlpbnQJCQlwZ19z
a2lwcGVkX2NvZGVwb2ludHMgPSAwOwogCWludAkJCWljdV9za2lwcGVkX2NvZGVwb2ludHMg
PSAwOworCWludAkJCWNoZWNrZWRfY29kZXBvaW50cyA9IDA7CiAKIAlwcmludGYoIlBvc3Rn
cmVzIFVuaWNvZGUgVmVyc2lvbjpcdCVzXG4iLCBQR19VTklDT0RFX1ZFUlNJT04pOwogCXBy
aW50ZigiSUNVIFVuaWNvZGUgVmVyc2lvbjpcdFx0JXNcbiIsIFVfVU5JQ09ERV9WRVJTSU9O
KTsKQEAgLTkwLDYgKzkxLDEwIEBAIG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogCQkJ
CWV4aXQoMSk7CiAJCQl9CiAJCX0KKwkJZWxzZQorCQl7CisJCQljaGVja2VkX2NvZGVwb2lu
dHMrKzsKKwkJfQogCX0KIAogCWlmIChwZ19za2lwcGVkX2NvZGVwb2ludHMgPiAwKQpAQCAt
OTksNyArMTA0LDggQEAgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAJCXByaW50Zigi
U2tpcHBlZCAlZCBjb2RlcG9pbnRzIHVuYXNzaWduZWQgaW4gSUNVIGR1ZSB0byBVbmljb2Rl
IHZlcnNpb24gbWlzbWF0Y2guXG4iLAogCQkJICAgaWN1X3NraXBwZWRfY29kZXBvaW50cyk7
CiAKLQlwcmludGYoImNhdGVnb3J5X3Rlc3Q6IEFsbCB0ZXN0cyBzdWNjZXNzZnVsIVxuIik7
CisJcHJpbnRmKCJjYXRlZ29yeV90ZXN0OiBBbGwgJWQgdGVzdHMgc3VjY2Vzc2Z1bCFcbiIs
CisJCSAgIGNoZWNrZWRfY29kZXBvaW50cyk7CiAJZXhpdCgwKTsKICNlbHNlCiAJcHJpbnRm
KCJJQ1Ugc3VwcG9ydCByZXF1aXJlZCBmb3IgdGVzdDsgc2tpcHBpbmcuXG4iKTsKLS0gCjIu
MzQuMQoK

--------------yNL0cHVpYSAQzY4bQAS0ebUi--