Feedback-ID: ie0a040ee:Fastmail
Message-ID: <8be3512a-a23f-4088-a9ec-bf68650a2997@eisentraut.org>
Date: Fri, 7 Feb 2025 13:34:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Virtual generated columns
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
 jian he <jian.universality@gmail.com>
References: <a368248e-69e4-40be-9c07-6c3b5880b0a6@eisentraut.org>
 <ef7c466d-e3b9-4d60-bc03-cd9b48581442@eisentraut.org>
 <09800cb1-43aa-4239-8918-46b71ede4900@eisentraut.org>
 <536b281b-2cb3-4477-971f-c64838bc6263@eisentraut.org>
 <CAEZATCUHnmOu7RtDuP+PCtS_dqvU8hFsAYYFPdiB8gyFszj5WQ@mail.gmail.com>
 <51875199-d5f5-41ed-92dc-3e7b1b996991@eisentraut.org>
 <e5075513-2a0e-4550-bf45-41942af2b676@eisentraut.org>
 <84adfb1b-826c-42b2-a907-b327d3760c7e@eisentraut.org>
 <CAEZATCXQcjZPq+OsczFc13M6v+OP_NiqmUAcRAzi1K60KFuWmQ@mail.gmail.com>
 <831d7f99-0618-48e5-8557-f3d57137f339@eisentraut.org>
 <CAEZATCXnp5XTkUCsmfjLXVWZ7TaibWatnXDdu52J6zN3XsyZhw@mail.gmail.com>
 <64c2468c-3b69-44d7-863a-165931a70c1d@eisentraut.org>
 <b4139280-073a-4226-8bea-3ea9a3ad6e3f@eisentraut.org>
 <CAEZATCX6SHevKrVfAOq+88b4Ysm4Rqq2yeO6He3N0pttEbjYag@mail.gmail.com>
 <afb36e1f-8be9-4900-b29e-b095e30e9416@eisentraut.org>
 <CAEZATCVsfdp5MQpENpbrFAAfpC2tYU7y-Q=uOG57UubGy48Gyw@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CAEZATCVsfdp5MQpENpbrFAAfpC2tYU7y-Q=uOG57UubGy48Gyw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/8be3512a-a23f-4088-a9ec-bf68650a2997%40eisentraut.org>
Precedence: bulk

On 06.02.25 00:25, Dean Rasheed wrote:
> On Tue, 4 Feb 2025 at 22:36, Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> Yeah, this is quite contorted.  I have renamed it like you suggested.
> 
> I looked over this again and I think the patch is in good shape to be committed.

I've committed it.  Thanks.

> One thought that occurred to me was whether it would be better for the
> psql describe output (and maybe also pg_dump) to explicitly output
> "virtual" for columns of this kind. I know that that's the default for
> generated columns, but someone reading the output might not know or
> remember that, so perhaps it would be helpful to be explicit.

My preference was to have the default output format use only 
SQL-standard syntax, not extensions like "VIRTUAL".  If people hate 
this, we can easily change it.