Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0yeX-0008R2-Fg for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Mar 2018 00:09:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f0yeW-0003dQ-Cm for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Mar 2018 00:09:20 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0yeW-0003c8-1q for pgsql-hackers@lists.postgresql.org; Wed, 28 Mar 2018 00:09:20 +0000 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f0yeS-0004Vx-N4 for pgsql-hackers@postgresql.org; Wed, 28 Mar 2018 00:09:18 +0000 Received: by mail-wr0-x244.google.com with SMTP id z73so566036wrb.0 for ; Tue, 27 Mar 2018 17:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WiHqLpti/39ORxQszJEA6kveBPcUDqN71POSuPeV+JA=; b=NYcEu1XUr1tGE27T1Ut8isrr3zm9nYPDT9hWzi2Y7KeyIWYkvCn2bvrSIvrRypnDmO 1CbTaM5RIFDjpR5mxY2vGDDcfeCZSP6L1ZXKhbv4jsvgPqCsIqeItAZ53QOi+2kfbYFf gJeS89bRdwI3DcVObNU9rbBrAmvjbtlw3Joc7QiOHsXgwDqr93r4iEVkFtMhEfsKHd0n 0tpMvZ4uc7QHDrYLq/C925F6outhukEU7AOVbnunxLQaiW5Or0W7LvfQHrwJliQYNKla 3KxN6RvG95fkyXzlur32NniUoOna8kfrVgnqdCowwvCP95U08UxMA6rW42k2k2NG6Gzz Wo7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WiHqLpti/39ORxQszJEA6kveBPcUDqN71POSuPeV+JA=; b=PhVHFSHM8FsO2m0lp3iLCoECri9dL3QNaIgxIG45oTtRx27+6J5PL0VycMg4TADwqn HrgsD3C9icCjNCd7e1WOtlDU9cv5tTetC4bREn5yk4WReKOvK7ewSp29znAMx/i3Ox5M 4zjmGMsmqIhBzvQzAP48c4uTyFAhTzYaLJ5NUmtByhskAJyYZ9DC7LvHCpZ3gPOeqH9C b0JEkwZhSas6Zvi5XdtFjroZQQIIDUkCUTS3jD5lfPy3oU6hXnWmXricCZdUWZiwcf+r 394LoS2+l5TX22YaVZiEgW/SOG3MccHtyOIS4fuCeRq370DNxzUgMN6JCaHvaO1bMWLF im3A== X-Gm-Message-State: AElRT7FFYhCbOLbO75RyaC1aqMd8X3cZtjoaAWAo5XtCTWSoA5ZF1UId +3Ftp7CWaEju5kdkWoC0h6AGZp8MzDbAGXQjsiw6SpM5rttdgW19f/0BYPPl0oeiCfwNJ5vSWVG vFUhHiJFaPH/y2bodPCD7XA9xAgPB+xp5OprySwoYNToCghdPgmSw54tvAn50SAz9PPym5rsoGG 3ZVTo9QaSsuK4= X-Google-Smtp-Source: AIpwx4/dmoDA91kmuZVVUGBQeZHC7jh/hy+ne6O6yQBhc0cRX91ZVTLkRfGE7YXY1gm8TaUq2lWZDA== X-Received: by 10.223.160.195 with SMTP id n3mr1108094wrn.92.1522195754766; Tue, 27 Mar 2018 17:09:14 -0700 (PDT) Received: from [10.137.2.19] (ip-78-102-97-226.net.upcbroadband.cz. [78.102.97.226]) by smtp.gmail.com with ESMTPSA id z3sm29151727wme.3.2018.03.27.17.09.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Mar 2018 17:09:13 -0700 (PDT) Subject: Re: [HACKERS] AdvanceXLInsertBuffer vs. WAL segment compressibility To: Chapman Flack , Michael Paquier , Stephen Frost Cc: Daniel Gustafsson , Tom Lane , Michael Paquier , Heikki Linnakangas , Robert Haas , Bruce Momjian , PostgreSQL Hackers References: <5A92F0C0.7070706@anastigmatix.net> <5AADB130.2020206@anastigmatix.net> <4597.1521338981@sss.pgh.pa.us> <46FFB930-B0F3-400A-85ED-D9948C97FADF@yesql.se> <5AAEE00E.9050503@anastigmatix.net> <21C25ED8-4ED8-4AD4-B551-3E3987ECB18F@yesql.se> <5AAEFF11.3070903@anastigmatix.net> <20180326032731.GM24540@tamriel.snowman.net> <20180326054354.GB2759@paquier.xyz> <5ABAC668.5080203@anastigmatix.net> From: Tomas Vondra Message-ID: <8c00b26a-d6da-5764-e67e-9c4d8128081a@2ndquadrant.com> Date: Wed, 28 Mar 2018 02:09:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <5ABAC668.5080203@anastigmatix.net> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 03/28/2018 12:32 AM, Chapman Flack wrote: > On 03/26/18 01:43, Michael Paquier wrote: > >> Have a look at BKP_REMOVABLE then. This was moved to page headers in >> 2dd9322, still it seems to me that the small benefits outlined on this >> thread don't justify breaking tools relying on this flag set, especially >> if there is no replacement for it. > > Is 2dd9322 a commit? I'm having difficulty finding it: > > https://git.postgresql.org/gitweb/?p=postgresql.git&a=search&h=HEAD&st=commit&s=2dd9322 > > Am I searching wrong? > Not sure what's up with gitweb, but git finds it without any issue: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=2dd9322ba6eea76800b38bfea0599fbc459458f2 > I probably won't have more time to look at this tonight, but could > I ask in advance for examples of tools that would need this bit when > encountering unwritten pages at the end of a segment? > > I don't mean that as snark; it's just nonobvious to me and I might need > a little nudge where to look. > > -Chap > regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services