public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: Alexander Korotkov <[email protected]>
To: Aleksander Alekseev <[email protected]>
Cc: Postgres hackers <[email protected]>
Cc: Maxim Orlov <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Pavel Borisov <[email protected]>
Cc: Greg Stark <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: Mark Dilger <[email protected]>
Cc: David Steele <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: Maxim Orlov <[email protected]>
Cc: [email protected]
Cc: Hamid Akhtar <[email protected]>
Subject: Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
Date: Wed, 17 Apr 2024 08:38:48 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAPpHfduqJ9QCOrXDjkPxPRxJRws1FgFELwB2Yz3L6-n7FQMsrA@mail.gmail.com>
References: <[email protected]>
<CAOBaU_Zo2NytWVn9kMS2_uY0ExOg0KofG1=jA4ZjmKfcrbCn_g@mail.gmail.com>
<CALT9ZEEjHUWAMoBsXzJ91gYu4uJA+Ywms-+ZO1EwCPw2GbH-zw@mail.gmail.com>
<CALT9ZEHx2+9rqAeAANkUXJCsTueQqdx2Tt6ypaig9tozJkWvkQ@mail.gmail.com>
<CACG=ezZho9PjoF5M+=hBqtfjur-jBmJ0b=GasQ4Yds9d+DUUgw@mail.gmail.com>
<CAM-w4HNk0L2PjmoaPVk_Vd5cazqB62f4DS74EmSydeOk8RDoOg@mail.gmail.com>
<CALT9ZEFHWy9SG8BZCqqZMSvuSnRtzRG8ESM5tUxTDNBb-0qy6g@mail.gmail.com>
<CALT9ZEG9Zk5TxuDTnZPGe9H+b7DL40gXfeouWCaZ3A70yvyWLw@mail.gmail.com>
<CALT9ZEG1YAfPBH-ZMnK-cxu0SDdrV_w0QEBs9BLHfWvddpOHFA@mail.gmail.com>
<[email protected]>
<CACG=ezbRVZrdTguWphiFP-L2cCi_jy+spZA0wPJWA806B0=2dQ@mail.gmail.com>
<CACG=ezYk7up-BUL30SrGozURYWt97BK2f=XhUL6S+qU3F9qVzQ@mail.gmail.com>
<CAJ7c6TOe-ifS9JAqhk-5rPrAbnfGkxNYQiWnR6CUaAqLP31T6A@mail.gmail.com>
<CAPpHfduqJ9QCOrXDjkPxPRxJRws1FgFELwB2Yz3L6-n7FQMsrA@mail.gmail.com>
On 24.10.23 22:13, Alexander Korotkov wrote:
> On Wed, Sep 28, 2022 at 11:44 AM Aleksander Alekseev
> <[email protected]> wrote:
>>> I think, this patch was marked as "Waiting on Author", probably, by mistake. Since recent changes were done without any significant code changes and CF bot how happy again.
>>>
>>> I'm going to move it to RfC, could I? If not, please tell why.
>>
>> I restored the "Ready for Committer" state. I don't think it's a good
>> practice to change the state every time the patch has a slight
>> conflict or something. This is not helpful at all. Such things happen
>> quite regularly and typically are fixed in a couple of days.
>
> This patch seems useful to me. I went through the thread, it seems
> that all the critics are addressed.
>
> I've rebased this patch. Also, I've run perltidy for tests, split
> long errmsg() into errmsg(), errdetail() and errhint(), and do other
> minor enchantments.
>
> I think this patch is ready to go. I'm going to push it if there are
> no objections.
I just found the new pg_amcheck option --checkunique in PG17-to-be.
Could we rename this to --check-unique? Seems friendlier. Maybe also
rename the bt_index_check function argument to check_unique.
view thread (22+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox