Feedback-ID: ie0a040ee:Fastmail
Message-ID: <8c9b9b7d-0868-46d4-963c-8b1906bd7a1b@eisentraut.org>
Date: Thu, 21 Mar 2024 23:20:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Adding comments to help understand psql hidden queries
Content-Language: en-US
To: David Christensen <david+pg@pgguru.net>,
 Jim Jones <jim.jones@uni-muenster.de>
Cc: Greg Sabino Mullane <htamfids@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <CAKAnmmJz8Hh=8Ru8jgzySPWmLBhnv4=oc_0KRiz-UORJ0Dex+w@mail.gmail.com>
 <CAHM0NXiD15-23=r1B9rHzKhS8e0+zwp_a6PncdLNetyF0xpNpA@mail.gmail.com>
 <c180a366-fecc-4f3a-9c40-79eec526f70c@uni-muenster.de>
 <CAHM0NXheC3YO=ANPX0fCZKcQxMVBdgDzk9fc=-4TTCUN0aLYWA@mail.gmail.com>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CAHM0NXheC3YO=ANPX0fCZKcQxMVBdgDzk9fc=-4TTCUN0aLYWA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/8c9b9b7d-0868-46d4-963c-8b1906bd7a1b%40eisentraut.org>
Precedence: bulk

On 21.03.24 18:31, David Christensen wrote:
> Thanks for the feedback.  Enclosed is a v2 of this series(?) rebased
> and with that warning fixed; @Greg Sabino Mullane I just created a
> commit on your behalf with the message to hackers.  I'm also creating
> a commit-fest entry for this thread.

I don't think your patch takes into account that the

/**... QUERY ...**/
...
/**...       ...**/

lines are supposed to align vertically.  With your patch, the first line 
would have variable length depending on the command.