Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVuA7-0007oU-5V for pgsql-hackers@arkaria.postgresql.org; Fri, 23 Oct 2020 10:19:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kVuA5-000172-Dg for pgsql-hackers@arkaria.postgresql.org; Fri, 23 Oct 2020 10:19:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVuA5-00014t-2T for pgsql-hackers@lists.postgresql.org; Fri, 23 Oct 2020 10:19:05 +0000 Received: from mout.kundenserver.de ([217.72.192.75]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVu9y-0004bs-JA for pgsql-hackers@lists.postgresql.org; Fri, 23 Oct 2020 10:19:04 +0000 Received: from [192.168.178.43] ([77.185.94.20]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPSA (Nemesis) id 1Mgefy-1jvTTk1UD6-00h9cd; Fri, 23 Oct 2020 12:18:52 +0200 Subject: Re: [PATCH] Add section headings to index types doc To: "David G. Johnston" , =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?= Cc: Michael Paquier , PostgreSQL Hackers References: <877dukhvzg.fsf@wibble.ilmari.org> <2268714.1596457003@sss.pgh.pa.us> <159706393772.790.11301900224459454375.pgcf@coridan.postgresql.org> <20200930063423.GG1996@paquier.xyz> <87pn63ecc0.fsf@wibble.ilmari.org> From: =?UTF-8?Q?J=c3=bcrgen_Purtz?= Message-ID: <8d0b636d-95e1-e802-fa8f-98708cc2d75b@purtz.de> Date: Fri, 23 Oct 2020 12:18:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------B85641F095EB458066D31850" Content-Language: en-US X-Provags-ID: V03:K1:C+jZAgO6hP3y0+qOqPR66K9tPm9ryKPYQTtmC+nior39Czmdlxd PCYYSw4YbtAIvVdOO9xbPHUbgx6c9360LYyy3ps+50b0O/CTGmNIzT+qk0S1sW0ybVTmrcC faeBc7hdnrz5eKbnDvWwkSvmQolwV54EWWanO9bmfhxCmSmuSiDs4O/l7KQTJ2Mh8yVpznc v+hyKOY8PQ2l5GIDK1k8A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:v2XExHRtK5I=:eZ1G4eX3bB25sW/jB4ccav OxbBOyH+1sOuk/WzSfaLPGkn+AS+el06xvy/5zDPQAcSFVR+QSUncAJ5y5T3wcDS9TVXu0UQl fWih6ThZ56R9k8kgupYgVpie8nIScsBOvhmGsGlE2etnQBjoscdifOSRPyD+Hm2rjP1Mr3fZa hSGNwORuk9/7UeiOG8a/b+wjO2Q5kV+J+EIQkKFJahCIFh3FOVbWyglhtiaggo/Goz1axwh5C o/2VaZP5VEebm1VTsDTtavN+2E/R8ze4oy2sRLHfGNaujWIRZVK0lDGiXnBZ9B90TJjpKuFqj faowtRSt1ixvnIn1STGOOccrVMonAzUuufcvigR1e2N2WbuQdwrznv5VTg7VmZDrzK3uMgGIj I++PnOnTyw84+FnVugQwpiI4MbeWZM25a2ZzYLDUIuMqd1HX85xJr+m1z7j5w List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------B85641F095EB458066D31850 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 21.10.20 23:12, David G. Johnston wrote: > On Wed, Sep 30, 2020 at 4:25 AM Dagfinn Ilmari Mannsåker > > wrote: > > Michael Paquier > > writes: > > > On Mon, Aug 10, 2020 at 12:52:17PM +0000, Jürgen Purtz wrote: > >> The new status of this patch is: Waiting on Author > > > > This has not been answered yet, so I have marked the patch as > returned > > with feedback. > > Updated patch attached, wich reformats the operator lists as requested > by Jürgen, > > > A couple of things: > > One, I would place the equality operator for hash inside a standalone > synopsis just like all of the others. ok > Two, why is hash special in having its create index command provided > here? (I notice this isn't the fault of this patch but it stands out > when reviewing it) yes, this looks odd. > > I would suggest rewording hash to look more like the others ok > and add a link to the "CREATE INDEX" command from the chapter preamble. is the link necessary? > > and skips the reindentation as suggested by Tom. > > > Agreed > David J. -- J. Purtz --------------B85641F095EB458066D31850 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit
On 21.10.20 23:12, David G. Johnston wrote:
On Wed, Sep 30, 2020 at 4:25 AM Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> wrote:
Michael Paquier <michael@paquier.xyz> writes:

> On Mon, Aug 10, 2020 at 12:52:17PM +0000, Jürgen Purtz wrote:
>> The new status of this patch is: Waiting on Author
>
> This has not been answered yet, so I have marked the patch as returned
> with feedback.

Updated patch attached, wich reformats the operator lists as requested
by Jürgen,

A couple of things:

One, I would place the equality operator for hash inside a standalone synopsis just like all of the others.
ok
Two, why is hash special in having its create index command provided here? (I notice this isn't the fault of this patch but it stands out when reviewing it)
yes, this looks odd.

I would suggest rewording hash to look more like the others
ok
and add a link to the "CREATE INDEX" command from the chapter preamble.
is the link necessary?

and skips the reindentation as suggested by Tom.

Agreed
David J.

--

J. Purtz


--------------B85641F095EB458066D31850--