Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnA0M-0003VT-Pl for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Nov 2021 01:44:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mnA0L-0001R0-MM for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Nov 2021 01:44:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnA0L-0001Qr-D9 for pgsql-hackers@lists.postgresql.org; Wed, 17 Nov 2021 01:44:53 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnA0I-0001os-1Z for pgsql-hackers@lists.postgresql.org; Wed, 17 Nov 2021 01:44:53 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 19F686098E for ; Wed, 17 Nov 2021 10:44:44 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.4 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_874150fc9aeed1eb7378991a99e559d3" Content-Transfer-Encoding: 7bit Date: Wed, 17 Nov 2021 10:44:44 +0900 From: Ken Kato To: pgsql-hackers@lists.postgresql.org Subject: CREATE tab completion User-Agent: Roundcube Webmail/1.4.11 Message-ID: <8d370135aef066659eef8e8fbfa6315b@oss.nttdata.com> X-Sender: katouknl@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_874150fc9aeed1eb7378991a99e559d3 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi hackers, I noticed that there are some tab completions missing for the following commands: -CREATE CONVERSION : missing FOR, TO, FROM -CREATE DOMAIN : missing after AS -CREATE LANGUAGE : missing after HANDLER -CREATE SCHEMA : missing AUTHORIZATION, IF NOT EXISTS -CREATE SEQUENCE : missing AS -CREATE TRANSFORM : missing after FOR I made a patch for this, so please have a look. Best wishes, -- Ken Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --=_874150fc9aeed1eb7378991a99e559d3 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=create_tab_complete.patch Content-Disposition: attachment; filename=create_tab_complete.patch; size=4552 ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuYyBiL3NyYy9iaW4vcHNxbC90 YWItY29tcGxldGUuYwppbmRleCA0ZjcyNGU0NDI4Li4wMjE2YjUwOTQ2IDEwMDY0NAotLS0gYS9z cmMvYmluL3BzcWwvdGFiLWNvbXBsZXRlLmMKKysrIGIvc3JjL2Jpbi9wc3FsL3RhYi1jb21wbGV0 ZS5jCkBAIC0yNTcyLDYgKzI1NzIsMjAgQEAgcHNxbF9jb21wbGV0aW9uKGNvbnN0IGNoYXIgKnRl eHQsIGludCBzdGFydCwgaW50IGVuZCkKIAkJCUNPTVBMRVRFX1dJVEgoInRydWUiLCAiZmFsc2Ui KTsKIAl9CiAKKwkvKiBDUkVBVEUgQ09OVkVSU0lPTiAqLworCWVsc2UgaWYgKE1hdGNoZXMoIkNS RUFURSIsICJDT05WRVJTSU9OIiwgTWF0Y2hBbnkpKQorCQlDT01QTEVURV9XSVRIKCJGT1IiKTsK KwllbHNlIGlmIChNYXRjaGVzKCJDUkVBVEUiLCAiQ09OVkVSU0lPTiIsIE1hdGNoQW55LCAiRk9S IikpCisJCUNPTVBMRVRFX1dJVEhfUVVFUlkoUXVlcnlfZm9yX2xpc3Rfb2ZfZW5jb2RpbmdzKTsK KwllbHNlIGlmIChNYXRjaGVzKCJDUkVBVEUiLCAiQ09OVkVSU0lPTiIsIE1hdGNoQW55LCAiRk9S IiwgTWF0Y2hBbnkpKQorCQlDT01QTEVURV9XSVRIKCJUTyIpOworCWVsc2UgaWYgKE1hdGNoZXMo IkNSRUFURSIsICJDT05WRVJTSU9OIiwgTWF0Y2hBbnksICJGT1IiLCBNYXRjaEFueSwgIlRPIikp CisJCUNPTVBMRVRFX1dJVEhfUVVFUlkoUXVlcnlfZm9yX2xpc3Rfb2ZfZW5jb2RpbmdzKTsKKwll bHNlIGlmIChNYXRjaGVzKCJDUkVBVEUiLCAiQ09OVkVSU0lPTiIsIE1hdGNoQW55LCAiRk9SIiwg TWF0Y2hBbnksICJUTyIsIE1hdGNoQW55KSkKKwkJQ09NUExFVEVfV0lUSCgiRlJPTSIpOworCWVs c2UgaWYgKE1hdGNoZXMoIkNSRUFURSIsICJDT05WRVJTSU9OIiwgTWF0Y2hBbnksICJGT1IiLCBN YXRjaEFueSwgIlRPIiwgTWF0Y2hBbnksICJGUk9NIikpCisJCUNPTVBMRVRFX1dJVEhfVkVSU0lP TkVEX1NDSEVNQV9RVUVSWShRdWVyeV9mb3JfbGlzdF9vZl9mdW5jdGlvbnMsIE5VTEwpOworCiAJ LyogQ1JFQVRFIERBVEFCQVNFICovCiAJZWxzZSBpZiAoTWF0Y2hlcygiQ1JFQVRFIiwgIkRBVEFC QVNFIiwgTWF0Y2hBbnkpKQogCQlDT01QTEVURV9XSVRIKCJPV05FUiIsICJURU1QTEFURSIsICJF TkNPRElORyIsICJUQUJMRVNQQUNFIiwKQEAgLTI1ODIsNiArMjU5NiwxNyBAQCBwc3FsX2NvbXBs ZXRpb24oY29uc3QgY2hhciAqdGV4dCwgaW50IHN0YXJ0LCBpbnQgZW5kKQogCWVsc2UgaWYgKE1h dGNoZXMoIkNSRUFURSIsICJEQVRBQkFTRSIsIE1hdGNoQW55LCAiVEVNUExBVEUiKSkKIAkJQ09N UExFVEVfV0lUSF9RVUVSWShRdWVyeV9mb3JfbGlzdF9vZl90ZW1wbGF0ZV9kYXRhYmFzZXMpOwog CisJLyogQ1JFQVRFIERPTUFJTiAqLworCWVsc2UgaWYgKE1hdGNoZXMoIkNSRUFURSIsICJET01B SU4iLCBNYXRjaEFueSkpCisJCUNPTVBMRVRFX1dJVEgoIkFTIik7CisJZWxzZSBpZiAoTWF0Y2hl cygiQ1JFQVRFIiwgIkRPTUFJTiIsIE1hdGNoQW55LCAiQVMiKSkKKwkJQ09NUExFVEVfV0lUSF9T Q0hFTUFfUVVFUlkoUXVlcnlfZm9yX2xpc3Rfb2ZfZGF0YXR5cGVzLCBOVUxMKTsKKwllbHNlIGlm IChNYXRjaGVzKCJDUkVBVEUiLCAiRE9NQUlOIiwgTWF0Y2hBbnksICJBUyIsIE1hdGNoQW55KSkK KwkJQ09NUExFVEVfV0lUSCgiQ09MTEFURSIsICJERUZBVUxUIiwgIkNPTlNUUkFJTlQiLAorCQkJ CQkgICJOT1QgTlVMTCIsICJOVUxMIiwgIkNIRUNLICgiKTsKKwllbHNlIGlmIChNYXRjaGVzKCJD UkVBVEUiLCAiRE9NQUlOIiwgTWF0Y2hBbnksICJDT0xMQVRFIikpCisJCUNPTVBMRVRFX1dJVEhf U0NIRU1BX1FVRVJZKFF1ZXJ5X2Zvcl9saXN0X29mX2NvbGxhdGlvbnMsIE5VTEwpOworCiAJLyog Q1JFQVRFIEVYVEVOU0lPTiAqLwogCS8qIENvbXBsZXRlIHdpdGggYXZhaWxhYmxlIGV4dGVuc2lv bnMgcmF0aGVyIHRoYW4gaW5zdGFsbGVkIG9uZXMuICovCiAJZWxzZSBpZiAoTWF0Y2hlcygiQ1JF QVRFIiwgIkVYVEVOU0lPTiIpKQpAQCAtMjY2MSw2ICsyNjg2LDEyIEBAIHBzcWxfY29tcGxldGlv bihjb25zdCBjaGFyICp0ZXh0LCBpbnQgc3RhcnQsIGludCBlbmQpCiAJCQkgIVRhaWxNYXRjaGVz KCJGT1IiLCBNYXRjaEFueSwgTWF0Y2hBbnksIE1hdGNoQW55KSkKIAkJQ09NUExFVEVfV0lUSCgi KCIpOwogCisJLyogQ1JFQVRFIExBTkdVQUdFICovCisJZWxzZSBpZiAoTWF0Y2hlcygiQ1JFQVRF IiwgIkxBTkdVQUdFIiwgTWF0Y2hBbnkpKQorCQlDT01QTEVURV9XSVRIKCJIQU5ETEVSIik7CisJ ZWxzZSBpZiAoTWF0Y2hlcygiQ1JFQVRFIiwgIkxBTkdVQUdFIiwgTWF0Y2hBbnksICJIQU5ETEVS IiwgTWF0Y2hBbnkpKQorCQlDT01QTEVURV9XSVRIKCJJTkxJTkUiLCAiVkFMSURBVE9SIik7CisK IAkvKiBDUkVBVEUgT1IgUkVQTEFDRSAqLwogCWVsc2UgaWYgKE1hdGNoZXMoIkNSRUFURSIsICJP UiIpKQogCQlDT01QTEVURV9XSVRIKCJSRVBMQUNFIik7CkBAIC0yODAyLDExICsyODMzLDIzIEBA IHBzcWxfY29tcGxldGlvbihjb25zdCBjaGFyICp0ZXh0LCBpbnQgc3RhcnQsIGludCBlbmQpCiAJ ZWxzZSBpZiAoVGFpbE1hdGNoZXMoIkFTIiwgIk9OIiwgIlNFTEVDVHxVUERBVEV8SU5TRVJUfERF TEVURSIsICJUTyIpKQogCQlDT01QTEVURV9XSVRIX1NDSEVNQV9RVUVSWShRdWVyeV9mb3JfbGlz dF9vZl90YWJsZXMsIE5VTEwpOwogCisvKiBDUkVBVEUgU0NIRU1BICovCisJZWxzZSBpZiAoTWF0 Y2hlcygiQ1JFQVRFIiwgIlNDSEVNQSIpKQorCQlDT01QTEVURV9XSVRIKCJBVVRIT1JJWkFUSU9O IiwgIklGIE5PVCBFWElTVFMiKTsKKwllbHNlIGlmIChNYXRjaGVzKCJDUkVBVEUiLCAiU0NIRU1B IiwgIklGIiwgIk5PVCIsICJFWElTVFMiKSkKKwl7CisJCWNvbXBsZXRpb25faW5mb19jaGFycCA9 IHByZXYyX3dkOworCQlDT01QTEVURV9XSVRIX1FVRVJZKFF1ZXJ5X2Zvcl9saXN0X29mX3NjaGVt YXMKKwkJCQkJCQkiIFVOSU9OIFNFTEVDVCAnQVVUT1JJWkFUSU9OJyIpOworCX0KKwllbHNlIGlm IChNYXRjaGVzKCJDUkVBVEUiLCAiU0NIRU1BIikgJiYgVGFpbE1hdGNoZXMoIkFVVEhPUklaQVRJ T04iKSkKKwkJQ09NUExFVEVfV0lUSF9RVUVSWShRdWVyeV9mb3JfbGlzdF9vZl9yb2xlcyk7CisK IC8qIENSRUFURSBTRVFVRU5DRSAtLS0gaXMgYWxsb3dlZCBpbnNpZGUgQ1JFQVRFIFNDSEVNQSwg c28gdXNlIFRhaWxNYXRjaGVzICovCiAJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIkNSRUFURSIsICJT RVFVRU5DRSIsIE1hdGNoQW55KSB8fAogCQkJIFRhaWxNYXRjaGVzKCJDUkVBVEUiLCAiVEVNUHxU RU1QT1JBUlkiLCAiU0VRVUVOQ0UiLCBNYXRjaEFueSkpCi0JCUNPTVBMRVRFX1dJVEgoIklOQ1JF TUVOVCBCWSIsICJNSU5WQUxVRSIsICJNQVhWQUxVRSIsICJOTyIsICJDQUNIRSIsCi0JCQkJCSAg IkNZQ0xFIiwgIk9XTkVEIEJZIiwgIlNUQVJUIFdJVEgiKTsKKwkJQ09NUExFVEVfV0lUSCgiQVMi LCAiSU5DUkVNRU5UIEJZIiwgIk1JTlZBTFVFIiwgIk1BWFZBTFVFIiwgIk5PIiwKKwkJCQkJICAi Q0FDSEUiLCJDWUNMRSIsICJPV05FRCBCWSIsICJTVEFSVCBXSVRIIik7CiAJZWxzZSBpZiAoVGFp bE1hdGNoZXMoIkNSRUFURSIsICJTRVFVRU5DRSIsIE1hdGNoQW55LCAiTk8iKSB8fAogCQkJIFRh aWxNYXRjaGVzKCJDUkVBVEUiLCAiVEVNUHxURU1QT1JBUlkiLCAiU0VRVUVOQ0UiLCBNYXRjaEFu eSwgIk5PIikpCiAJCUNPTVBMRVRFX1dJVEgoIk1JTlZBTFVFIiwgIk1BWFZBTFVFIiwgIkNZQ0xF Iik7CkBAIC0yODgyLDYgKzI5MjUsMTkgQEAgcHNxbF9jb21wbGV0aW9uKGNvbnN0IGNoYXIgKnRl eHQsIGludCBzdGFydCwgaW50IGVuZCkKIAllbHNlIGlmIChNYXRjaGVzKCJDUkVBVEUiLCAiVEVY VCIsICJTRUFSQ0giLCAiQ09ORklHVVJBVElPTnxESUNUSU9OQVJZfFBBUlNFUnxURU1QTEFURSIs IE1hdGNoQW55KSkKIAkJQ09NUExFVEVfV0lUSCgiKCIpOwogCisvKiBDUkVBVEUgVFJBTlNGT1JN ICovCisJZWxzZSBpZiAoTWF0Y2hlcygiQ1JFQVRFIiwgIlRSQU5TRk9STSIpKQorCQlDT01QTEVU RV9XSVRIKCJGT1IiKTsKKwllbHNlIGlmIChNYXRjaGVzKCJDUkVBVEUiLCAiVFJBTlNGT1JNIiwg IkZPUiIpKQorCQlDT01QTEVURV9XSVRIX1NDSEVNQV9RVUVSWShRdWVyeV9mb3JfbGlzdF9vZl9k YXRhdHlwZXMsIE5VTEwpOworCWVsc2UgaWYgKE1hdGNoZXMoIkNSRUFURSIsICJUUkFOU0ZPUk0i LCAiRk9SIiwgTWF0Y2hBbnkpCisJCUNPTVBMRVRFX1dJVEgoIkxBTkdVQUdFIikKKwllbHNlIGlm IChNYXRjaGVzKCJDUkVBVEUiLCAiVFJBTlNGT1JNIiwgIkZPUiIsIE1hdGNoQW55LCAiTEFOR1VB R0UiKQorCXsKKwkJY29tcGxldGlvbl9pbmZvX2NoYXJwID0gcHJldjJfd2Q7CisJCUNPTVBMRVRF X1dJVEhfUVVFUlkoUXVlcnlfZm9yX2xpc3Rfb2ZfbGFuZ3VhZ2VzKTsKKwl9CisKIC8qIENSRUFU RSBTVUJTQ1JJUFRJT04gKi8KIAllbHNlIGlmIChNYXRjaGVzKCJDUkVBVEUiLCAiU1VCU0NSSVBU SU9OIiwgTWF0Y2hBbnkpKQogCQlDT01QTEVURV9XSVRIKCJDT05ORUNUSU9OIik7Cg== --=_874150fc9aeed1eb7378991a99e559d3--