Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7Oqm-0002ic-08 for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Dec 2022 22:43:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p7Oqk-0001rF-TM for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Dec 2022 22:43:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7Oqk-0001ow-Eu for pgsql-hackers@lists.postgresql.org; Mon, 19 Dec 2022 22:43:10 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1p7Oqi-0003zs-8Z for pgsql-hackers@postgresql.org; Mon, 19 Dec 2022 22:43:09 +0000 Received: by mail-pg1-x52f.google.com with SMTP id w37so7175131pga.5 for ; Mon, 19 Dec 2022 14:43:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20210112.gappssmtp.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=IW7hajHvUCQcOcVq1pgs4xEIeiM9HDNeMldiM04i/sU=; b=vTwDiulgrpYU/Z5s3RMK+BLjqDKB9KACAMfhunzxxjepjyF4ezD9AnuUmZOZn8PxKv LE+ZgN8h53n6DMJ6j8ypGKbA11xWIM0RFwqa0VjNwvKnKqvzGf5niLaQ2SEzRCihFe/F 4BoJQHdIJ3KiV65F6Ji1QJtpnyHXXt4rXooenEkNv6VxnY9u3BO45qX8UrSNCCElrdtk i3+fJd+CpmLCjybbpxExF1Z97R0yQJvhZjCdJrrQuCi+UHkICnhusBWfsCVFso400qiL LUbvA7N5VTFtVzSG1hOZhxRDopHj18OgNAdLBXGhL1cM6AwiBdfZENCK7XMJN46tuO9k MkjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IW7hajHvUCQcOcVq1pgs4xEIeiM9HDNeMldiM04i/sU=; b=AM5JROFXBFV4akCbCliRy0c/TFRgANlhjvIwYQ6bRABIkTi7MDAEVgMNGydfPFfrH0 xeChoRr1HFK6XaUu95DuSQ9fdg2xPs9Ao724fUZ1cQIELhbwchXL9sv0YlZWZh/+isqA HuUkgloXleIAJgSLlyKlRoRqFlLsXdgCFWnUmgbuwnau+/uvBa3jmduAckuVqbu9IqFU yYLWtZa+mINTbkvECEMa+/JCPzEO0TBCprAZGp2m0HR/8PfZaWO7s56vN78ah9dgPCDS PWMBdMMzQvre+39CHYKc/i+GqVBqEqurCKkFwckyzTz9Ip+bFc2O8zgrAKtWU1cmwyPm c57g== X-Gm-Message-State: ANoB5pmqbRrKVa52umSuaq5794DZQk/XtrUwHbBzZ0QRibr0Ty/p4p32 IoXlzVyPH1GIFC1lhZfP7EIqWQ== X-Google-Smtp-Source: AA0mqf7vSVogVNwedg0zff9WLx4k/fo7z9yhSB7+Qn8Yw1TmbRxrPI0yTn8LieIFAi9pMyYjFGbmZQ== X-Received: by 2002:a05:6a00:2481:b0:576:3005:bb4d with SMTP id c1-20020a056a00248100b005763005bb4dmr61301174pfv.31.1671489787068; Mon, 19 Dec 2022 14:43:07 -0800 (PST) Received: from [172.18.7.14] ([12.126.244.130]) by smtp.gmail.com with ESMTPSA id w80-20020a627b53000000b00576984617b1sm7171839pfc.60.2022.12.19.14.43.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 14:43:06 -0800 (PST) Message-ID: <8d4e2114e651e4c7e53ed4a2622d33e24eef74ba.camel@j-davis.com> Subject: Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX From: Jeff Davis To: Justin Pryzby , Ted Yu Cc: Nathan Bossart , Pavel Luzanov , pgsql-hackers@postgresql.org Date: Mon, 19 Dec 2022 14:43:05 -0800 In-Reply-To: <20221218233803.GW1153@telsasoft.com> References: <20221214032332.GA671806@nathanxps13> <8f7172da-2b58-3bd0-97ae-5126e2a7970c@postgrespro.ru> <20221214221140.GA1153@telsasoft.com> <295e86c7aeafb8e2623f8eccdc846855bf2c7e0c.camel@j-davis.com> <20221217060408.GA1256247@nathanxps13> <20221218233803.GW1153@telsasoft.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sun, 2022-12-18 at 17:38 -0600, Justin Pryzby wrote: > On Sat, Dec 17, 2022 at 04:39:29AM -0800, Ted Yu wrote: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 List=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 *ancestors =3D get_partition_ancestors(relid); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Oid=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 root =3D InvalidOid; > >=20 > > nit: it would be better if the variable `root` can be aligned with > > variable > > `ancestors`. >=20 > It is aligned, but only after configuring one's editor/pager/mail > client > to display tabs in the manner assumed by postgres' coding style. If you use emacs or vim, there are editor config samples in src/tools/editors/ Regards, Jeff Davis