Feedback-ID: i131946ab:Fastmail
Message-ID: <8d87e399-84ee-1cf2-5a07-1fb2e4f15400@enterprisedb.com>
Date: Wed, 11 Jan 2023 15:08:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: Rework of collation code, extensibility
Content-Language: en-US
To: Jeff Davis <pgsql@j-davis.com>, pgsql-hackers@postgresql.org
References: <a581136455c940d7bd0ff482d3a2bd51af25a94f.camel@j-davis.com>
 <a20de213c75fe471d067eecc1ac65e0edb9af377.camel@j-davis.com>
 <a0d48a52-8596-763b-7682-d4b9e3b2e10e@enterprisedb.com>
 <0ab5c536cc778a5f27f51a6998fd4033bb1c21d8.camel@j-davis.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <0ab5c536cc778a5f27f51a6998fd4033bb1c21d8.camel@j-davis.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/8d87e399-84ee-1cf2-5a07-1fb2e4f15400%40enterprisedb.com>
Precedence: bulk

On 06.01.23 08:04, Jeff Davis wrote:
> The existing code is not great, in my opinion: it doesn't have clear
> API boundaries, the comments are insufficient, and lots of special
> cases need to be handled awkwardly by callers. That style is hard to
> beat when it comes to the raw line count; but it's quite difficult to
> understand and work on.
> 
> I think my changes are an improvement, but obviously that depends on
> the opinion of others who are working in this part of the code. What do
> you think?

I think the refactoring that you proposed in the thread "Refactor to 
introduce pg_strcoll()." was on a sensible track.  Maybe we should try 
to get that done.  The multiple-ICU stuff is still experimental and has 
its own rather impressive thread, so I don't think it's sensible to try 
to sort that out here.