public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: vignesh C <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: jian he <[email protected]>
Cc: Dean Rasheed <[email protected]>
Subject: Re: Virtual generated columns
Date: Fri, 29 Nov 2024 11:14:16 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CACJufxGh=XX7q5xTci---HikSJsOwP7_qCNyyDHdp2YL4NLZCg@mail.gmail.com>
	<CACJufxHxoz_KVQxcQ=cSvJc+PNbh=FaHbcMZCOisoOaGAgjy4w@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAEZATCV=RX0M58-uqSR6tFjwQAFnEcx3hvW-9ZZfRQJLg5LzRw@mail.gmail.com>
	<[email protected]>
	<CAEZATCU3q=znAL7X1aSxuMpjfSyB1cT5j398HPb9ix9ci_HUqA@mail.gmail.com>
	<[email protected]>
	<CAEZATCVLfMzNwT1J0bnvtv6YbmNSN9QSXb+1QSGyX6vK4q67Ow@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CALDaNm0qgdx-zzCM4fAx++JBcZYoRsFp_7Dv5hnKRbUt87X3nw@mail.gmail.com>
	<[email protected]>

On 12.11.24 17:10, Peter Eisentraut wrote:
> On 11.11.24 06:51, vignesh C wrote:
>> The patch needs to be rebased due to a recent commit 14e87ffa5c5.
> 
> done in v9
> 
>> I
>> have verified the behavior of logical replication of row filters on
>> the virtual generated column, and everything appears to be functioning
>> as expected. One suggestion would be to add a test case for the row
>> filter on a virtual generated column.
> 
> Yes, I just need a find a good place to put it into src/test/ 
> subscription/t/028_row_filter.pl.  It's very long. ;-)

I have added tests in the v10 patch.

view thread (75+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Virtual generated columns
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox