Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tBrP2-006ZoD-PV for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Nov 2024 08:10:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tBrP0-008Gqt-4E for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Nov 2024 08:10:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tBrOz-008Gqk-Ne for pgsql-hackers@lists.postgresql.org; Fri, 15 Nov 2024 08:10:02 +0000 Received: from meesny.iki.fi ([2001:67c:2b0:1c1::201]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tBrOx-001z4z-7V for pgsql-hackers@lists.postgresql.org; Fri, 15 Nov 2024 08:10:01 +0000 Received: from [192.168.1.110] (dsl-hkibng22-50ddb7-241.dhcp.inet.fi [80.221.183.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by meesny.iki.fi (Postfix) with ESMTPSA id 4XqV7637VGzySZ; Fri, 15 Nov 2024 10:09:54 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1731658194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wSXxwdqYbaY/vdN/dOAwAnk3THuDWRsUM+pLRUscWdg=; b=efJNaz4Bipe7aV1xftJ9ZP9O0OiU9v1xWYwsrM3RdQK8qRumxVQQT6proX6JPnaDtZfeND IQ0er0fKIvIi/XsAXKzs3EtlH/C8B3EXrutltlY+1xEkPBn3Nqllqt8Lp88+9MBYLFozwR d+VkOnMIO3zNYKbew4gjh2Vuk2C2R5E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1731658194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wSXxwdqYbaY/vdN/dOAwAnk3THuDWRsUM+pLRUscWdg=; b=jUv8DDbPTjVO+nyBZ0RN/enD1NVUKw2iaCRm/Tlxu/+x/cWIF0+x8zrp0YNY9Zmf88brJf mW2haRST/W9YNeuRQpnZYYDV9lwk6OvpQ7OdTof8e3zPzmtxKjQ93F1A8C3Xq3pXByenQj VVuC0yl6velxEWilZavewYfyU2Omnmg= ARC-Seal: i=1; s=meesny; d=iki.fi; t=1731658194; a=rsa-sha256; cv=none; b=Mb0kZxclyrjlbUbLlKNqpRPwCHH5tJvYZ97v1J7iTlPtcBoXGR7Q8XZTf32ld6jxGgsCD/ R3GkP9UZKeKtDBccHcDFaSI5Q+YlakylMxmThjh+HL7Xs7yLWCMCSARXh3HuanWYzUX40C aQifuupU4GZ2y8v4ZfZXcRBdCA1RzGk= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi Message-ID: <8dbd16ee-6661-4d2f-a082-77fa58db0050@iki.fi> Date: Fri, 15 Nov 2024 10:09:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: JIT: Remove some unnecessary instructions. To: Andreas Karlsson , Xing Guo Cc: pgsql-hackers@lists.postgresql.org References: <13394b72-4116-4a4c-90f8-83031ec8cd89@proxel.se> Content-Language: en-US From: Heikki Linnakangas In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 02/09/2024 22:06, Andreas Karlsson wrote: > On 9/2/24 4:23 AM, Xing Guo wrote: >> Thanks for testing it! I spotted another unnecessary store instruction >> and added it in my V2 patch. > > Another well-spotted unnecessary store. Nice! > > I think this patch is ready for committer. It is simple and pretty > obviously correct. Committed, thanks! -- Heikki Linnakangas Neon (https://neon.tech)