Message-ID: <8e6bd629-fa69-371c-966d-aaf071aafeb8@gmail.com>
Date: Tue, 7 Nov 2023 16:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: collect_corrupt_items_vacuum.patch
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>,
 Daniel Shelepanov <deniel1495@mail.ru>, Nikita Malakhov <hukutoc@gmail.com>,
 Michael Paquier <michael@paquier.xyz>, Robert Haas <robertmhaas@gmail.com>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Andres Freund <andres@anarazel.de>
References: <1649062270.289865713@f403.i.mail.ru>
 <CA+TgmoZtw7yNZogHFrgatHnvc2rOX9hoRRq=GtUBZx9mxh86Vg@mail.gmail.com>
 <3107109.1658958956@sss.pgh.pa.us>
 <CA+TgmoYmGN6ivwioc4YaEQqGOS2oH=0jDYMVghb6Vd5hx6bwtA@mail.gmail.com>
 <Y0ZNU8v0bYIHc5cj@paquier.xyz>
 <CAN-LCVMLrup6=6yGxrMVThPrNYpa4km7Nn420PaFVo3sRjxpbw@mail.gmail.com>
 <CAN-LCVMWxCvraFrGWxMtvkqrkSYZhCoOixR8a2sOjSCgG_pgrw@mail.gmail.com>
 <CFF957C5-80B0-454E-A755-9B6D2EBD33DE@yesql.se>
 <CAPpHfdu6c=dQHq4r_xXbcAu0T4P28wv6x7QTwBZa7idv6nZsrA@mail.gmail.com>
 <add210d6-0278-d00e-ebe5-4e5e42e08ecc@gmail.com>
 <CAPpHfdsVVAdaGAJgoOBAJ+6EGaCdsUi=wbgQAc3+8X_qtUr=Qg@mail.gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
Content-Language: en-US
In-Reply-To: <CAPpHfdsVVAdaGAJgoOBAJ+6EGaCdsUi=wbgQAc3+8X_qtUr=Qg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/8e6bd629-fa69-371c-966d-aaf071aafeb8%40gmail.com>
Precedence: bulk

07.11.2023 14:38, Alexander Korotkov wrote:
> Hi, Alexander.
>
> On Tue, Nov 7, 2023 at 1:00 PM Alexander Lakhin <exclusion@gmail.com> wrote:
>> It looks like the v2 patch doesn't fix the original issue. Maybe I miss
>> something, but with the patch applied, I see the failure immediately,
>> though without the patch several iterations are needed to get it.
>
> That's a bug in the patch.  Thank you for cathing it.  It should start
> calculation from latestCompletedXid + 1, not InvalidTransactionId.
> Please, check the revised patch.

Thanks for looking at this!
Unfortunately, I still see the failure with the v3, but not on a first
iteration:
...
iteration 316
Error condition in psql-8.log:
create table vacuum_test as select 42 i;
vacuum (disable_page_skipping) vacuum_test;
select * from pg_check_visible('vacuum_test');
  t_ctid
--------
  (0,1)
(1 row)

(I've double-checked that the patch is applied and get_strict_xid_horizon()
is called.)

Best regards,
Alexander