Subject: Re: logical replication launcher crash on buildfarm
To: Robert Haas <robertmhaas@gmail.com>
References: <20170316032833.2zxfnqe3sl3ktrbt@alap3.anarazel.de>
 <368e64f6-ee9a-f09f-82b4-a33b61b28d36@2ndquadrant.com>
 <20170327165023.t224nralrspk6udc@alap3.anarazel.de>
 <CA+Tgmoa3C7=gVvmwvvKWT6+mkm=XGSDqF4bXu6=fohArafWHMQ@mail.gmail.com>
 <52d78669-0523-4e60-a263-841c96210256@2ndquadrant.com>
 <8941c9b1-f6e9-1056-39f2-7bc7336c4d00@2ndquadrant.com>
 <20170328020422.i4srzzgq4zbzu2ci@alap3.anarazel.de>
 <CA+TgmobBTZ_eDbTmx-pfUndZDKPBAcj+r_3CQjEHFkp99kE2Yg@mail.gmail.com>
 <e3c35f3a-426d-b1ca-7fe5-9241c2717013@2ndquadrant.com>
 <CA+Tgmoae_obbYapxDhELe852TO1nFGOdVbWiUwa6Gf+ODxjHnQ@mail.gmail.com>
 <0471e978-b121-ad2f-2879-f1694d9a5ce7@2ndquadrant.com>
 <d217ee26-f3d1-4079-0110-3f7ee44ad6b4@2ndquadrant.com>
 <2124fb62-2393-8525-4fe9-b95b1b689d09@2ndquadrant.com>
 <CA+TgmobNi6++NFCQgSay4A05-FNVFfYVKxfBa00zke8vqU1V3Q@mail.gmail.com>
 <09d8ad33-4287-a09b-a77f-77f8761adb5e@2ndquadrant.com>
 <CA+TgmoZktru0SK1b9888gYF=zmX_haRm+6i8rBP0APS6yO8+NA@mail.gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Petr Jelinek <petr@2ndquadrant.com>, Peter Eisentraut <peter_e@gmx.net>
From: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Message-ID: <8ebd3aa3-55eb-1106-7c10-7e7579f94582@2ndquadrant.com>
Date: Sat, 1 Apr 2017 03:26:01 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: 
 <CA+TgmoZktru0SK1b9888gYF=zmX_haRm+6i8rBP0APS6yO8+NA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 01/04/17 02:53, Robert Haas wrote:
> On Fri, Mar 31, 2017 at 8:32 PM, Petr Jelinek
> <petr.jelinek@2ndquadrant.com> wrote:
>> Right, changed to BGW_MAXLEN.
> 
> Hmm, I don't know if there's any good reason not to just use strcmp(),
> but sure, OK.  Committed and back-patched.
> 

Hmm culicidae still fails, this time only in parallel worker code. This
didn't happen on my machine which is strange. Looking at the code, we
are passing the fps->entrypoint as function pointer again so of course
it fails. We have some code to load libraries again but even that gets
initial entrypoint passed as function pointer
(ParallelExtensionTrampoline). I wonder if we'll have to generalize the
InternalBGWorkers even more to some kind of internal function name to
pointer map and add the parallel entry points there as well.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers