Message-ID: <8f0b2c2a-1083-fd63-de14-7dba9f3b2ffb@gmail.com>
Date: Tue, 28 Mar 2023 07:19:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.0
Subject: Re: Generate pg_stat_get_xact*() functions with Macros
To: Michael Paquier <michael@paquier.xyz>
Cc: "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
 Andres Freund <andres@anarazel.de>,
 Michael Paquier <michael.paquier@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <ZBzpDwOMf1ia+M9l@paquier.xyz>
 <631e3084-c5d9-8463-7540-fcff4674caa5@gmail.com>
 <ZB5hipxlAfZoILgZ@paquier.xyz> <ZCDvYgd8OthCttam@paquier.xyz>
 <e2d94c75-a3c1-bc06-f335-73c7225fe5ec@gmail.com>
 <ZCE6X6nsjkaDwz3o@paquier.xyz>
 <442ba19a-6e8a-3fe3-d404-e9101dfbfcbb@gmail.com>
 <ZCFEej4n6qzATmcz@paquier.xyz>
 <6e2efb4f-6fd0-807e-f6bf-94207db8183a@gmail.com>
 <ZCFrMzX3493G1wbL@paquier.xyz> <ZCIbrNX2yhLxsqgN@paquier.xyz>
Content-Language: en-US
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZCIbrNX2yhLxsqgN@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/8f0b2c2a-1083-fd63-de14-7dba9f3b2ffb%40gmail.com>
Precedence: bulk


On 3/28/23 12:41 AM, Michael Paquier wrote:
> On Mon, Mar 27, 2023 at 07:08:51PM +0900, Michael Paquier wrote:
>> The patch has one mistake: PG_STAT_GET_XACT_FUNCENTRY_FLOAT8_MS does
>> not need a slash on its last line or it would include the next, empty
>> line.  This could lead to mistakes (no need to send a new patch just
>> for that).
> 
> Adjusted that, and the rest was fine after a second look, so applied.
> It looks like we are done for now with this thread, so I have marked
> it as committed in the CF app.

Thanks for having corrected the mistake and applied the patch!

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com