Subject: Re: Feature improvement: can we add queryId for
 pg_catalog.pg_stat_activity view?
To: Julien Rouhaud <rjuju123@gmail.com>,
 Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Bruce Momjian <bruce@momjian.us>, Alvaro Herrera
 <alvherre@alvh.no-ip.org>, Tom Lane <tgl@sss.pgh.pa.us>,
 Nitin Jadhav <nitinjadhavpostgres@gmail.com>,
 Hannu Krosing <hannuk@google.com>, Robert Haas <robertmhaas@gmail.com>,
 Pavel Stehule <pavel.stehule@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
 torikoshia <torikoshia@oss.nttdata.com>, Atsushi Torikoshi
 <atorik@gmail.com>, Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>,
 Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Evgeny Efimkin <efimkin@yandex-team.ru>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Magnus Hagander <magnus@hagander.net>
References: <20210413021246.GD4231@momjian.us>
 <20210413173016.GA29955@alvherre.pgsql> <20210414183326.GA10946@momjian.us>
 <20210420162244.GD30205@momjian.us>
 <a878d5ea-64a7-485e-5d2f-177618ebc52d@oss.nttdata.com>
 <20210422092317.xnuvva2322dflxdm@nol>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <8f5e63b8-e8ed-0f80-d8c4-68222624c200@enterprisedb.com>
Date: Mon, 12 Jul 2021 22:02:59 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210422092317.xnuvva2322dflxdm@nol>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/8f5e63b8-e8ed-0f80-d8c4-68222624c200%40enterprisedb.com>
Precedence: bulk

On 22.04.21 11:23, Julien Rouhaud wrote:
>      The statistics gathered by the module are made available via a
>      view named <structname>pg_stat_statements</structname>.  This view
> -   contains one row for each distinct database ID, user ID and query
> -   ID (up to the maximum number of distinct statements that the module
> +   contains one row for each distinct database ID, user ID, query ID and
> +   toplevel (up to the maximum number of distinct statements that the module
>      can track).  The columns of the view are shown in
>      <xref linkend="pgstatstatements-columns"/>.

I'm having trouble parsing this new sentence.  It now says essentially

"This view contains one row for each distinct database ID, each distinct 
user ID, each distinct query ID, and each distinct toplevel."

That last part doesn't make sense.