public inbox for [email protected]help / color / mirror / Atom feed
[PATCH v3 3/3] Fix timeline-tracking failure while sending a historic timeline 2+ messages / 2 participants [nested] [flat]
* [PATCH v3 3/3] Fix timeline-tracking failure while sending a historic timeline @ 2020-12-09 08:22 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Kyotaro Horiguchi @ 2020-12-09 08:22 UTC (permalink / raw) Walsender should track timeline switches while sending a historic timeline. Regain that behavior, which was broken in PG13, by a thinko of 709d003fbd. --- src/backend/replication/walsender.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c index fe0d368a35..8545c6c423 100644 --- a/src/backend/replication/walsender.c +++ b/src/backend/replication/walsender.c @@ -2491,7 +2491,7 @@ WalSndSegmentOpen(XLogReaderState *state, XLogSegNo nextSegNo, XLogSegNo endSegNo; XLByteToSeg(sendTimeLineValidUpto, endSegNo, state->segcxt.ws_segsize); - if (state->seg.ws_segno == endSegNo) + if (nextSegNo == endSegNo) *tli_p = sendTimeLineNextTLI; } -- 2.27.0 ----Next_Part(Tue_Jan__5_17_26_02_2021_224)---- ^ permalink raw reply [nested|flat] 2+ messages in thread
* inconsistent use of SearchSysCacheCopy @ 2024-12-07 00:31 Jeff Davis <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2024-12-07 00:31 UTC (permalink / raw) To: pgsql-hackers When modifying catalog contents, some callers use SearchSysCacheN() and some use SearchSysCacheCopyN(). for instance, these callers use SearchSysCacheN(): - AggregateCreate() - ProcedureCreate() while these callers that use SearchSysCacheCopyN(): - OperatorCreate() - TypeCreate() I generally thought that the non-copy variant was preferred if you are using heap_modify_tuple() or similar, and the latter used when necessary (e.g. modifying through the Form_pg_foo pointer). Aside from avoiding a needless copy, the non-copy variant is also a bit safer because you'll get a WARNING if you forget to ReleaseSysCache(). On the other hand, if you don't use the copy variant, and you actually do modify it, that would be quite dangerous; so perhaps that's why the copy variants are used in so many places where it seems unnecessary. Is there a preferred convention? Regards, Jeff Davis ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-12-07 00:31 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-12-09 08:22 [PATCH v3 3/3] Fix timeline-tracking failure while sending a historic timeline Kyotaro Horiguchi <[email protected]> 2024-12-07 00:31 inconsistent use of SearchSysCacheCopy Jeff Davis <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox