Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1zCK-0007BN-OH for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Mar 2019 20:00:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h1zCJ-0005g8-87 for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Mar 2019 20:00:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1zCI-0005g1-Ti for pgsql-hackers@lists.postgresql.org; Thu, 07 Mar 2019 20:00:55 +0000 Received: from mx1.mailbox.org ([80.241.60.212]) by makus.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1zCB-0004F2-FT for pgsql-hackers@postgresql.org; Thu, 07 Mar 2019 20:00:53 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 47EF94C236 for ; Thu, 7 Mar 2019 21:00:44 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id 1G6FWWDOQr6Z for ; Thu, 7 Mar 2019 21:00:25 +0100 (CET) Message-ID: <8f9ab7b16daf623e87eeef5203a4ffc0dece8dfd.camel@cybertec.at> Subject: Small doc fix for pageinspect From: Laurenz Albe To: pgsql-hackers@postgresql.org Date: Thu, 07 Mar 2019 21:00:24 +0100 Organization: Cybertec Content-Type: multipart/mixed; boundary="=-1KXeT+PVMNjl1wae3TF6" MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --=-1KXeT+PVMNjl1wae3TF6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit I noticed today that the signature for two functions is wrong in the documentation: - "heap_page_item_attrs" has the argument order and return type wrong and is lacking types - "tuple_data_split" is lacking the type for "rel_oid" Patch attached. This should be backpatched down to 9.6 where the functions have been added. Yours, Laurenz Albe --=-1KXeT+PVMNjl1wae3TF6 Content-Disposition: attachment; filename*0=0001-Fix-documentation-of-pageinspect-function-signatures.pat; filename*1=ch Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Fix-documentation-of-pageinspect-function-signatures.patch"; charset="UTF-8" RnJvbSA0ZTk2NTVhMjRhOGY4NmIwMjBjNTA0MzFlYmEyMzc2ZjYyNGEzZGVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h dD4KRGF0ZTogVGh1LCA3IE1hciAyMDE5IDIwOjUwOjA1ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g Rml4IGRvY3VtZW50YXRpb24gb2YgcGFnZWluc3BlY3QgZnVuY3Rpb24gc2lnbmF0dXJlcwoKLS0t CiBkb2Mvc3JjL3NnbWwvcGFnZWluc3BlY3Quc2dtbCB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQs IDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mvc3JjL3Nn bWwvcGFnZWluc3BlY3Quc2dtbCBiL2RvYy9zcmMvc2dtbC9wYWdlaW5zcGVjdC5zZ21sCmluZGV4 IDljYmUzNGM5ZDkuLmVhYzY3MzUyZWMgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9wYWdlaW5z cGVjdC5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9wYWdlaW5zcGVjdC5zZ21sCkBAIC0xNTYsNyAr MTU2LDcgQEAgdGVzdD0jIFNFTEVDVCAqIEZST00gaGVhcF9wYWdlX2l0ZW1zKGdldF9yYXdfcGFn ZSgncGdfY2xhc3MnLCAwKSk7CiAKICAgIDx2YXJsaXN0ZW50cnk+CiAgICAgPHRlcm0+Ci0gICAg IDxmdW5jdGlvbj50dXBsZV9kYXRhX3NwbGl0KHJlbF9vaWQsIHRfZGF0YSBieXRlYSwgdF9pbmZv bWFzayBpbnRlZ2VyLCB0X2luZm9tYXNrMiBpbnRlZ2VyLCB0X2JpdHMgdGV4dCBbLCBkb19kZXRv YXN0IGJvb2xdKSByZXR1cm5zIGJ5dGVhW108L2Z1bmN0aW9uPgorICAgICA8ZnVuY3Rpb24+dHVw bGVfZGF0YV9zcGxpdChyZWxfb2lkIG9pZCwgdF9kYXRhIGJ5dGVhLCB0X2luZm9tYXNrIGludGVn ZXIsIHRfaW5mb21hc2syIGludGVnZXIsIHRfYml0cyB0ZXh0IFssIGRvX2RldG9hc3QgYm9vbF0p IHJldHVybnMgYnl0ZWFbXTwvZnVuY3Rpb24+CiAgICAgIDxpbmRleHRlcm0+CiAgICAgICA8cHJp bWFyeT50dXBsZV9kYXRhX3NwbGl0PC9wcmltYXJ5PgogICAgICA8L2luZGV4dGVybT4KQEAgLTE4 MSw3ICsxODEsNyBAQCB0ZXN0PSMgU0VMRUNUIHR1cGxlX2RhdGFfc3BsaXQoJ3BnX2NsYXNzJzo6 cmVnY2xhc3MsIHRfZGF0YSwgdF9pbmZvbWFzaywgdF9pbmZvbQogCiAgICA8dmFybGlzdGVudHJ5 PgogICAgIDx0ZXJtPgotICAgICA8ZnVuY3Rpb24+aGVhcF9wYWdlX2l0ZW1fYXR0cnMocmVsX29p ZCwgdF9kYXRhIGJ5dGVhLCBbLCBkb19kZXRvYXN0IGJvb2xdKSByZXR1cm5zIGJ5dGVhW108L2Z1 bmN0aW9uPgorICAgICA8ZnVuY3Rpb24+aGVhcF9wYWdlX2l0ZW1fYXR0cnModF9kYXRhIGJ5dGVh LCByZWxfb2lkIHJlZ2NsYXNzLCBbLCBkb19kZXRvYXN0IGJvb2xdKSByZXR1cm5zIHNldG9mIHJl Y29yZDwvZnVuY3Rpb24+CiAgICAgIDxpbmRleHRlcm0+CiAgICAgICA8cHJpbWFyeT5oZWFwX3Bh Z2VfaXRlbV9hdHRyczwvcHJpbWFyeT4KICAgICAgPC9pbmRleHRlcm0+Ci0tIAoyLjIwLjEKCg== --=-1KXeT+PVMNjl1wae3TF6--