Message-ID: <8fc461d7-aac6-0950-bcea-dc3aba5ff56b@pgmasters.net>
Date: Thu, 27 Apr 2023 21:28:26 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: Possible regression setting GUCs on \connect
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Korotkov <akorotkov@postgresql.org>,
 Pg Hackers <pgsql-hackers@postgresql.org>
References: <d46f9265-ff3c-6743-2278-6772598233c2@pgmasters.net>
 <1174363.1682612001@sss.pgh.pa.us>
 <e8c0fd08-ea2e-6878-2e94-910d9c447265@pgmasters.net>
 <1192180.1682619395@sss.pgh.pa.us>
Content-Language: en-US
From: David Steele <david@pgmasters.net>
In-Reply-To: <1192180.1682619395@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/8fc461d7-aac6-0950-bcea-dc3aba5ff56b%40pgmasters.net>
Precedence: bulk

On 4/27/23 21:16, Tom Lane wrote:
> David Steele <david@pgmasters.net> writes:
>> Seems plausible. This can be reproduced by cloning [1] into contrib and
>> running `make check`. I can work out another test case but it may not
>> end up being simpler.
>> [1] https://github.com/pgaudit/pgaudit/tree/dev-pg16-ci
> 
> I tried to replicate this per that recipe, but it works for me:
> 
> $ git clone https://github.com/pgaudit/pgaudit.git pgaudit
> $ cd pgaudit
> $ git checkout dev-pg16-ci
> $ make -s check
> # +++ regress check in contrib/pgaudit +++
> # using temp instance on port 61696 with PID 1191703
> ok 1         - pgaudit                                   310 ms
> 1..1
> # All 1 tests passed.

I included the errors in the expect log so I could link to them. So test 
success means the error is happening.

> Note that I had to add
> 
> $ diff -pud Makefile~ Makefile
> --- Makefile~   2023-04-27 14:02:19.041714415 -0400
> +++ Makefile    2023-04-27 14:07:10.056909016 -0400
> @@ -20,3 +20,5 @@ top_builddir = ../..
>   include $(top_builddir)/src/Makefile.global
>   include $(top_srcdir)/contrib/contrib-global.mk
>   endif
> +
> +EXTRA_INSTALL += contrib/pg_stat_statements

Yeah, I rarely run tests in-tree, but I'll add this if it does not break 
our regular CI.

-David