Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1seB1s-004cZW-0F for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Aug 2024 10:14:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1seB1p-009OvW-Uo for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Aug 2024 10:14:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1seB1p-009OvO-Fw for pgsql-hackers@lists.postgresql.org; Wed, 14 Aug 2024 10:14:53 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1seB1m-004nYM-Gi for pgsql-hackers@postgresql.org; Wed, 14 Aug 2024 10:14:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1723630489; bh=098NQWglhfAbRQxGfX5HXumtCGFsMl4Jx/J6LcCM7Uk=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=581yUO2cT313sx636vcwva1o5REpSP4ZEhCIXfCsxnxvJg2F470DUE+Spfc8sJ2dz DlgN6uLuN3ZJfHX7RBTHP0V4LIYbpPr5q7eowatuqcNv8RnRRSZfApsXvfVUNJuyn3 Ddl7nnZZscoICXhV+13JCnRwUh8LS7RsMH4rLzEunLtFO/MU+V7uXsdtmOhGI+C8xe JLNHFbC4Xcdegi76phroyRahC7LkkYzh6r/A6tepkDciG2etrhvhkRu1V614xzRws/ 7Wm2bjcntxj7vGED46tTdIvpKP0P4x9MeQMZF8mBkiU/1XaylXEPq1Er/vsaJKkJ4s 3lkWK7FIaZArw== Received: from [10.4.13.70] (unknown [93.174.131.141]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: s.kopikova@postgrespro.ru) by mail.postgrespro.ru (Postfix/465) with ESMTPSA id 176595FFE8; Wed, 14 Aug 2024 13:14:48 +0300 (MSK) Message-ID: <8ff5dbce-9eb2-4a22-b1dd-d6d387a5838c@postgrespro.ru> Date: Wed, 14 Aug 2024 13:14:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Apply PGDLLIMPORT markings to some GUC variables Content-Language: en-US To: Peter Eisentraut , Robert Haas Cc: pgsql-hackers@postgresql.org References: <859061b6-8aa6-49dc-be88-bdf7eebcbbb3@eisentraut.org> From: Sofia Kopikova In-Reply-To: <859061b6-8aa6-49dc-be88-bdf7eebcbbb3@eisentraut.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-KSMG-AntiPhishing: NotDetected, bases: 2024/08/14 09:37:00 X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2024/08/14 05:59:00 #26307828 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 8/14/24 12:50, Peter Eisentraut wrote: > On 13.08.24 21:00, Robert Haas wrote: >> On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova >> wrote: >>> I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to >>> header files. According to the commit message in 8ec569479, all >>> variables in header files must be marked with PGDLLIMPORT, am I right? >>> >>> I've made a patch that adds missing PGDLLIMPORTs, please, take a look. >> >> This seems correct to me. > > committed > Many thanks for quick review and commit. -- Best regards, Sofia Kopikova Postgres Professional: http://www.postgrespro.com