Subject: Re: wrong relkind error messages
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <202107021610.fv2n3ehw4yu7@alvherre.pgsql>
 <08b1063f-5341-c30e-6789-b523dd0e9e29@enterprisedb.com>
 <c9ba5c6a-4bd5-e12c-1b3c-edbcaedbf392@enterprisedb.com>
 <YPeEo99s6MaQucRl@paquier.xyz>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <8ff66f7e-d31b-3691-da73-afe20e238f80@enterprisedb.com>
Date: Wed, 21 Jul 2021 08:03:29 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YPeEo99s6MaQucRl@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/8ff66f7e-d31b-3691-da73-afe20e238f80%40enterprisedb.com>
Precedence: bulk

On 21.07.21 04:21, Michael Paquier wrote:
> On Tue, Jul 20, 2021 at 05:08:53PM +0200, Peter Eisentraut wrote:
>> While reviewing the logical decoding of sequences patch, I found a few more
>> places that could be updated in the new style introduced by this thread.
>> See attached patch.
> 
> Those changes look fine.  I am spotting one instance in
> init_sequence() that looks worth aligning with the others?

I think if you write "ALTER SEQUENCE foo", then "foo is not a sequence" 
would be an appropriate error message, so this doesn't need changing.

> Did you consider changing RangeVarCallbackForAlterRelation() or
> ExecGrant_Relation() when it came to this thread?  Just noticing that,
> while going through the code.

These might be worth another look, but I'd need to investigate more in 
what situations they happen.