Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyPZp-0001Jn-SM for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Jul 2020 00:59:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jyPZo-0008KO-Q9 for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Jul 2020 00:59:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyPZo-0008KH-J0 for pgsql-hackers@lists.postgresql.org; Thu, 23 Jul 2020 00:59:12 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyPZl-0002Hf-Ss for pgsql-hackers@postgresql.org; Thu, 23 Jul 2020 00:59:12 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 06N0x4r5090147; Wed, 22 Jul 2020 20:59:04 -0400 From: Tom Lane To: Michael Paquier cc: Alvaro Herrera , Justin Pryzby , Julien Rouhaud , Tomas Vondra , pgsql-hackers@postgresql.org Subject: Re: expose parallel leader in CSV and log_line_prefix In-reply-to: <20200723005214.GD26630@paquier.xyz> References: <20200721043325.GC17300@paquier.xyz> <20200722153605.GA961@alvherre.pgsql> <20200723005214.GD26630@paquier.xyz> Comments: In-reply-to Michael Paquier message dated "Thu, 23 Jul 2020 09:52:14 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <90145.1595465944.1@sss.pgh.pa.us> Date: Wed, 22 Jul 2020 20:59:04 -0400 Message-ID: <90146.1595465944@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Paquier writes: > On Wed, Jul 22, 2020 at 11:36:05AM -0400, Alvaro Herrera wrote: >> How about we combine both. "Process ID of the parallel group leader, if >> this process is a parallel query worker. NULL if this process is a >> parallel group leader or does not participate in parallel query". > Sounds fine to me. Thanks. > Do others have any objections with this wording? Is "NULL" really le mot juste here? If we're talking about text strings, as the thread title implies (I've not read the patch), then I think you should say "empty string", because the SQL concept of null doesn't apply. regards, tom lane