From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Andres Freund <andres@anarazel.de>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Using WaitEventSet in the postmaster
In-reply-to: 
 <CA+hUKGK-gv8=_0FPe3MMZkncozmTNBRT7NhsKBt3vHZ5Dxu2=A@mail.gmail.com>
References: <20221205180939.2p6zcrtevukgyay7@awork3.anarazel.de>
 <CA+hUKGLU6t-17dywkMADMBdPHhfvnHaS2JzWbu2Fd80220hrpw@mail.gmail.com>
 <20221206231230.3vwxd5dfc3gkf4vl@awork3.anarazel.de>
 <CA+hUKGLw+QFMpzTs4t84vUWQM-LWkv0Q67BVk0vBGvkpdUC7Yg@mail.gmail.com>
 <20221207012224.hjcyzvwdjim22e2a@awork3.anarazel.de>
 <CA+hUKGLAHAuHPJ9oWaRHP-CoME9MuATW=afZ+WQXHXMNw2m7rg@mail.gmail.com>
 <CA+hUKGJa+7=KccV+YJD9KtmOxyXmToxSRuTaAVvh14rNFh8LjQ@mail.gmail.com>
 <CA+hUKGKt58vOw8Y32Cy_Lnj8K2FGrty6-XO+bmkRnyuz5w-wJw@mail.gmail.com>
 <20230106232512.46jdujlcknqgj2ct@awork3.anarazel.de>
 <CA+hUKGLPZ8NUPfwAfi6Gd0y4CRSzBCTeAy7irE2B=-YsxAO3fQ@mail.gmail.com>
 <20230107225548.ppzg4rpninlthgth@awork3.anarazel.de>
 <CA+hUKGLGcUoFLDAMPEoU2EP-UmdGs+tHcfusxbyav71wgMrzLg@mail.gmail.com>
 <CA+hUKGK-gv8=_0FPe3MMZkncozmTNBRT7NhsKBt3vHZ5Dxu2=A@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Thu, 12 Jan 2023 17:03:02 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <901503.1673504836.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 12 Jan 2023 01:27:16 -0500
Message-ID: <901504.1673504836@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/901504.1673504836%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> Pushed, after a few very minor adjustments, mostly comments.  Thanks
> for the reviews and pointers.  I think there are quite a lot of
> refactoring and refinement opportunities unlocked by this change (I
> have some draft proposals already), but for now I'll keep an eye on
> the build farm.

skink seems to have found a problem:

=3D=3D2011873=3D=3D VALGRINDERROR-BEGIN
=3D=3D2011873=3D=3D Syscall param epoll_wait(events) points to unaddressab=
le byte(s)
=3D=3D2011873=3D=3D    at 0x4D8DC73: epoll_wait (epoll_wait.c:30)
=3D=3D2011873=3D=3D    by 0x55CA49: WaitEventSetWaitBlock (latch.c:1527)
=3D=3D2011873=3D=3D    by 0x55D591: WaitEventSetWait (latch.c:1473)
=3D=3D2011873=3D=3D    by 0x4F2B28: ServerLoop (postmaster.c:1729)
=3D=3D2011873=3D=3D    by 0x4F3E85: PostmasterMain (postmaster.c:1452)
=3D=3D2011873=3D=3D    by 0x42643C: main (main.c:200)
=3D=3D2011873=3D=3D  Address 0x7b1e620 is 1,360 bytes inside a recently re=
-allocated block of size 8,192 alloc'd
=3D=3D2011873=3D=3D    at 0x48407B4: malloc (vg_replace_malloc.c:381)
=3D=3D2011873=3D=3D    by 0x6D9D30: AllocSetContextCreateInternal (aset.c:=
446)
=3D=3D2011873=3D=3D    by 0x4F2D9B: PostmasterMain (postmaster.c:614)
=3D=3D2011873=3D=3D    by 0x42643C: main (main.c:200)
=3D=3D2011873=3D=3D =

=3D=3D2011873=3D=3D VALGRINDERROR-END

			regards, tom lane