Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uYBMO-002MAr-Fw for pgsql-hackers@arkaria.postgresql.org; Sat, 05 Jul 2025 22:27:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uYBML-00AXpm-IP for pgsql-hackers@arkaria.postgresql.org; Sat, 05 Jul 2025 22:27:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uYBML-00AXnP-7K for pgsql-hackers@lists.postgresql.org; Sat, 05 Jul 2025 22:27:49 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uYBMK-005mJe-0A for pgsql-hackers@postgresql.org; Sat, 05 Jul 2025 22:27:48 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 565MRi78090507; Sat, 5 Jul 2025 18:27:44 -0400 From: Tom Lane To: Peter Eisentraut cc: Andrew Dunstan , Michael Paquier , pgsql-hackers Subject: Re: C11 / VS 2019 In-reply-to: References: <01a69441-af54-4822-891b-ca28e05b215a@eisentraut.org> Comments: In-reply-to Peter Eisentraut message dated "Tue, 01 Jul 2025 10:31:38 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <90505.1751754464.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 05 Jul 2025 18:27:44 -0400 Message-ID: <90506.1751754464@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > On 04.06.25 08:15, Peter Eisentraut wrote: >> For an explanation, the background is that MSVC has a "traditional" = >> preprocessor and a new "conforming" one.=C2=A0 The latter is available = >> starting in VS 2019, but it's not the default.=C2=A0 We have some code,= = >> especially around __VA_ARGS__ that specifically caters to this = >> traditional preprocessor. > I have committed this. Buildfarm member drongo has been failing in initdb since 1 July: selecting default time zone ... UTC creating configuration files ... ok running bootstrap script ... = ----------------------------------- stderr -------------------------------= ---- TRAP: failed Assert("SysCache[cacheId]->cc_nkeys =3D=3D 2"), File: "../pgs= ql/src/backend/utils/cache/syscache.c", Line: 237, PID: 2684 child process was terminated by exception 0xC0000409 While there are 19 new commits in the first run that shows this failure [1], the only one that looks plausibly related is 8fd9bb1d965 Tue Jul 1 07:41:40 2025 UTC Enable MSVC conforming preprocess= or = because that changed our implementation of VA_ARGS_NARGS(), which is what's used to compute the cc_nkeys fields for syscaches. My conclusion is that Microsoft's "standards conforming" preprocessor is not so standards conforming as all that. regards, tom lane [1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Ddrongo&dt=3D= 2025-07-01%2016%3A09%3A21