public inbox for [email protected]
help / color / mirror / Atom feedRe: Unicode update and some tooling improvements
2+ messages / 2 participants
[nested] [flat]
* Re: Unicode update and some tooling improvements
@ 2026-02-27 02:50 Chao Li <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Chao Li @ 2026-02-27 02:50 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; +Cc: pgsql-hackers
> On Feb 27, 2026, at 04:36, Peter Eisentraut <[email protected]> wrote:
>
> This is the annual update of the Unicode data. I also worked a bit on the tooling. The update-unicode target under meson did not update the data in contrib/unaccent/, so I added that. I also fixed a Python deprecation warning in the generation script and made some light changes in the surrounding documentation.
> <0001-Fix-Python-deprecation-warning.patch><0002-doc-Fix-capitalization-of-Unicode.patch><0003-Implement-unaccent-Unicode-data-update-in-meson.patch><0004-Update-RELEASE_CHANGES.patch><0005-Update-Unicode-data-to-CLDR-48.1.patch><0006-Update-Unicode-data-to-Unicode-17.0.0.patch>
Overall looks good to me.
To verify this patch, I upgraded by local ICU to version 78.2, then I tried to run the python script:
```
chaol@ChaodeMacBook-Air postgresql % python3 contrib/unaccent/generate_unaccent_rules.py \
--unicode-data-file src/common/unicode/UnicodeData.txt \
--latin-ascii-file contrib/unaccent/Latin-ASCII.xml \
> /tmp/unaccent.rules.new
chaol@ChaodeMacBook-Air postgresql %
chaol@ChaodeMacBook-Air postgresql %
chaol@ChaodeMacBook-Air postgresql % diff -u contrib/unaccent/unaccent.rules /tmp/unaccent.rules.new # no difference
```
And I ran a clean meson build, and specially verified the new Unicode wiring:
```
chaol@ChaodeMacBook-Air postgresql % ninja -C build update-unicode # passed
```
And test:
```
chaol@ChaodeMacBook-Air postgresql % ninja -C build -t targets | grep update-unicode
update-unicode: phony
chaol@ChaodeMacBook-Air postgresql % ninja -C build test # passed
ninja: Entering directory `build'
[406/407] Running all tests
…
Ok: 333
Fail: 0
Skipped: 30
Full log written to /Users/chaol/Documents/code/postgresql/build/meson-logs/testlog.txt
```
Only a small comment on 0003:
```
# Meson 0.57.0 and 0.57.1 are buggy, therefore >=0.57.2.
- meson_version: '>=0.57.2',
+ # FIXME: update comment
+ meson_version: '>=0.58',
```
Why leaves a FIXME instead of just updating the comment? I saw the installation.sgml doc has been updated.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Unicode update and some tooling improvements
@ 2026-03-02 07:29 Peter Eisentraut <[email protected]>
parent: Chao Li <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Peter Eisentraut @ 2026-03-02 07:29 UTC (permalink / raw)
To: Chao Li <[email protected]>; +Cc: pgsql-hackers
On 27.02.26 03:50, Chao Li wrote:
> Only a small comment on 0003:
> ```
> # Meson 0.57.0 and 0.57.1 are buggy, therefore >=0.57.2.
> - meson_version: '>=0.57.2',
> + # FIXME: update comment
> + meson_version: '>=0.58',
> ```
>
> Why leaves a FIXME instead of just updating the comment? I saw the installation.sgml doc has been updated.
It wasn't meant to be committed that way. I just didn't want to spend
the time crafting a comment before it was generally agreed to proceed in
this way that required a meson version update.
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-03-02 07:29 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-02-27 02:50 Re: Unicode update and some tooling improvements Chao Li <[email protected]>
2026-03-02 07:29 ` Peter Eisentraut <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox