Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNPtt-0005lg-3g for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jun 2017 20:37:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dNPts-0002x3-Me for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jun 2017 20:37:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dNPsI-0006hY-N4 for pgsql-hackers@postgresql.org; Tue, 20 Jun 2017 20:35:46 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dNPsE-0004aH-C8 for pgsql-hackers@postgresql.org; Tue, 20 Jun 2017 20:35:46 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v5KKZaI3009081; Tue, 20 Jun 2017 16:35:36 -0400 From: Tom Lane To: Robert Haas cc: Peter Eisentraut , Julien Rouhaud , "pgsql-hackers@postgresql.org" Subject: Re: Typo in insert.sgml In-reply-to: References: <20170618071607.GA16418@nol.local> <8c2b8f00-1a4b-e91d-4d6b-e9add8e9e369@2ndquadrant.com> Comments: In-reply-to Robert Haas message dated "Tue, 20 Jun 2017 14:42:44 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <9079.1497990936.1@sss.pgh.pa.us> Date: Tue, 20 Jun 2017 16:35:36 -0400 Message-ID: <9080.1497990936@sss.pgh.pa.us> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Robert Haas writes: > On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut > wrote: >> This was not a typo, this was intentional. > To me, Julien's change seems to make it easier to understand, but > maybe I'm misunderstanding what it's trying to say in the first place. I think there are two subtly different things here: the sequence counters will continue to be attached to the identity columns, and the counters will continue in sequence (ie, no implied ALTER SEQUENCE RESTART). The existing text seems to mean the latter but Julien's change makes it about the former. It could use rewording for clarity, just not this rewording. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers